Summary: | Plack and tools/holidays.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Paul Poulain <paul.poulain> |
Component: | Architecture, internals, and plumbing | Assignee: | Paul Poulain <paul.poulain> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | blocker | ||
Priority: | P5 - low | CC: | chris, dpavlin, jonathan.druart |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 8842 fix Plack scoping for holidays
Bug 8842 fix Plack scoping in acquisition Bug 8842 fix Plack scoping for holidays |
Description
Paul Poulain
2012-09-28 13:15:25 UTC
Created attachment 13186 [details] [review] Bug 8842 fix Plack scoping for holidays the internal sub add_holiday uses some variables that are defined in the main script, usual fix Upgrading severity, it's a Blocker for Plack users Created attachment 13187 [details] [review] Bug 8842 fix Plack scoping in acquisition basket.pl has a local sub get_order_infos that require our-ing the $basketno variable Note that I had no problem with this variable. It may be some dead code, but I couldn't be sure it is, so I just switched basketno to "our" neworderempty.pl has 2 local sub that require our-ing some variables: subs MARCfindbreeding and Load_Duplicate Comment on attachment 13187 [details] [review] Bug 8842 fix Plack scoping in acquisition oops... wrong bug, it's 8892, not 8842. Will attach this one to the correct bug Created attachment 13199 [details] [review] Bug 8842 fix Plack scoping for holidays the internal sub add_holiday uses some variables that are defined in the main script, usual fix Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> QA Comment: This patch fixes the issue using plack and does not introduce regression. Marked as Passed QA. This patch has been pushed to master. Patch pushed to branch 3.10.x Released in 3.10.0 |