Bug 9077

Summary: OPAC Social media links broken by fix for Bug 8973
Product: Koha Reporter: Owen Leonard <oleonard>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: chris, paul.poulain, srikanth
Version: 3.8   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 9077 [3.8.x] OPAC Social media links broken by fix for Bug 8973
[SIGNED-OFF] Bug 9077 [3.8.x] OPAC Social media links broken by fix for Bug 8973

Description Owen Leonard 2012-11-14 17:09:22 UTC
The patch for Bug 8973 included changes to the social media links on the OPAC detail page, but the changes were based on master which includes the use of CSS sprites for the images. 3.8.x doesn't have the CSS sprites, so the images don't work.
Comment 1 Owen Leonard 2012-11-14 17:42:06 UTC Comment hidden (obsolete)
Comment 2 Srikanth Dhondi 2012-11-18 23:03:08 UTC
Created attachment 13505 [details] [review]
[SIGNED-OFF] Bug 9077 [3.8.x] OPAC Social media links broken by fix for Bug 8973

This patch returns the structure of the social media icons
markup to the state it was in before the application of the
patch for Bug 8973 and adds the missing filters which would
have been added by that patch.

To test, view any OPAC detail page in origin/3.8.x. After
applying this patch the social media icons should appear
normally.

Signed-off-by: Srikanth Dhondi <srikanth@catalyst.net.nz>
Comment 3 Paul Poulain 2012-11-20 15:01:43 UTC
Comment on attachment 13452 [details] [review]
Bug 9077 [3.8.x] OPAC Social media links broken by fix for Bug 8973

patch obsoleted by the signed-off one
Comment 4 Paul Poulain 2012-11-20 15:11:11 UTC
QA comment:
 * small patch, html only
 * for 3.8 only

passed QA
Comment 5 Chris Cormack 2012-11-26 00:29:18 UTC
Pushed to 3.8.x will be in 3.8.8