Bug 9153

Summary: Problem with config file for qa-test-tools
Product: Koha Reporter: Magnus Enger <magnus>
Component: Architecture, internals, and plumbingAssignee: Galen Charlton <gmcharlt>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: jonathan.druart
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:

Description Magnus Enger 2012-11-27 15:14:26 UTC
The README for qa-test-tools says:

2/ copy perlcriticrc file to your home dir (important!)
    $ cp /path/to/your/koha-qa-tools/perlcriticrc ~/

And koha-qa.pl checks for the existence of this file:

my $pc_rc = File::HomeDir->my_home . '/perlcriticrc';
die "your ~/perlcriticrc file is missing..." unless  ( -e  $pc_rc )

However, after copying the rc file as described in the README, I get errors complaining about "missing strictures before code", even though I am using "use Modern::Perl". After renaming ~/perlcriticrc to ~/.perlcriticrc those errors go away. So it looks like the script is picking up ~/.perlcriticrc but not ~/perlcriticrc

(Side note: Would it be better to recommend linking koha-qa-tools/perlcriticrc to ~/.perlcriticrc, so that any future changes to koha-qa-tools/perlcriticrc takes effect immediately, without the user having to copy the rc file again?)
Comment 1 Jonathan Druart 2015-04-01 09:45:40 UTC
This is fixed.