Bug 9225

Summary: Subroutines should not be defined in acqui/parcel.pl
Product: Koha Reporter: Jared Camins-Esakov <jcamins>
Component: AcquisitionsAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P5 - low CC: jonathan.druart, katrin.fischer, m.de.rooy, robin
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 12173    

Description Jared Camins-Esakov 2012-12-06 13:51:02 UTC
We should not be declaring subroutines in .pl files. Unfortunately, there are three routines currently declared in acqui/parcel.pl. When run under Plack, this results in the following warnings in the log:
Subroutine get_value_with_gst_params redefined at /home/jcamins/kohaclone/acqui/parcel.pl line 74.
Subroutine get_gste redefined at /home/jcamins/kohaclone/acqui/parcel.pl line 93.
Subroutine get_gst redefined at /home/jcamins/kohaclone/acqui/parcel.pl line 102.
Comment 1 Jonathan Druart 2015-03-05 11:28:11 UTC
These 3 subroutines have been removed by bug 13001.