Bug 10089 - Prevent renewing for restricted patrons
Summary: Prevent renewing for restricted patrons
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: David Cook
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-22 03:00 UTC by David Cook
Modified: 2016-12-05 21:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10089 - Prevent renewing for restricted patrons (6.22 KB, patch)
2013-04-22 03:36 UTC, David Cook
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2013-04-22 03:00:57 UTC
Currently, restricted patrons are not able to check out items, BUT they are able to renew checked out items. 

This isn't logical, since "renewing" an item is, essentially, equivalent to checking out the item again. 

In the OPAC patron screen, they are informed that their account is frozen, but...they are still able to renew books. 

--

I propose that we prevent restricted patrons from renewing items in the OPAC, and we prevent library staff from (accidentally) renewing books for restricted patrons in the staff client.

--

My patch will:

1) Prevent renewing of checked out items by patrons/staff
2) It will provide appropriate warning messages on the staff client and the OPAC
3) It will improve the style of the "Patron is restricted" message on moremember.tt so that it is the same as the message in circulation.tt (since they're both just tabs in the patron record anyways).
Comment 1 David Cook 2013-04-22 03:36:52 UTC
Created attachment 17570 [details] [review]
Bug 10089 - Prevent renewing for restricted patrons
Comment 2 Owen Leonard 2013-04-26 15:35:04 UTC
(In reply to comment #0)
> In the OPAC patron screen, they are informed that their account is frozen,
> but...they are still able to renew books. 

I do not see how they are able to renew books. The table of checkouts shows the count of renewals, but there are no controls on the page for renewing.

> 1) Prevent renewing of checked out items by patrons/staff

I think this is a good improvement but I think it's confusing that the "override renewal limit" checkbox still works to enable the renew checkboxes in the table of checkouts. If the user is restricted there should probably only be a button which says "Check in checked items."

I'm setting to "Failed QA" because I'd like clarification on the first issue at the very least in order to enable proper testing. It's arguable that the second issue isn't enough to block this.
Comment 3 David Cook 2013-04-28 23:24:03 UTC
(In reply to comment #2)
> (In reply to comment #0)
> > In the OPAC patron screen, they are informed that their account is frozen,
> > but...they are still able to renew books. 
> 
> I do not see how they are able to renew books. The table of checkouts shows
> the count of renewals, but there are no controls on the page for renewing.
> 

It appears that you are correct! I'm not sure why I said that patrons could still renew books through the OPAC. I would've sworn that I tested it and found that to be the case, but now that I'm looking...there are no controls as you say. It's probably worth dropping the opac-user.pl/.tt changes from this patch then.

> > 1) Prevent renewing of checked out items by patrons/staff
> 
> I think this is a good improvement but I think it's confusing that the
> "override renewal limit" checkbox still works to enable the renew checkboxes
> in the table of checkouts. If the user is restricted there should probably
> only be a button which says "Check in checked items."
> 
> I'm setting to "Failed QA" because I'd like clarification on the first issue
> at the very least in order to enable proper testing. It's arguable that the
> second issue isn't enough to block this.

Mmm, I didn't see that "override renewal limit" checkbox before. I also agree that there should only be a "Check in checked items" button. I'll take another look at this when I have some time.
Comment 4 Koha Team University Lyon 3 2013-05-04 15:29:42 UTC
I would have add Lyon3 right away in the list copy of this bug , I 'm confused. I didn't see you had already worked on it and also treated the restricted problem in the patch I proposed yesterday for bug 8236 (unlike I was supposed to do, I changed my mind).

Olivier Crouzet
Comment 5 David Cook 2013-05-05 23:43:14 UTC
(In reply to comment #4)
> I would have add Lyon3 right away in the list copy of this bug , I 'm
> confused. I didn't see you had already worked on it and also treated the
> restricted problem in the patch I proposed yesterday for bug 8236 (unlike I
> was supposed to do, I changed my mind).
> 
> Olivier Crouzet

Olivier, I added a link to this bug on bug 8236 (see comment #32) when I opened this one. 

I thought it might be rude to add Lyon3's email to the CC list, but I'll keep it in mind for next time ;).
Comment 6 Owen Leonard 2016-04-06 14:22:31 UTC
I think this has been fixed by Bug 8236.