Bug 10424 - Search against order numbers and pull up the related invoice to see when the item was receipted
Summary: Search against order numbers and pull up the related invoice to see when the ...
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Amit Gupta
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-06 08:02 UTC by Amit Gupta
Modified: 2021-01-28 16:13 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Search received orders (15.74 KB, patch)
2013-06-24 12:07 UTC, Amit Gupta
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10424 - Search received orders (15.78 KB, patch)
2013-07-26 04:06 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
Search Received order (15.65 KB, patch)
2013-10-17 16:28 UTC, Amit Gupta
Details | Diff | Splinter Review
Bug 10424 - Search received orders (15.65 KB, patch)
2015-04-04 21:05 UTC, Mark Tompsett
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Amit Gupta 2013-06-06 08:02:47 UTC
A separate invoice table which links to the aqorders table via the order number to search against order numbers and pull up the related invoice to see when the item was receipted in
Comment 1 Katrin Fischer 2013-06-06 22:02:47 UTC
Amit, have you checked 3.10+? We have an invoices table now that stores all information about the invoice itself and links to aqorders table.
Comment 2 Amit Gupta 2013-06-07 01:55:08 UTC
Hi Katrin,

Yes i know i am adding only orderline and datereceived filter.
Comment 3 Amit Gupta 2013-06-07 02:29:55 UTC
There is bug in GetInvoices subroutine (branchcode field is not in aqorders table).
Comment 4 Katrin Fischer 2013-06-07 07:22:17 UTC
Sorry for the misunderstanding :)
I think there is a patch pending somewhere to add this column, but I am not sure about the bug. Adding Jonathan to this bug in CC, maybe he knows as this is probably a Biblibre development. There is also a bug report about the filters in invoices not working correctly: bug 8854
Comment 5 Jonathan Druart 2013-06-07 08:06:08 UTC
The aqorders.branchcode is added by Bug 5336 - Acq history search (needs QA)
Comment 6 Katrin Fischer 2013-06-07 08:11:22 UTC
Cool, thx Jonathan!
Comment 7 Amit Gupta 2013-06-24 12:07:22 UTC Comment hidden (obsolete)
Comment 8 Srdjan Jankovic 2013-07-26 04:06:00 UTC Comment hidden (obsolete)
Comment 9 Katrin Fischer 2013-09-08 21:42:40 UTC
Hi Amit, 

there are a couple of small things:

It was decided a while ago that Koha will be distributed under GPL3+ - we have upated the coding guidelines with the appropriate license text: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence
Could you confirm this is ok for you and if so change receivedorders.pl accordingly?

Also, could you please add some unit tests for your new routines?
GetReceivedorder (maybe ReceivedOrder?)

You can add a follow up and switch the status back to signed off.
Comment 10 Amit Gupta 2013-10-17 16:28:54 UTC Comment hidden (obsolete)
Comment 11 I'm just a bot 2013-10-30 07:18:08 UTC
Applying: Bug 10424 - Search received orders
Using index info to reconstruct a base tree...
M	C4/Acquisition.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Acquisition.pm
CONFLICT (content): Merge conflict in C4/Acquisition.pm
Patch failed at 0001 Bug 10424 - Search received orders
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Comment 12 Mark Tompsett 2015-04-04 21:05:17 UTC
Created attachment 37500 [details] [review]
Bug 10424 - Search received orders

Search against order numbers and pull up the related
invoice to see when the item was received.

This allows users to see details of received orders,
including the details against which invoice the order is
received.

Test Plan:
1) Create a basket.
2) Create a orders under basket and close the basket.
3) Click on Receive shipment button and enter the invoice no and
shipment date.
4) Click on Receive link to receive the items.
5) Click on Received orders link on the left hand side.
6) This allow user to search by orderline, basket, title, author,
ISBN, vendor and date received.
7) Users will be able to see details of received orders.
Comment 13 Mark Tompsett 2015-04-04 21:07:39 UTC
You can't sign off your own patch, Amit. :)
I have rescued this. It was a simple enough fix.
I have not tested it. See the test plan provided in comment #12.
Comment 14 beroud 2015-12-17 10:36:09 UTC
With Test Plan:

I Created a basket.
I Created a orders under basket and closed the basket.
I Clicked on Receive shipment button and entered the invoice no and
shipment date.
I Clicked on Receive link to receive the items.
I Clicked on Received orders link on the left hand side.

Then, a message appeared, at this link :
http://pro.test14.biblibre.com/cgi-bin/koha/acqui/receivedorders.pl

Software error:
Can't locate C4/Dates.pm in @INC (@INC contains: /home/koha/src /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /home/koha/src/acqui/receivedorders.pl line 57.
BEGIN failed--compilation aborted at /home/koha/src/acqui/receivedorders.pl line 57.
For help, please send mail to the webmaster (webmaster@matrice-koha36-sandbox), giving this error message and the time and date of the error.
Comment 15 Jonathan Druart 2015-12-17 10:43:09 UTC
What's the point of this new page? You can search for received orders from the orders search form.