It would be good to be able to specifically target import records from z39.50 for cleanup.
Created attachment 23978 [details] [review] Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl It would be good to be able to specifically target import records from z39.50 for cleanup. Test Plan: 1) Apply this patch 2) Import one or more batch record sets into Koha 3) Perform some z39.50 searches 4) Run this command: misc/cronjobs/cleanup_database.pl -v --z3950 5) Verify that only z39.50 records were deleted
Created attachment 25774 [details] [review] Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl It would be good to be able to specifically target import records from z39.50 for cleanup. Test Plan: 1) Apply this patch 2) Import one or more batch record sets into Koha 3) Perform some z39.50 searches 4) Run this command: misc/cronjobs/cleanup_database.pl -v --z3950 5) Verify that only z39.50 records were deleted Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 27226 [details] [review] Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl It would be good to be able to specifically target import records from z39.50 for cleanup. Test Plan: 1) Apply this patch 2) Import one or more batch record sets into Koha 3) Perform some z39.50 searches 4) Run this command: misc/cronjobs/cleanup_database.pl -v --z3950 5) Verify that only z39.50 records were deleted Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Code looks good to me. No complaints from qa tools. Bonus points for follow-ups adding options for selectively removing z3950 records based on number of days (as in some other options) or printing the number of removed records with verbose. Passed QA
Pushed to master. Thanks, Kyle!
Pushed to 3.14.x, will be in 3.14.10