Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl
Summary: Add option to purge z39.50 search records from import table to cleanup_databa...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-06 18:45 UTC by Kyle M Hall
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl (3.40 KB, patch)
2014-01-06 18:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl (3.46 KB, patch)
2014-03-04 11:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl (3.56 KB, patch)
2014-04-17 06:59 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-01-06 18:45:45 UTC
It would be good to be able to specifically target import records from z39.50 for cleanup.
Comment 1 Kyle M Hall 2014-01-06 18:47:51 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-03-04 11:21:12 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2014-04-17 06:59:59 UTC
Created attachment 27226 [details] [review]
Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl

It would be good to be able to specifically target import records from
z39.50 for cleanup.

Test Plan:
1) Apply this patch
2) Import one or more batch record sets into Koha
3) Perform some z39.50 searches
4) Run this command: misc/cronjobs/cleanup_database.pl -v --z3950
5) Verify that only z39.50 records were deleted

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2014-04-17 07:02:57 UTC
QA Comment:
Code looks good to me. No complaints from qa tools.
Bonus points for follow-ups adding options for selectively removing z3950 records based on number of days (as in some other options) or printing the number of removed records with verbose.

Passed QA
Comment 5 Galen Charlton 2014-04-17 16:39:28 UTC
Pushed to master.  Thanks, Kyle!
Comment 6 Fridolin Somers 2014-08-06 09:46:02 UTC
Pushed to 3.14.x, will be in 3.14.10