Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders
Summary: Untranslatable confirm popup in field 006 and 008 builders
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-31 06:28 UTC by paxed
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders (3.07 KB, patch)
2014-03-22 17:58 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders (3.17 KB, patch)
2014-04-21 19:24 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders (3.24 KB, patch)
2014-04-22 05:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-01-31 06:28:13 UTC
marc21_field_006.tt and marc21_field_008.tt have the following confirmation popup, which is not picked up for translation:

confirm('Show values for \'' + form.material_type.options[form.material_type.selectedIndex].text + '\' material type?'))
Comment 1 Bernardo Gonzalez Kriegel 2014-03-22 17:58:08 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-04-21 19:24:04 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-04-22 05:36:02 UTC
Created attachment 27384 [details] [review]
[PASSED QA] Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders

This patch MARC21 modifies value builders 006 and 008 to make
confirm popup translatable

To test:
1) Update po files for your preferred language, xx-YY
cd misc/translator; perl translate update xx-YY
2) Check that confirm string is NOT present
egrep -B3 "Show values for|material type\?" po/xx-YY*po
3) Apply the patch
4) Repeat 1)
5) Repeat 2), now the strings are present

Also check that english or translated popup is right

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described.
Comment 4 Galen Charlton 2014-04-22 14:58:21 UTC
Pushed to master.  Thanks, Bernardo!
Comment 5 Fridolin Somers 2014-09-10 15:08:19 UTC
Pushed to 3.14.x, will be in 3.14.11