pendingreserves.tt includes a call to dt_add_type_uk_date(), which should be replaced with the title-string method for sorting dates. Additionally, sorting of the title column could be improved by adding the "anti-the" sorting method.
Created attachment 27138 [details] [review] Bug 12088 - Improve date handling and sorting in holds to pull report The holds to pull report could be improved by improving sorting on the title and date columns. This patch adds "anti-the" sorting to the title column and "title-string" sorting to the date column. Date formatting of another variable has been moved to the template for formatting using KohaDates. The patch includes other corrections for HTML validity. To test, apply the patch and view the holds to pull report. - Sorting by date should work correctly regardless of dateformat system preference setting. - Sorting of the title columns should correctly ignore articles. - Formatting of the "Reported on" date should be correct.
Created attachment 27489 [details] [review] Bug 12088 [Revised] Improve date handling and sorting in holds to pull report The holds to pull report could be improved by improving sorting on the title and date columns. This patch adds "anti-the" sorting to the title column and "title-string" sorting to the date column. Date formatting of another variable has been moved to the template for formatting using KohaDates. The patch includes other corrections for HTML validity. To test, apply the patch and view the holds to pull report. - Sorting by date should work correctly regardless of dateformat system preference setting. - Sorting of the title columns should correctly ignore articles. - Formatting of the "Reported on" date should be correct. Revision incorporates the corrections made by Bug 12127 and converts those changes to use class-based sorting.
Created attachment 27504 [details] [review] Bug 12088 [Revised] Improve date handling and sorting in holds to pull report The holds to pull report could be improved by improving sorting on the title and date columns. This patch adds "anti-the" sorting to the title column and "title-string" sorting to the date column. Date formatting of another variable has been moved to the template for formatting using KohaDates. The patch includes other corrections for HTML validity. To test, apply the patch and view the holds to pull report. - Sorting by date should work correctly regardless of dateformat system preference setting. - Sorting of the title columns should correctly ignore articles. - Formatting of the "Reported on" date should be correct. Revision incorporates the corrections made by Bug 12127 and converts those changes to use class-based sorting. Signed-off-by: David Cook <dcook@prosentient.com.au> The patch works as described. Thanks for including and improving the changes from Bug 12127, Owen!
I am sorry, but this patch no longer applies: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 12088 [Revised] Improve date handling and sorting in holds to pull report fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt).
Patch applies now that its dependency has been pushed. Setting status back to signed off.
Created attachment 27740 [details] [review] [PASSED QA] Bug 12088 [Revised] Improve date handling and sorting in holds to pull report The holds to pull report could be improved by improving sorting on the title and date columns. This patch adds "anti-the" sorting to the title column and "title-string" sorting to the date column. Date formatting of another variable has been moved to the template for formatting using KohaDates. The patch includes other corrections for HTML validity. To test, apply the patch and view the holds to pull report. - Sorting by date should work correctly regardless of dateformat system preference setting. - Sorting of the title columns should correctly ignore articles. - Formatting of the "Reported on" date should be correct. Revision incorporates the corrections made by Bug 12127 and converts those changes to use class-based sorting. Signed-off-by: David Cook <dcook@prosentient.com.au> The patch works as described. Thanks for including and improving the changes from Bug 12127, Owen! Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. No regressions found, works as advertised.
Pushed to master. Thanks, Owen!