Bug 12099 - process_message_queue.pl tells it sends print mails even if it doesn't.
Summary: process_message_queue.pl tells it sends print mails even if it doesn't.
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Olli-Antti Kivilahti
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-17 08:56 UTC by Olli-Antti Kivilahti
Modified: 2015-12-28 15:20 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
pätch (1.28 KB, patch)
2014-08-28 08:38 UTC, Olli-Antti Kivilahti
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Olli-Antti Kivilahti 2014-04-17 08:56:20 UTC
When running the cronjob in verbose mode, such warnings are generated:
sending print message to patron: 1008537 at /home/kivilahtio/koha/kohaclone/C4/Letters.pm line 754.
sending print message to patron: 1049202 at /home/kivilahtio/koha/kohaclone/C4/Letters.pm line 754.
sending print message to patron: 1015993 at /home/kivilahtio/koha/kohaclone/C4/Letters.pm line 754.
sending print message to patron: 1048403 at /home/kivilahtio/koha/kohaclone/C4/Letters.pm line 754.

When collecting cronjob output to log files, this irks me off because it actually doesn't do anything.

As a convenience, a patch is provided to simply warn when something is actually done, or tried to do.
Comment 1 Olli-Antti Kivilahti 2014-08-28 08:38:06 UTC
Created attachment 31234 [details] [review]
pätch

Made the C4::Letters::SendQueuedMessages() notify all but 'print' messages in verbose mode.
This way verbose mode provides a bit cleaner output.
Comment 2 Mark Tompsett 2015-04-28 00:30:37 UTC
So, test plan?
Comment 3 Jonathan Druart 2015-12-28 15:20:17 UTC
I don't think this is relevant, please detail the need.