When editing a notice, the input boxes take up a lot of space and are a distraction, but most of them are actually unused. By default, collapse the ones that have no title nor content, and allow opening them when clicking on the transport name.
Created attachment 28200 [details] [review] Collapse unused message transport types in notice editor When editing a notice, the input boxes take up a lot of space and are a distraction, but most of them are actually unused. By default, collapse the ones that have no title nor content, and allow opening them when clicking on the transport name. To test: 1) Apply patch 2) Go and edit a notice. The edit boxes for unused transport types should be collapsed, and clicking on the transport name should open the edit fields. 3) Saving and editing of the notice should still work.
It may already have changed in HEAD, and it doesn't apply anymore.
Comment on attachment 28200 [details] [review] Collapse unused message transport types in notice editor Review of attachment 28200 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt @@ +344,4 @@ > [% letter.message_transport_type %] > [% END %] > </legend> > + <ol[% IF (letter.title.length < 1 && letter.content.length < 1) %] class="noshow_mtt noshow_mtt_[% letter.message_transport_type%]"[% END %]> https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML
I believe upon further inspection that: $( "#transport-types" ).accordion({ collapsible: true, active:false, animate: 200 }); accomplishes what the point of this patch was. Marking as resolved/fixed.
(In reply to M. Tompsett from comment #4) > I believe upon further inspection that: > > $( "#transport-types" ).accordion({ collapsible: true, active:false, > animate: 200 }); > > accomplishes what the point of this patch was. Marking as resolved/fixed. Not really. The intention was to have the unused entries start as collapsed, and the entries in use as open - easier to see with a glance which ones are in use, without needing to scroll past the unused entries. If I understand correctly, accordion will just make it even more awkward to see which ones are in use.
Feel free to fix it then. :)
We now use an accordeon view that has all entries collapsed by default when the page is opened. As with the accordeon not more than one entry can be open at the same time, I feel that this makes sense. Closing for now, please reopen if you still see a need for changing the behavior.