Bug 12248 - Error when using course reserves with item-level_itypes set to biblio
Summary: Error when using course reserves with item-level_itypes set to biblio
Status: RESOLVED DUPLICATE of bug 11866
Alias: None
Product: Koha
Classification: Unclassified
Component: Course reserves (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-13 16:24 UTC by Kyle M Hall
Modified: 2017-09-06 14:43 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12248 - Error when using course reserves with item-level_itypes set to biblio (1.43 KB, patch)
2014-05-13 16:26 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2014-05-13 16:24:42 UTC
If item-level_itypes is set to biblio, viewing course-details.pl with a course that has reserves will result in a datatables error.
Comment 1 Kyle M Hall 2014-05-13 16:26:47 UTC
Created attachment 28216 [details] [review]
Bug 12248 - Error when using course reserves with item-level_itypes set to biblio

If item-level_itypes is set to biblio, viewing course-details.pl with a
course that has reserves will result in a datatables error.

Test Plan:
1) Set item-level_itypes to biblio
2) Enable course reserves
3) Create a course
4) Add an item to the course
5) View the course details
6) Note the error you recieve
7) Apply this patch
8) Reload course-details.pl
9) You should no longer recieve the error!
Comment 2 Jonathan Druart 2014-05-22 15:04:25 UTC
I think it has been decided to use class attributes for targeting columns.
Comment 3 Marcel de Rooy 2015-01-28 12:54:05 UTC
(In reply to Jonathan Druart from comment #2)
> I think it has been decided to use class attributes for targeting columns.
Could be, but it is not in the coding guidelines. And these constructs are still all over the place.

BUT: Another patch in the meantime added the antithe class and put it in the aTargets. This actually resolves the issue (afaict).
I move the status to FQA for now; if the current status of the template does not satisfy the author, please adjust your patch and resubmit.
Comment 4 Jonathan Druart 2017-09-06 14:43:09 UTC
This has been fixed by bug 11866

-                { 'bSortable': false, 'aTargets': [ 9, 10, 11 ] }
+                { 'bSortable': false, 'aTargets': [ 'NoSort' ] }

*** This bug has been marked as a duplicate of bug 11866 ***