Bug 12605 - TestBuilder - Refactoring Acquisition/close_reopen_basket.t
Summary: TestBuilder - Refactoring Acquisition/close_reopen_basket.t
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Chris Cormack
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 12603
Blocks:
  Show dependency treegraph
 
Reported: 2014-07-18 14:34 UTC by Yohann Dufour
Modified: 2018-02-08 13:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12604: refactoring close_reopen_basket.t with TestBuilder (4.42 KB, patch)
2014-07-18 14:56 UTC, Yohann Dufour
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12604: refactoring close_reopen_basket.t with TestBuilder (4.49 KB, patch)
2014-07-25 12:55 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Yohann Dufour 2014-07-18 14:34:03 UTC
In order to see what the module TestBuilder can bring to the writing of tests, the tests in Acquisition/close_reopen_basket.t have been refactored with the use of TestBuilder.
Comment 1 Yohann Dufour 2014-07-18 14:56:30 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-07-25 12:55:11 UTC
Created attachment 30089 [details] [review]
[SIGNED-OFF] Bug 12604: refactoring close_reopen_basket.t with TestBuilder

The tests have been refactored with the module TestBuilder.

Test plan:
1/ Apply the patch 12603 and the last patch of bug 11518.
2/ The command : prove t/db_dependent/Acquisition/close_reopen_basket.t has to be a success without error or warning :
t/db_dependent/Acquisition/close_reopen_basket.t .. ok
All tests successful.
Files=1, Tests=7,  1 wallclock secs ( 0.03 usr  0.01 sys +  1.71 cusr  0.09 csys =  1.84 CPU)
Result: PASS

http://bugs.koha-community.org/show_bug.cgi?id=12605

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Marcel de Rooy 2014-10-13 11:50:07 UTC
CONFLICT (content): Merge conflict in t/db_dependent/Acquisition/close_reopen_basket.t
Comment 4 Mark Tompsett 2015-06-17 12:10:54 UTC
Comment on attachment 30089 [details] [review]
[SIGNED-OFF] Bug 12604: refactoring close_reopen_basket.t with TestBuilder

Review of attachment 30089 [details] [review]:
-----------------------------------------------------------------

::: t/db_dependent/Acquisition/close_reopen_basket.t
@@ -46,5 @@
> -my ($ordernumber1, $ordernumber2);
> -( undef, $ordernumber1 ) = C4::Acquisition::NewOrder(
> -    {
> -        basketno => $basketno,
> -        quantity => 24,

How is this "quantity" reflected in the refactored code?

@@ -55,5 @@
>  
> -( undef, $ordernumber2 ) = C4::Acquisition::NewOrder(
> -    {
> -        basketno => $basketno,
> -        quantity => 42,

How is this "quantity" reflected in the refactored code?
Comment 5 Victor Grousset/tuxayo 2018-02-08 13:40:02 UTC
Yohann doesn't work anymore at BibLibre.
Unassigning to avoid signaling that this bug is still being supervized. Which could wrongly discourage someone to continue the work.