Bug 13237 - Regression: List of previous checkouts should be ordered by due date ascending
Summary: Regression: List of previous checkouts should be ordered by due date ascending
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 11703
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-12 01:07 UTC by Owen Leonard
Modified: 2016-06-21 21:36 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13237 - Regression: List of previous checkouts should be ordered by due date ascending (5.35 KB, patch)
2014-11-13 16:18 UTC, Kyle M Hall
Details | Diff | Splinter Review
Broken table ordering after apply the patch (236.64 KB, image/png)
2014-11-14 13:22 UTC, Owen Leonard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-11-12 01:07:09 UTC
Before Bug 11703 the list of previous checkouts on a patrons account were ordered with the oldest checkouts first. Now previous checkouts are shown with the newest checkouts first, breaking a sorting default which has been in place for years.
Comment 1 Kyle M Hall 2014-11-13 15:12:17 UTC
Note, the sorting of the checkouts was previously controlled by 
previousIssuesDefaultSortOrder & todaysIssuesDefaultSortOrder.

These settings were taken into account in svc/checkouts but at some point the datatables took over the initial sorting, which broke the feature afaict.
Comment 2 Kyle M Hall 2014-11-13 16:18:28 UTC
Created attachment 33523 [details] [review]
Bug 13237 - Regression: List of previous checkouts should be ordered by due date ascending

Before Bug 11703 the list of previous checkouts on a patrons account
were ordered with the oldest checkouts first. Now previous checkouts are
shown with the newest checkouts first, breaking a sorting default which
has been in place for years.

Note, the sorting of the checkouts was previously controlled by
previousIssuesDefaultSortOrder & todaysIssuesDefaultSortOrder.

These settings were taken into account in svc/checkouts but at some
point the datatables took over the initial sorting, which broke the
feature afaict.

Test Plan:
1) Find a patron with a set of previous and today's checkouts
2) Note the system preferences previousIssuesDefaultSortOrder
   and todaysIssuesDefaultSortOrder are ignored for the initial sorting
   view. Also not the sorting by due date does not work correctly.
3) Apply this patch
4) Test both system preferences with each setting, note the correct
   sort order.
5) Sort the checkouts by due date, note the correct sort order.
Comment 3 Owen Leonard 2014-11-14 13:22:05 UTC
Created attachment 33569 [details]
Broken table ordering after apply the patch

I'm getting broken table ordering after applying this patch. I applied the patch, cleared the browser cache, and checked out some items. Then I reloaded the page and got this result.
Comment 4 Kyle M Hall 2014-11-17 16:52:03 UTC
I saw this exact behavior during the development of this patch. However, I can't reproduce it using the submitted patch. Can you try clearing your browser cache and retesting?

(In reply to Owen Leonard from comment #3)
> Created attachment 33569 [details]
> Broken table ordering after apply the patch
> 
> I'm getting broken table ordering after applying this patch. I applied the
> patch, cleared the browser cache, and checked out some items. Then I
> reloaded the page and got this result.
Comment 5 Owen Leonard 2014-11-18 18:56:38 UTC
(In reply to Kyle M Hall from comment #4)
> Can you try clearing your
> browser cache and retesting?

Sorry, I got the same results after trying again.
Comment 6 Kyle M Hall 2015-05-29 12:00:20 UTC
I think bug 13908 fixed this issue.