Bug 13739 - KohaDates should display hours if they exists by default unless specified
Summary: KohaDates should display hours if they exists by default unless specified
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-20 15:26 UTC by Kyle M Hall
Modified: 2015-07-02 08:59 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13739 - KohaDates should display hours if they exists by default unless specified (1.64 KB, patch)
2015-02-20 15:29 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 13739 - KohaDates should display hours if they exists by default unless specified (1.64 KB, patch)
2015-03-02 14:13 UTC, Jesse Maseto
Details | Diff | Splinter Review
[SIGNED OFF] Bug 13739 - KohaDates should display hours if they exists by default unless specified (1.71 KB, patch)
2015-03-02 15:12 UTC, Jesse Maseto
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2015-02-20 15:26:11 UTC
There are many parts of Koha that are new hiding hours by default. This is rarely helpful. KohaDates should display hours by default unless the time is 23:59, in which case the hours should be not be displayed.
Comment 1 Kyle M Hall 2015-02-20 15:29:59 UTC Comment hidden (obsolete)
Comment 2 Jesse Maseto 2015-03-02 14:13:39 UTC Comment hidden (obsolete)
Comment 3 Jesse Maseto 2015-03-02 15:12:06 UTC
Created attachment 36322 [details] [review]
[SIGNED OFF] Bug 13739 - KohaDates should display hours if they exists by default unless specified

There are many parts of Koha that are now hiding hours by default. This
is rarely helpful. KohaDates should display hours by default unless the
time is 23:59, in which case the hours should be not be displayed.

Test Plan:
1) Check out two items, one due at at an hour, one not
2) View the patron's circ history, note you don't see the hours
3) Apply this patch
4) View the circ history again, note the hours are listed for date/time
   where the time is not 23:59.

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Comment 4 Jonathan Druart 2015-03-05 11:42:50 UTC
Kyle,
Before this patch, the plugin manages the as_due_date parameter. It's not with your patch.

Marked as Failed QA.
Comment 5 Kyle M Hall 2015-06-26 17:55:19 UTC
(In reply to Jonathan Druart from comment #4)
> Kyle,
> Before this patch, the plugin manages the as_due_date parameter. It's not
> with your patch.
> 
> Marked as Failed QA.

I'm not sure I'm following you. Can you explain what you mean a bit more and what you'd like to seem me change to get this to pass qa?

Thanks!
Comment 6 Jonathan Druart 2015-07-02 08:59:00 UTC
Kyle,

Before your patch, [% my_date | $KohaDates as_due_date => 1 %] worked to display a date as a due date.
After your patch, this parameter is not checked to display the date as requested.

And you should also have a look at t/db_dependent/Koha_template_plugin_KohaDates.t, the tests don't pass with your patch.