Bug 14308 - Remove CGI::checkbox from subfield editors
Summary: Remove CGI::checkbox from subfield editors
Status: RESOLVED DUPLICATE of bug 15773
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-01 12:27 UTC by Bernardo Gonzalez Kriegel
Modified: 2016-08-09 12:46 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (23.02 KB, patch)
2015-06-01 12:53 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2015-06-01 12:27:46 UTC
Use of CGI::checkbox prevents customization of templates
Comment 1 Bernardo Gonzalez Kriegel 2015-06-01 12:53:54 UTC
Created attachment 39739 [details] [review]
proposed patch

Bug 14308: Remove CGI::checkbox from subfield editors

This patch removes use of CGI::checkbox from
frameworks subfield editors.
Also removes use of CGI::escapeHTML

To test:
1) Apply the patch
2) Go to bibliographic frameworks, edit a field with subfields
3) Check for regressions on Edit/Save/Add subfields
i.e.
a. Edit subfield with known values on repeatable, mandatory, isurl checkbox
b. Change values, save, edit again and verify values.

4) Go to authority frameworks, edit a field with subfields
5) Check for regressions on Edit/Save/Add subfields
Comment 2 Marcel de Rooy 2015-08-27 12:20:18 UTC
Bernardo,
There is some problem in the authority side of this.
I cannot add a new subfield. I saw that existing data was overwritten.
Comment 3 Jonathan Druart 2016-02-18 11:32:38 UTC
Too bad that I have not seen your patch before, I have done the same job on bug 15773 :-/
Comment 4 Owen Leonard 2016-08-09 12:46:28 UTC

*** This bug has been marked as a duplicate of bug 15773 ***