Bug 14482 - Warns when exporting patron's checked-in barcodes
Summary: Warns when exporting patron's checked-in barcodes
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-01 05:27 UTC by Aleisha Amohia
Modified: 2016-12-05 21:22 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14482: Silences warns triggered when exporting patron's checked in barcodes (1.24 KB, patch)
2015-07-01 05:30 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2015-07-01 05:27:34 UTC
To recreate warns, go to any patron page and click More --> Export today's checked in barcodes 

readingrec.pl: Use of uninitialized value $borrowercardnumber in concatenation (.) or string at /home/vagrant/kohaclone/members/readingrec.pl line 88
readingrec.pl: Use of uninitialized value $borrowercardnumber in concatenation (.) or string at /home/vagrant/kohaclone/members/readingrec.pl line 88
Comment 1 Aleisha Amohia 2015-07-01 05:30:40 UTC
Created attachment 40746 [details] [review]
Bug 14482: Silences warns triggered when exporting patron's checked in barcodes

Use of uninitialized value $borrowercardnumber

To test:
1) Go to any patron page (ie http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=1369), click 'More' then 'Export today's checked in barcodes'
2) Notice warns in error log
3) Click cancel on the pop-up
4) Apply patch, reload page, click 'More' then 'Export today's checked in barcodes' again
5) Notice warns are gone and page still works correctly
Comment 2 Zeno Tajoli 2015-09-03 08:44:01 UTC
I don't the patch for SIPConfig.xml.
So probabli there is ame problem with code
Comment 3 Zeno Tajoli 2015-09-03 08:50:53 UTC
(In reply to Zeno Tajoli from comment #2)
> I don't the patch for SIPConfig.xml.
> So probabli there is ame problem with code

Wring comment
Comment 4 Bernardo Gonzalez Kriegel 2015-10-31 00:04:57 UTC
Can't reproduce
Comment 5 Marc Véron 2015-10-31 17:56:19 UTC
Reproduced:
readingrec.pl: Use of uninitialized value in pattern match (m//) at /usr/share/kohaclone/members/readingrec.pl line 80., referer: http://10.0.0.31:8080/cgi-bin/koha/members/moremember.pl?borrowernumber=1
Comment 6 Marc Véron 2015-10-31 18:34:28 UTC
Sorry, warning from comment #5 is on line 80 and it is not the same.
Comment 7 Marc Véron 2015-10-31 19:42:39 UTC
(In reply to Marc Véron from comment #6)
> Sorry, warning from comment #5 is on line 80 and it is not the same.

Update: Warning from comment #5 occurs if patron's privacy rules for the reading history are set to "Never".
Comment 8 Aleisha Amohia 2015-12-14 21:02:22 UTC
Can't see these warns anymore so they must've been fixed!