The toolbar for "Manage patron card batches" template shows "item(s)" instead of "patron(s)". This patch proposes to fix it.
Created attachment 41305 [details] patron(s) described as item(s)
Created attachment 41306 [details] [review] Bug 14631 - Change item(s) to patron(s) in toolbar The toolbar for "Manage patron card batches" template shows "item(s)" instead of "patron(s)". This patch proposes to fix it. Test plan ========= 1/ Go to Patron card creator > Manage patron card batches notice. 2/ Select a batch to edit, you should see the toolbar as described in attachment 41305 [details] 3/ Apply patch and refresh page. The toolbar should read correctly as 'patron(s)' 4/ Go back to step #1 above and select "New batch" and let the page automatically refresh. The toolbar button presented should read "Add patron(s)"
The patch works fine, but just wanted to add a few things which still should be changed from item(s) to patron(s): - title of 'Items in Batch number x' (which can be seen in your screenshot) - on the main Manage batches page where it gives a list of Currently Available Batches, there is a column title 'Item Count' - when adding a new batch, there is a message saying "There are no items in batch 0 yet, Use the toolbar above to add items." So in my opinion, four more instances where it should say patrons. Will set to Failed QA so you can submit a new patch :)
I noticed this while working on bug 14676, and was going to tidy it up as part of that. I'll use your stuff if you beat me to it though. :)
I hope it's OK to change module to Label/patroncard printing
Would this make sense to change the text in the file instead of using javascript to do it? If so I can try and make a new patch that does that.
Yeah, I think we should not do this with javascript. The right place would be to change the labels where they are generated, or have a look at jonathan's translation fixes for the label creator, which makes things more translatable: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41625&action=diff
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41626&action=diff sorry I meant this one.
On current master this has been fixed. We have "Add patron(s) Remove selected patrons ... Export selected card(s) Export card batch" There are other strings that need attention: alert(_("Deletion of item from a batch with only one item will delete the batch.\n\nIf this is what you want, select 'Delete batch' option from toolbar")); <strong>[% duplicate_count %] duplicate item(s) found</strong> and removed from batch [% batch_id %]. <h2>Items in batch number [% batch_id %]</h2> <h4>There are no items in this batch yet</h4> <p>Add items by borrowernumber using the text area above or leave empty to add via patron search.</p>
Created attachment 45889 [details] [review] Bug 14631: More changes from 'items' to 'patrons' Some of the changes Bernardo noticed were missed
A small translatability woe (sentence splitting by tags): <strong>[% duplicate_count %] duplicate patron(s) found</strong> and removed from batch [% batch_id %]. Maybe something like: <strong>Duplicate patron(s) removed from batch [% batch_id %]:</strong> [% duplicate_count %] or: <strong>Duplicates removed from batch [% batch_id %]:</strong> [% duplicate_count %] patron(s) or even: <strong>Duplicates removed from batch [% batch_id %]:</strong> [% duplicate_count %]
Created attachment 45919 [details] [review] Bug 14631: Translatability fix
Comment on attachment 41306 [details] [review] Bug 14631 - Change item(s) to patron(s) in toolbar Did not apply.
Hi, I'm not sure most of this is even applicable, as the patron card creator has had a UI overhaul since this bug was started. It would pay to go through and make sure we didn't miss any items -> patrons conversion as part of that work, but this may not be relevant anymore. Liz
Bug 14676 is the one that did most of that.
Aleisha has opened bug 15573 for the remaining things to be fixed here. As the UI is totally changed, nothing here is of importance anymore. Liz