In reserve/request.pl if you have a hold entry without a barcode and someone has added a new hold after the barcodeless hold, the barcodeless hold will get the new hold's itemnumber and the new hold will have no itemnumber and so the new hold will be set at biblio level.
Created attachment 43059 [details] [review] Bug 14942: add itemnumber even though there is no barcode Adding item number even though there's no barcode makes sure that some holds are not missing item number (and some won't have other hold's item numbers) and therefore not being changed to biblio level holds. Test plan: 1. Have a item level hold entry without a barcode 2. Add now a new item level hold request through OPAC 3. Go to edit that new hold request's pickup library through staff side. 4. Notice that the new hold request is now at biblio level 5. Apply patch 6. Do the same steps as before but now notice that the new hold request is still at item level. Sponsored-by: Vaara-kirjastot
Wanted to test, but patch does not apply: fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt). Repository lacks necessary blobs to fall back on 3-way merge.
Not sure if this is still relevant. Tested it and couldn't repeat the problem.
I've tested too and can't replicate the issue. The item level hold stays item level. There have been lots of changes since this was filed, so I tihnk it could have easily been fixed as a side effect of another bug.