Bug 14942 - if there is no barcode, item level hold can become a biblio level hold
Summary: if there is no barcode, item level hold can become a biblio level hold
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Joonas Kylmälä
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-02 12:08 UTC by Joonas Kylmälä
Modified: 2020-06-04 20:33 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14942: add itemnumber even though there is no barcode (2.47 KB, patch)
2015-10-02 12:25 UTC, Joonas Kylmälä
Details | Diff | Splinter Review
Bug 16942 - Confirm hold results in ugly error (1.66 KB, patch)
2016-07-19 17:50 UTC, Mirko Tietgen
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Kylmälä 2015-10-02 12:08:38 UTC
In reserve/request.pl if you have a hold entry without a barcode and someone has added a new hold after the barcodeless hold, the barcodeless hold will get the new hold's itemnumber and the new hold will have no itemnumber and so the new hold will be set at biblio level.
Comment 1 Joonas Kylmälä 2015-10-02 12:25:19 UTC
Created attachment 43059 [details] [review]
Bug 14942: add itemnumber even though there is no barcode

Adding item number even though there's no barcode makes sure that some holds
are not missing item number (and some won't have other hold's item numbers)
and therefore not being changed to biblio level holds.

Test plan:
1. Have a item level hold entry without a barcode
2. Add now a new item level hold request through OPAC
3. Go to edit that new hold request's pickup library through staff side.
4. Notice that the new hold request is now at biblio level
5. Apply patch
6. Do the same steps as before but now notice that the new hold request is
   still at item level.

Sponsored-by: Vaara-kirjastot
Comment 2 Marc Véron 2015-12-16 18:25:09 UTC
Wanted to test, but patch does not apply:

fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Comment 4 Emmi Takkinen 2019-07-25 06:38:22 UTC
Not sure if this is still relevant. Tested it and couldn't repeat the problem.
Comment 5 Katrin Fischer 2019-08-11 13:16:07 UTC
I've tested too and can't replicate the issue. The item level hold stays item level. There have been lots of changes since this was filed, so I tihnk it could have easily been fixed as a side effect of another bug.