Bug 18273 - Bulkmarcimport inserts authority duplicates
Summary: Bulkmarcimport inserts authority duplicates
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Matthias Meusburger
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-15 15:30 UTC by Matthias Meusburger
Modified: 2023-09-10 16:06 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18273: Do not insert authority if there already are duplicates in koha (842 bytes, patch)
2017-03-15 16:12 UTC, Matthias Meusburger
Details | Diff | Splinter Review
Bug 18273: Do not insert authority if there already are duplicates in koha (851 bytes, patch)
2022-11-23 18:30 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Meusburger 2017-03-15 15:30:40 UTC
When importing authorities through bulkmarcimport with the -match option, there are 3 possibilities:

1) An existing authority has been found in koha according to the -match criteria. The authority is replaced if needed (005 are checked first). This is ok.

2) No authority is found in koha according to the -match criteria. The authority is inserted. This is also ok.

3) Multiple authorities have been found in koha according to the -match criteria.  The authority is inserted. 

=> Is this the expected behavior?

As the -match criteria is used for deduping, the existing authorities are very likely to be already existing duplicates. Do we really want to add another one?

My feeling is that in this case, the authority should NOT be inserted.

Can I have your opinion on this?
Comment 1 Matthias Meusburger 2017-03-15 16:12:04 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2017-03-19 21:40:03 UTC
The bibliographic import overlays the one with the lower (or higher?) biblionumber. Not sure if we should make it consistent.
Comment 3 Matthias Meusburger 2017-03-20 08:56:16 UTC
Are you sure about that Katrin?

From what I've seen, the behaviour is the same for biblios: if multiple matching biblios have been found, a new biblio is inserted.
Comment 4 Katrin Fischer 2017-03-20 09:00:05 UTC
Hm, I was pretty sure, but was thinking of the staged marc tool. Didn't realize then it will probably be different for bulkmarcimport. Makes sense then.
Comment 5 Fridolin Somers 2021-03-11 11:55:42 UTC
Need signoff ?
Comment 6 Fridolin Somers 2021-12-03 21:17:05 UTC
Needs an easy rebase
Comment 7 Koha Team University Lyon 3 2022-05-18 09:44:37 UTC
Hi,
it would be nice to have a follow-up on this one.
Thx
Sonia
Comment 8 David Nind 2022-11-23 18:30:08 UTC
Created attachment 144213 [details] [review]
Bug 18273: Do not insert authority if there already are duplicates in koha
Comment 9 David Nind 2022-11-23 18:36:26 UTC
I think I managed to successfully rebase this one, but I'm not sure how to test.

If we could get a test plan, I'll have a go at testing.

It would be great if the test plan could include:
- the bulkmarcimport command to use, and
- authority record samples to use to test the scenarios outlined in the bug description (or how to create).
Comment 10 Katrin Fischer 2023-09-10 16:06:20 UTC
Patch still applies, but is missing a test plan. 

I think some hints, especially on the CLI parameters to use with bulkmarcimport could help to get this further.