Created attachment 67119 [details] [review] Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - tests This patch proves that we will not introduce trivial regression. With the same tests, we will execute the existing code and the new code. Test plan: With only this patch applied, prove t/db_dependent/Koha/IssuingRules.t should return green
Created attachment 67120 [details] [review] Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed This patchset move The OPACItemHoldsAllowed logic (issuingrules.opacitemholds) to a new class method of Koha::IssuingRules: get_opacitemholds_policy On the way, this patch will certainly fix the same problem as bug 19298 with onshelfholds. Test plan: Make sure the opacitemholds policy is correct when placing a hold at the OPAC or the staff interface.
Created attachment 67121 [details] [review] Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - Remove the subroutine At this point the subroutine is not longer in use, we can remove it
Created attachment 67388 [details] [review] Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - tests This patch proves that we will not introduce trivial regression. With the same tests, we will execute the existing code and the new code. Test plan: With only this patch applied, prove t/db_dependent/Koha/IssuingRules.t should return green Followed test plan, patches worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Created attachment 67389 [details] [review] Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed This patchset move The OPACItemHoldsAllowed logic (issuingrules.opacitemholds) to a new class method of Koha::IssuingRules: get_opacitemholds_policy On the way, this patch will certainly fix the same problem as bug 19298 with onshelfholds. Test plan: Make sure the opacitemholds policy is correct when placing a hold at the OPAC or the staff interface. Followed test plan which worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Created attachment 67390 [details] [review] Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - Remove the subroutine At this point the subroutine is not longer in use, we can remove it Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
QA: Looking here now too
require C4::Reserves; Did I really see that ?
Created attachment 70101 [details] [review] Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - tests This patch proves that we will not introduce trivial regression. With the same tests, we will execute the existing code and the new code. Test plan: With only this patch applied, prove t/db_dependent/Koha/IssuingRules.t should return green Followed test plan, patches worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 70102 [details] [review] Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed This patchset move The OPACItemHoldsAllowed logic (issuingrules.opacitemholds) to a new class method of Koha::IssuingRules: get_opacitemholds_policy On the way, this patch will certainly fix the same problem as bug 19298 with onshelfholds. Test plan: Make sure the opacitemholds policy is correct when placing a hold at the OPAC or the staff interface. Followed test plan which worked as described Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 70103 [details] [review] Bug 19300: Replace C4::Reserves::OPACItemHoldsAllowed - Remove the subroutine At this point the subroutine is not longer in use, we can remove it Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Marcel de Rooy from comment #8) > require C4::Reserves; > Did I really see that ? It is removed in the next patch. The goal was to prove that the same tests were passing with the current code and the new code :)
Pushed to master for 18.05, thanks to everybody involved!
Enhancement, skipping for 17.11.x. Awesome work everybody!