Backport of 22650 makes an object call to an item hashref retrieved by get item: 94 if ( CanItemBeReserved($borrower->{'borrowernumber'}, $item->itemnumber, $branch)->{status} eq 'OK' ) { Should be $item->{itemnumber}
Created attachment 89666 [details] [review] Bug 22895: Correct itemnumber call in placerequest.pl To test: 1 - Try to place an item level hold 2 - It fails 3 - Aply patch 4 - Try again 5 - It works!
Created attachment 89669 [details] [review] Bug 22895: (bug 22650 follow-up) Correct itemnumber call in placerequest.pl Backport of 22650 makes an object call to an item hashref retrieved by get item: 94 if ( CanItemBeReserved($borrower->{'borrowernumber'}, $item->itemnumber, $branch)->{status} eq 'OK' ) { Should be $item->{itemnumber} To test: 1 - Try to place an item level hold 2 - It fails 3 - Aply patch 4 - Try again 5 - It works! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Upping severity, sending directly to Martin. Shall we alert the list?
Created attachment 89735 [details] [review] Bug 22895: (bug 22650 follow-up) Correct itemnumber call in placerequest.pl Backport of 22650 makes an object call to an item hashref retrieved by get item: 94 if ( CanItemBeReserved($borrower->{'borrowernumber'}, $item->itemnumber, $branch)->{status} eq 'OK' ) { Should be $item->{itemnumber} To test: 1 - Try to place an item level hold 2 - It fails 3 - Aply patch 4 - Try again 5 - It works! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Annoying I missed this, thanks for the report Nick and quick QA Jonathan. Pushed to 18.11.x for 18.11.06