Building on 22318, the OpacNavBottom system preference should be converted to a Koha news block.
Can we rush this for 21.11? :)
Created attachment 127360 [details] [review] Bug 24224: Convert OpacNavBottom system preference to additional content This patch builds on Bug 22318 to move the OpacNavBottom system preference into the "Additional contents" system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNavBottom system preference. To make testing easier it's also a good idea to have content in the OpacNav preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from OpacNavBottom is now stored there. When you edit the entry you should see content from the OpacNavBottom system preference under the "default" tab. - The publication date for the entry should be today's date. - Confirm that the previous contents of OpacNavBottom were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavBottom preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNavBottom system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNavBottom is also displayed. - Test also using the updated translation.
Created attachment 127363 [details] [review] Bug 24224: Convert OpacNavBottom system preference to additional content This patch builds on Bug 22318 to move the OpacNavBottom system preference into the "Additional contents" system, making it possible to have language- and library-specific content. To test you should have some content in the OpacNavBottom system preference. To make testing easier it's also a good idea to have content in the OpacNav preference. - Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from OpacNavBottom is now stored there. When you edit the entry you should see content from the OpacNavBottom system preference under the "default" tab. - The publication date for the entry should be today's date. - Confirm that the previous contents of OpacNavBottom were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavBottom preference has been removed. - Update and reinstall active translations (for instance fr-FR): - cd misc/translator/ - perl translate update fr-FR - perl translate install fr-FR - View the OPAC and confirm that the contents of the OpacNavBottom system preference displays in the left-hand sidebar. - Test as many pages as possible to confirm that wherever the OpacNavBottom content is displayed, OpacNavBottom is also displayed. - Test also using the updated translation. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This looks great.. signing off. One query.. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt That adds OpacNav too here.. shouldn't that have been caught in the dependency bug already?
(In reply to Martin Renvoize from comment #4) > This looks great.. signing off. > > One query.. > > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt > > That adds OpacNav too here.. shouldn't that have been caught in the > dependency bug already? Yes, line will be moved on push.
Pushed to master for 21.11, thanks to everybody involved!