Bug 2604 - Appending "\" character to a search defeats fuzzy searching
: Appending "\" character to a search defeats fuzzy searching
Status: NEW
Product: Koha
OPAC
: HEAD
: All All
: P3 minor (vote)
Assigned To: Galen Charlton
:
: http://thebookpile.wordpress.com/2008...
:
:
  Show dependency treegraph
 
Reported: 2008-09-11 07:13 UTC by Chris Cormack
Modified: 2010-07-28 18:55 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:53:22 UTC


---- Reported by warren.layton@googlemail.com 2008-09-11 19:13:21 ----

I was playing the Athens, OH, OPAC and accidentally entered "orwell\" instead
of "orwell", which gave me an error indicating an "Internal Server Error". It
seems that the "\" is being inserted into the regular expression used for the
search and isn't stripped out.



---- Additional Comments From chris@bigballofwax.co.nz 2008-09-11 19:54:27 ----

Confirming the bug exists

http://public.demo.kohalibrary.com/cgi-bin/koha/opac-search.pl?q=fish\

Although, 

http://opac.koha.workbuffer.org/cgi-bin/koha/opac-search.pl?q=\
Which is running from git appears to be fine, so it may have been fixed and not
ported to the stable branch.

It also seems fine in earlier versions of koha
http://opac.wlpl.org/cgi-bin/koha/opac-search.pl?op=do_search&type=opac&marclist=&and_or=and&excluding=&operator=contains&value=fish\

Gets no error



---- Additional Comments From oleonard@myacpl.org 2008-09-13 06:19:41 ----

In my up-to-date repo a search for "fish/" or"fish" returns results, but a
search for "fish\" does not.



---- Additional Comments From chris@bigballofwax.co.nz 2008-09-14 00:13:26 ----

Does it internal server error though owen?
That was what it was doing at NPL and a few other catalogues (no results is
fine if there are no matches for fish\ , server erroring isnt :))



---- Additional Comments From oleonard@myacpl.org 2008-09-14 12:41:00 ----

"fish/" or"fish" returns results. "fish\" returns "No results found!"  No
results is isn't fine if the other two return results...shouldn't fuzzy
searching return something either way?



---- Additional Comments From chris@bigballofwax.co.nz 2008-09-14 14:06:14 ----

Ok, its finer than internal server error though. :) Which was the bug reported.

Is that fixed on NPL now?

Yep fuzzy searching should find something with fish, fish\ or fish/ but as a
first step, it'd be good to just stop the internal server error (ie trap the \
correctly).
Ill have a look at it tonight



---- Additional Comments From oleonard@myacpl.org 2008-09-15 09:07:28 ----

NPL (search.athenscounty.lib.oh.us) is still on dev_week, so those results are
pretty much moot.



---- Additional Comments From nengard@gmail.com 2009-12-23 17:59:31 ----

This bug hasn't been touched in nearly a year, please revisit and test and
close if appropriate.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:53 UTC  ---

This bug was previously known as _bug_ 2604 at
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2604

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was warren.layton@googlemail.com.