Bug 2713 - Opac detail content overlaps when right column extends too far
Summary: Opac detail content overlaps when right column extends too far
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact:
URL: http://nekls.test.kohalibrary.com/cgi...
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-23 08:19 UTC by Owen Leonard
Modified: 2012-10-25 22:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (11.76 KB, patch)
2009-05-02 15:55 UTC, Chris Cormack
Details | Diff | Splinter Review
Revised patch (12.76 KB, patch)
2009-06-29 20:01 UTC, Chris Cormack
Details | Diff | Splinter Review
additional edits (13.28 KB, patch)
2009-08-26 22:20 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:55:00 UTC


---- Reported by oleonard@myacpl.org 2008-10-23 08:19:47 ----

If the holdings table is too wide and the right column too long there is a collision of objects on the page making it unreadable. The effect may only be noticeable below a certain browser width, about 1300x1000, but most users will have a small browser window.

[10:35]	<owen>	I wanted to bring you and anyone else here into a discussion of a layout problem we have with opac-detail
[10:35]	<owen>	http://fsc.kohalibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=114661
[10:35]	<owen>	http://nekls.test.kohalibrary.com/cgi-bin/koha/opac-detail.pl?biblionumber=41489
[10:36]	<owen>	If the right-hand sidebar extends down too far, and the holdings table is too wide, we get a collision
[10:38]	<danny>	oh I see it, I didn't see it before because my resolution is too wide
[10:40]	<gmcharlt>	I think moving from a table to an arrangement where each item is described on two lines would keep the holdings table from getting too wide
[10:40]	<gmcharlt>	something like location collection, and call number of the first line
[10:41]	<gmcharlt>	volume and status information on the second
[10:45]	<owen>	Here's an alternative solution:
[10:45]	<owen>	http://zivotdesign.com/examples/opac-detail-fsc.html
[10:45]	<owen>	http://zivotdesign.com/examples/opac-detail-nekls.html
[10:46]	<owen>	And I know there are problems with the table sorting with large sets, but I'd hate to lose the ability to do sorting
[10:48]	<gmcharlt>	yes, but it must be possible to page through long item lists first
[10:50]	<danny>	personally i like how the alternative solution looks owen
[10:50]	<gmcharlt>	re the proposed redesigns, I can see getting rid of the left column
[10:51]	<gmcharlt>	I think save record should go back up with the other actions
[10:51]	<danny>	good idea of moving them to the bottom
[10:51]	<gmcharlt>	my concern, though is that the other search links will effectively disappear from the patron's POV by being pushed to the bottom
[10:52]	<owen>	gmcharlt: maybe so. I'm used to dealing with records with a small number of items.
[10:52]	<danny>	that left column is prime real estate and should meet the needs of what a majority of users are looking for
[10:52]	<gmcharlt>	but of course, question is what set of users
[10:53]	<gmcharlt>	for example, academic users are more likely to use the save record link
[10:53]	<gmcharlt>	and I see no particular reason to put it down on the bottom
[10:53]	<gmcharlt>	for the other search links, maybe adding it to the top right-hand box
[10:53]	<danny>	good point, I can only come at it from the eyes of a public library
[10:53]	<gmcharlt>	but just as a link that creates a floating panel of the specific links
[10:54]	<gmcharlt>	would keep the action box at a finite size
[10:54]	<gmcharlt>	no matter how many additional search links are configured
[10:54]	<gmcharlt>	while still making it reasonably visibl
[10:55]	<danny>	you are thinking like to add an anchor that would then pop you to the bottom of the page?
[10:55]	<danny>	or do I misunderstand
[10:55]	<gmcharlt>	no
[10:55]	<owen>	If we 1) took out OpacNav on the detail page and 2) convert the save and search options to single links, that might be enough
[10:56]	<gmcharlt>	an anchor that would open a layer over the bib details with the set of seach links



---- Additional Comments From nengard@gmail.com 2008-10-23 17:31:54 ----

I personally think that a temp solution is okay if it means the page is readable.  I like the idea of a tab for similar items and having the save as and search other at the bottom.  

Moving stuff to the left will be an issue I think because you'll still have to scroll horizontally and that's not good design.



---- Additional Comments From oleonard@myacpl.org 2008-10-30 08:41:08 ----

Another working example which moves the similar items into a tab:

http://zivotdesign.com/examples/opac-detail-2.html

I thought the NEKLS example (http://zivotdesign.com/examples/opac-detail-nekls.html) would be the way to go, but that choice really only looks good if you've got several similar titles to display. Fewer, and it looks very awkward.

Putting the similar titles into a tab has a couple of disadvantages:

1. It hides interesting content. The same could be said of any of the other tabs, I suppose.
2. The 'Similar' and 'Editions' tabs might be confusing in their similarity. I'm not sure if there's a better way to label these. I do know that I want to limit the length of the labels to prevent the tabs from getting too wide and wrapping at lower screen resolutions.



---- Additional Comments From nengard@gmail.com 2008-10-30 11:47:11 ----

Personally, I like this this way!!  With the new tab



---- Additional Comments From oleonard@myacpl.org 2009-05-02 15:55:36 ----

Created an attachment
Proposed fix

My proposed fix eliminates the OpacNav column on this page. It puts the "search for this title in..." links into a drop-down menu, and it moves the "similar items" display into a tab along with Holdings, Reviews, etc.



---- Additional Comments From oleonard@myacpl.org 2009-06-29 20:01:10 ----

Created an attachment
Revised patch





---- Additional Comments From gmcharlt@gmail.com 2009-07-14 11:04:21 ----

Patch pushed to HEAD.

Now that OpacNav has been removed from the default bib details page, the same needs to be done to the MARC and ISBD views.



---- Additional Comments From nengard@gmail.com 2009-08-26 22:20:11 ----

Created an attachment
additional edits





---- Additional Comments From gmcharlt@gmail.com 2009-09-06 16:11:59 ----

Pushed followup patches.  I think this bug is ready for final testing and closing.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:55 UTC  ---

This bug was previously known as _bug_ 2713 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2713
This bug blocked bug(s) 3122.
Imported an attachment (id=812)
Imported an attachment (id=813)
Imported an attachment (id=814)

Actual time not defined. Setting to 0.0
The original submitter of attachment 812 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 813 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 814 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.