To test: - have an item with multiple copies - place an item-level hold on one of the copies - go to Holds to Pull (/cgi-bin/koha/circ/pendingreserves.pl) - confirm it shows "[one of the barcodes] or any available" when it should show specifically the barcode of the item on which your hold was placed and should not show "or any available"
Created attachment 125566 [details] [review] Bug 29148: Check reserves.item_level_hold in Holds to Pull To test: 1 - place an item level hold 2 - go to Holds to Pull, see it shows "[barcode] or any available" 3- apply patch, restart 4- reload Holds to Pull, see it shows "only [barcode]"
I'm honestly not sure why the existing code started to fail here, but I changed it to check for item_level_hold=1, rather than presence of an itemnumber. It seems like a more reliable check anyway.
Patch solves the item-level hold issue. However, patch breaks title-level hold barcode display. To test: - have an 2 records with multiple copies - place an item-level hold on one of the copies for record A - place a title-level hold for record B - go to Holds to Pull (/cgi-bin/koha/circ/pendingreserves.pl) - confirm it shows "only barcode" on BOTH holds when it should show specifically the barcode of one item on the hold for record A, but show the same on the title hold for record B.
Created attachment 125572 [details] [review] Bug 29148: Check if hold is item or bib level To test: 1 - place an item level hold, it says: [one of the barcodes] or any available 2 - place a bib level hold, it says: [one of the barcodes] or any available 3 - Apply patch 4 - item level hold should say: Only [barcode] 5 - bib level hold should say: [one of the barcodes] or any available
Created attachment 125573 [details] [review] Bug 29148: Check if hold is item or bib level To test: 1 - place an item level hold, it says: [one of the barcodes] or any available 2 - place a bib level hold, it says: [one of the barcodes] or any available 3 - Apply patch 4 - item level hold should say: Only [barcode] 5 - bib level hold should say: [one of the barcodes] or any available Signed-off-by: Azucena <Azucena.Aguayo@uvu.edu>
Created attachment 125664 [details] [review] Bug 29148: Check if hold is item or bib level To test: 1 - place an item level hold, it says: [one of the barcodes] or any available 2 - place a bib level hold, it says: [one of the barcodes] or any available 3 - Apply patch 4 - item level hold should say: Only [barcode] 5 - bib level hold should say: [one of the barcodes] or any available Signed-off-by: Azucena <Azucena.Aguayo@uvu.edu> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.05
Depends on Bug 24488 not in 20.11.x