Bug 31229 - Column visibility broken on patron search view
Summary: Column visibility broken on patron search view
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 30063
Blocks:
  Show dependency treegraph
 
Reported: 2022-07-25 06:53 UTC by Jonathan Druart
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31229: (bug 30063 follow-up) fix column visibility (1.35 KB, patch)
2022-07-25 06:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 31229: (bug 30063 follow-up) fix column visibility (1.42 KB, patch)
2022-07-25 08:24 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 31229: (bug 30063 follow-up) fix column visibility (1.47 KB, patch)
2022-07-25 21:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-07-25 06:53:49 UTC

    
Comment 1 Jonathan Druart 2022-07-25 06:56:25 UTC
Created attachment 138071 [details] [review]
Bug 31229: (bug 30063 follow-up) fix column visibility

Fix bad conflict resolution with bug 29648.

Test plan:
Confirm that the "Columns" button is displayed on the patron result view
and that it works as expected.
Comment 2 ByWater Sandboxes 2022-07-25 08:24:18 UTC
Created attachment 138074 [details] [review]
Bug 31229: (bug 30063 follow-up) fix column visibility

Fix bad conflict resolution with bug 29648.

Test plan:
Confirm that the "Columns" button is displayed on the patron result view
and that it works as expected.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Sally 2022-07-25 08:24:47 UTC
Works as described, signing off.  Thanks for the patch!
Comment 4 Katrin Fischer 2022-07-25 21:40:20 UTC
Created attachment 138105 [details] [review]
Bug 31229: (bug 30063 follow-up) fix column visibility

Fix bad conflict resolution with bug 29648.

Test plan:
Confirm that the "Columns" button is displayed on the patron result view
and that it works as expected.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-07-26 12:34:43 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!