Bug 31773 - Add 'page-section' to manage MARC import page
Summary: Add 'page-section' to manage MARC import page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords: Academy
Depends on: 30952
Blocks: 31757
  Show dependency treegraph
 
Reported: 2022-10-13 12:33 UTC by Martin Renvoize
Modified: 2023-12-28 20:43 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 31773: Add page-section class to Manage staged MARC records page (11.17 KB, patch)
2022-10-13 20:26 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 31773: Add page-section class to Manage staged MARC records page (11.22 KB, patch)
2022-10-13 21:18 UTC, David Nind
Details | Diff | Splinter Review
Bug 31773: Add page-section class to Manage staged MARC records page (11.28 KB, patch)
2022-10-15 08:24 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2022-10-13 12:33:40 UTC
We need the page-section div adding to the marc modification template page to ensure proper contrast for even/odd rows on the tables.
Comment 1 Lucas Gass 2022-10-13 20:26:52 UTC
Created attachment 141843 [details] [review]
Bug 31773: Add page-section class to Manage staged MARC records page

To test:
1. Apply patch
2. Have some MARC records and stage them for import. It will be nessesary to add more than 1
3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added.

Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer.
Comment 2 David Nind 2022-10-13 21:18:45 UTC
Created attachment 141846 [details] [review]
Bug 31773: Add page-section class to Manage staged MARC records page

To test:
1. Apply patch
2. Have some MARC records and stage them for import. It will be nessesary to add more than 1
3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added.

Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2022-10-15 08:12:13 UTC
I think this changed a different page - adjusting description to manage marc import and refiled MARC modification templates as bug 31811.
Comment 4 Katrin Fischer 2022-10-15 08:24:40 UTC
Created attachment 141918 [details] [review]
Bug 31773: Add page-section class to Manage staged MARC records page

To test:
1. Apply patch
2. Have some MARC records and stage them for import. It will be nessesary to add more than 1
3. Go to the Manage staged MARC records page and make sure the table looks right with the page-section added.

Note: I am also adding the Bootstrap table class to this table becuase I think it makes the table look much nicer.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-10-15 08:25:15 UTC
This does what it says, but also the table has a line on top of the header line, which is inconsistent with other pages... do we have a bug for those yet?
Comment 6 Martin Renvoize 2022-10-15 11:38:18 UTC
I spotted a table inconsistency like that somewhere else yesterday.. can't for the life of me remember where.  I didn't submit a big for it yet, got distracted, but we probably should report such bugs as and when we spot them..  I imagine it's yet another small inconsistency with our markup which should be fixed rather than further targeted class rules being added.
Comment 7 Katrin Fischer 2022-10-16 12:32:42 UTC
(In reply to Martin Renvoize from comment #6)
> I spotted a table inconsistency like that somewhere else yesterday.. can't
> for the life of me remember where.  I didn't submit a big for it yet, got
> distracted, but we probably should report such bugs as and when we spot
> them..  I imagine it's yet another small inconsistency with our markup which
> should be fixed rather than further targeted class rules being added.

I've created an omnibus with a first linked bug for this one:

Bug 31833 - [Omnibus] Fix table inconsistencies
Bug 31834 - Inconsistent table formatting for list of MARC imports
Comment 8 Tomás Cohen Arazi 2022-10-17 11:09:02 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!