Bug 32111 - Cannot schedule a pickup at the OPAC
Summary: Cannot schedule a pickup at the OPAC
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low critical (vote)
Assignee: Jonathan Druart
QA Contact: Katrin Fischer
URL:
Keywords: rel_22_11_candidate
Depends on: 30718 30650
Blocks: 31261
  Show dependency treegraph
 
Reported: 2022-11-04 12:29 UTC by Jonathan Druart
Modified: 2023-06-08 22:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00


Attachments
Bug 32111: Remove disabled from date input for curbside pickup (2.55 KB, patch)
2022-11-04 12:32 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32111: Remove disabled from date input for curbside pickup (2.60 KB, patch)
2022-11-04 12:41 UTC, David Nind
Details | Diff | Splinter Review
Bug 32111: Remove disabled from date input for curbside pickup (2.65 KB, patch)
2022-11-04 12:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 32111: Remove disabled from date input for curbside pickup (2.71 KB, patch)
2022-11-09 12:08 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2022-11-04 12:29:57 UTC
The date input is always disabled and it's not possible to select or enter a date.

git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true"
Comment 1 Jonathan Druart 2022-11-04 12:32:36 UTC
Created attachment 143181 [details] [review]
Bug 32111: Remove disabled from date input for curbside pickup

The date input is always disabled and it's not possible to select or enter a date.

git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true"

I don't really know what's happening here, but it's impossible to
interact with the date widget if the input is disabled when it's
initialized.

The solution I have here is to play with hide/show instead of disabled.

Other suggestions welcome.

Test plan:
Schedule a curbside pickup from the OPAC and confirm that the date input
is working as expected.
Comment 2 David Nind 2022-11-04 12:41:21 UTC
Created attachment 143184 [details] [review]
Bug 32111: Remove disabled from date input for curbside pickup

The date input is always disabled and it's not possible to select or enter a date.

git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true"

I don't really know what's happening here, but it's impossible to
interact with the date widget if the input is disabled when it's
initialized.

The solution I have here is to play with hide/show instead of disabled.

Other suggestions welcome.

Test plan:
Schedule a curbside pickup from the OPAC and confirm that the date input
is working as expected.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Owen Leonard 2022-11-04 12:43:26 UTC
Created attachment 143185 [details] [review]
Bug 32111: Remove disabled from date input for curbside pickup

The date input is always disabled and it's not possible to select or enter a date.

git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true"

I don't really know what's happening here, but it's impossible to
interact with the date widget if the input is disabled when it's
initialized.

The solution I have here is to play with hide/show instead of disabled.

Other suggestions welcome.

Test plan:
Schedule a curbside pickup from the OPAC and confirm that the date input
is working as expected.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Katrin Fischer 2022-11-09 12:08:34 UTC
Created attachment 143492 [details] [review]
Bug 32111: Remove disabled from date input for curbside pickup

The date input is always disabled and it's not possible to select or enter a date.

git bisect blames "Bug 30718: Apply flatpickr changes to OPAC" and "altInput: true"

I don't really know what's happening here, but it's impossible to
interact with the date widget if the input is disabled when it's
initialized.

The solution I have here is to play with hide/show instead of disabled.

Other suggestions welcome.

Test plan:
Schedule a curbside pickup from the OPAC and confirm that the date input
is working as expected.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2022-11-09 13:07:21 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!