Bug 33648 - Errors when enabling ERM in 22.11
Summary: Errors when enabling ERM in 22.11
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: 22.11
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on: 32991
Blocks:
  Show dependency treegraph
 
Reported: 2023-05-02 11:58 UTC by Nick Clemens
Modified: 2023-12-28 20:44 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.05-1


Attachments
Bug 33648: (bug 32991 follow-up) fix bad resolution conflict (1.19 KB, patch)
2023-05-03 06:48 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33684: Make mandatory date fields required when editing a patron (1.95 KB, patch)
2023-05-09 09:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2023-05-02 11:58:17 UTC
To recreate:
1 - Enable ERM
2 - View Agreements page:
Uncaught (in promise) ReferenceError: logged_in_user is not defined
3 - Click on Licenses
Uncaught (in promise) TypeError: node is null
Comment 1 Jonathan Druart 2023-05-02 12:20:33 UTC
Wrong resolution conflict on AgreementsList.vue in commit
  Bug 32991: Improve our Dialog component


in master
             logged_in_user,
+            setWarning,
+            setMessage,

in 22.11.x

+            logged_in_user,
+            setWarning,
+            setMessage,
Comment 2 Jonathan Druart 2023-05-03 06:48:05 UTC
Created attachment 150561 [details] [review]
Bug 33648: (bug 32991 follow-up) fix bad resolution conflict

Wrong resolution conflict on AgreementsList.vue in commit
  Bug 32991: Improve our Dialog component

in master
             logged_in_user,
+            setWarning,
+            setMessage,

in 22.11.x

+            logged_in_user,
+            setWarning,
+            setMessage,
Comment 3 Martin Renvoize 2023-05-03 11:34:27 UTC
Thanks for the quick fix Jonathan.
Comment 4 Martin Renvoize 2023-05-03 11:38:51 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 5 Martin Renvoize 2023-05-03 11:39:40 UTC
Adding now and will ask Mason to role a 22.11.05-1 package for us to include this.
Comment 6 Katrin Fischer 2023-05-09 09:44:02 UTC
Created attachment 150830 [details] [review]
Bug 33684: Make mandatory date fields required when editing a patron

Date fields in BorrowerMandatoryField are not required by the validation
form when a new patron is added or modified.

This is because the 'required' prop does not exist on the input element
when the flatpickr instance is created.
We should either add it in the DOM directly (tt), but it will require to
do it "manually" for each date fields, or add it when we add it to the
inputs. This patch implements the second option.

Test plan:
1. Add "dateofbirth" to syspref BorrowerMandatoryField.
2. Add patron and leave date of birth input field empty.
3. Save.
=> Form is not submitted and you are asked to fill in a date of birth

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 7 Katrin Fischer 2023-05-09 09:46:53 UTC
Comment on attachment 150830 [details] [review]
Bug 33684: Make mandatory date fields required when editing a patron

Bug number typo, sorry for the noise