Bug 7706 - AuthorisedValueImages not displaying all images on the OPAC
Summary: AuthorisedValueImages not displaying all images on the OPAC
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Fridolin Somers
QA Contact:
URL:
Keywords:
Depends on: 9740
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-13 10:45 UTC by Adrien SAURAT
Modified: 2016-12-05 21:22 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7706 - use AuthorisedValueImages in opac-detail.pl (2.39 KB, patch)
2013-07-17 14:08 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 7706 - Do not display authorized value image if url is empty (5.17 KB, patch)
2013-07-17 14:10 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 7706 - Show image in item lost status (1.53 KB, patch)
2013-07-17 14:11 UTC, Fridolin Somers
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien SAURAT 2012-03-13 10:45:03 UTC
The system preference "AuthorisedValueImages" is supposed to display/hide "images for authorized values (such as lost statuses and locations) in search results and item detail pages on the OPAC".
The ccode images should appear too.

As it is now :
* no images are displayed on the result page
* ccode and lost are displayed on the detail page
* location is never displayed

To be added :
* ccode, lost and location in the result page
* location in the detail page

Note :
There's also a translation problem (in french) for the AuthorisedValueImages system preference. When you choose to activate it, it is disabled instead (and enabled when you want to disable it...)
Comment 1 Nicole C. Engard 2012-07-10 21:02:20 UTC
I tested on master today and 

* ccode and lost are displayed on the detail page

Is not true anymore - ccode images are not showing on the detail page
Comment 2 Nicole C. Engard 2013-03-27 16:30:23 UTC
This is still an issue - ccode icons are not showing
Comment 3 Fridolin Somers 2013-07-17 13:26:05 UTC
AuthorisedValueImages syspref description is missing some details.

Fist of all, this syspref applies only if XSLT is off (Looks like 
DisplayOPACiconsXSLT syspref manages the case with XSLT).

Looking at code, it appears that this syspref only manages the fields of biblio using authorized values, not the fields of item. This is logical because images are shown with other biblio informations, not with items.
So ccode image is displayed only if defined at biblio level.

In OPAC details page, items table can show an image for lost status. But there is a little bug.
Adding an image for location would be an enhancement and I think it should use a new Template Toolkit plugin.

Note that itemtype image is managed by noItemTypeImages.
Comment 4 Fridolin Somers 2013-07-17 13:35:30 UTC
> Fist of all, this syspref applies only if XSLT is off (Looks like 
DisplayOPACiconsXSLT syspref manages the case with XSLT).
Correction : it does not depend on XSLT
Comment 5 Fridolin Somers 2013-07-17 13:46:06 UTC
I found a bug on detail pages : 
When XSLT is on, the images are not displayed ; it works when XSLT is off.
The cause of this bug is corrected by Bug 9740 : when XSLT is on, the authorized value codes are replaced by there description in all page, this affects the authorized value images.
Comment 6 Fridolin Somers 2013-07-17 14:08:03 UTC
Created attachment 19722 [details] [review]
Bug 7706 - use AuthorisedValueImages in opac-detail.pl

AuthorisedValueImages syspref was missing from opac-details.
See commit comment
Comment 7 Fridolin Somers 2013-07-17 14:10:35 UTC
Created attachment 19724 [details] [review]
Bug 7706 - Do not display authorized value image if url is empty

Small bug : if authorized value image url is empty (not undefined) the image was shows but without src the alt was shown.
Comment 8 Fridolin Somers 2013-07-17 14:11:34 UTC
Created attachment 19725 [details] [review]
Bug 7706 - Show image in item lost status

Small bug on lost image in detail page :
See commit message.
Comment 9 I'm just a bot 2013-09-29 05:41:21 UTC
This bug depends on 9740 which is in status Failed QA
Comment 10 Marcel de Rooy 2013-10-23 12:24:33 UTC
(In reply to I'm just a bot from comment #9)
> This bug depends on 9740 which is in status Failed QA

Setting status to BLOCKED
Comment 11 Nicole C. Engard 2014-11-12 19:18:18 UTC
9740 is no longer failed qa so updating status.
Comment 12 Nicole C. Engard 2015-01-15 16:09:27 UTC
Do we need a new patch for this? Or is this supposed to be Needs Signoff?
Comment 13 Katrin Fischer 2015-01-18 17:34:07 UTC
9740 is still "in discussion" - not sure about the patches here.
Comment 14 Nicole C. Engard 2015-03-19 18:25:42 UTC
Changing to needs sign off since we have patches.
Comment 15 Bernardo Gonzalez Kriegel 2015-05-13 13:56:26 UTC
Sorry, this patchset references files from OPAC prog :(

CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt deleted in HEAD and modified in Bug 7706 - Do not display authorized value image if url is empty. Version Bug 7706 - Do not display authorized value image if url is empty of koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt left in tree.
CONFLICT (modify/delete): koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt deleted in HEAD and modified in Bug 7706 - Do not display authorized value image if url is empty. Version Bug 7706 - Do not display authorized value image if url is empty of koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt left in tree.
Comment 16 Katrin Fischer 2016-05-06 06:06:00 UTC
AuthorisedValueImages has been removed from the code recently - which makes this bug invalid.