Memcached related modules are optional, not mandatory, so we should not be testing related code in the basic test suite. ------------------ $ prove t t/00-checkdatabase-version.t ........ ok t/00-deprecated.t ................... ok t/00-load.t ......................... 2/? Too late to run INIT block at /home/cnighswonger/Repositories/koha.3.2.labels//C4/Barcodes/hbyymmincr.pm line 41. Too late to run INIT block at /home/cnighswonger/Repositories/koha.3.2.labels//C4/External/BakerTaylor.pm line 42. t/00-load.t ......................... 133/? # Failed test 'use Koha::Cache::Memcached;' Bailout called. Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Cache::Memcached' # at t/00-load.t line 48. # Tried to use 'Koha::Cache::Memcached'. # Error: Can't locate Cache/Memcached/Fast.pm in @INC (@INC contains: /home/cnighswonger/Repositories/koha.3.2.labels/ /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /home/cnighswonger/Repositories/koha.3.2.labels//Koha/Cache/Memcached.pm line 23. # BEGIN failed--compilation aborted at /home/cnighswonger/Repositories/koha.3.2.labels//Koha/Cache/Memcached.pm line 23. # Compilation failed in require at (eval 1325) line 2. # BEGIN failed--compilation aborted at (eval 1325) line 2. # Tests were run but no plan was declared and done_testing() was not seen. FAILED--Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Cache::Memcached'
Created attachment 13325 [details] [review] Bug 9036 - 00-load.t checks Koha::Cache::Memcached when it should not this patch adds code to skip this module during this test
NOTE: The associated patch attached to bug 7119 *must* be applied *first* in order for this patch to apply cleanly. You've been warned....
Created attachment 13334 [details] [review] Bug 9036 - 00-load.t checks Koha::Cache::Memcached when it should not this patch adds code to skip this module during this test Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Upping severity.
QA comment: * tiny patch * passes koha-qa.pl * 17:37 ~/koha.dev/koha-community (new/bug_9036 $%)$ prove t/00-load.t t/00-load.t .. ok All tests successful. Files=1, Tests=141, 4 wallclock secs ( 0.09 usr 0.02 sys + 2.16 cusr 0.17 csys = 2.44 CPU) Result: PASS => passed QA
Created attachment 13398 [details] [review] Bug 9036 - 00-load.t checks Koha::Cache::Memcached when it should not this patch adds code to skip this module during this test Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch has been pushed to master.
Patch pushed to branch 3.10.x
Released in 3.10.0