Bug 9036 - 00-load.t checks Koha::Cache::Memcached when it should not
Summary: 00-load.t checks Koha::Cache::Memcached when it should not
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low critical (vote)
Assignee: Chris Nighswonger
QA Contact:
URL:
Keywords:
Depends on: 7119
Blocks: 9054
  Show dependency treegraph
 
Reported: 2012-11-08 20:02 UTC by Chris Nighswonger
Modified: 2019-06-27 09:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9036 - 00-load.t checks Koha::Cache::Memcached when it should not this patch adds code to skip this module during this test (886 bytes, patch)
2012-11-08 21:08 UTC, Chris Nighswonger
Details | Diff | Splinter Review
Bug 9036 - 00-load.t checks Koha::Cache::Memcached when it should not this patch adds code to skip this module during this test (899 bytes, patch)
2012-11-09 00:09 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 9036 - 00-load.t checks Koha::Cache::Memcached when it should not this patch adds code to skip this module during this test (954 bytes, patch)
2012-11-12 16:39 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Nighswonger 2012-11-08 20:02:57 UTC
Memcached related modules are optional, not mandatory, so we should not be testing related code in the basic test suite.

------------------

$ prove t
t/00-checkdatabase-version.t ........ ok   
t/00-deprecated.t ................... ok   
t/00-load.t ......................... 2/? Too late to run INIT block at /home/cnighswonger/Repositories/koha.3.2.labels//C4/Barcodes/hbyymmincr.pm line 41.
Too late to run INIT block at /home/cnighswonger/Repositories/koha.3.2.labels//C4/External/BakerTaylor.pm line 42.
t/00-load.t ......................... 133/? 
#   Failed test 'use Koha::Cache::Memcached;'
Bailout called.  Further testing stopped:  ***** PROBLEMS LOADING FILE 'Koha::Cache::Memcached'
#   at t/00-load.t line 48.
#     Tried to use 'Koha::Cache::Memcached'.
#     Error:  Can't locate Cache/Memcached/Fast.pm in @INC (@INC contains: /home/cnighswonger/Repositories/koha.3.2.labels/ /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /home/cnighswonger/Repositories/koha.3.2.labels//Koha/Cache/Memcached.pm line 23.
# BEGIN failed--compilation aborted at /home/cnighswonger/Repositories/koha.3.2.labels//Koha/Cache/Memcached.pm line 23.
# Compilation failed in require at (eval 1325) line 2.
# BEGIN failed--compilation aborted at (eval 1325) line 2.
# Tests were run but no plan was declared and done_testing() was not seen.
FAILED--Further testing stopped: ***** PROBLEMS LOADING FILE 'Koha::Cache::Memcached'
Comment 1 Chris Nighswonger 2012-11-08 21:08:53 UTC Comment hidden (obsolete)
Comment 2 Chris Nighswonger 2012-11-08 21:10:59 UTC
NOTE: The associated patch attached to bug 7119 *must* be applied *first* in order for this patch to apply cleanly. You've been warned....
Comment 3 Chris Cormack 2012-11-09 00:09:57 UTC Comment hidden (obsolete)
Comment 4 Jared Camins-Esakov 2012-11-12 14:46:55 UTC
Upping severity.
Comment 5 Paul Poulain 2012-11-12 16:38:46 UTC
QA comment:
 * tiny patch
 * passes koha-qa.pl
 * 17:37 ~/koha.dev/koha-community (new/bug_9036 $%)$ prove t/00-load.t 
t/00-load.t .. ok     
All tests successful.
Files=1, Tests=141,  4 wallclock secs ( 0.09 usr  0.02 sys +  2.16 cusr  0.17 csys =  2.44 CPU)
Result: PASS


=> passed QA
Comment 6 Paul Poulain 2012-11-12 16:39:01 UTC
Created attachment 13398 [details] [review]
Bug 9036 - 00-load.t checks Koha::Cache::Memcached when it should not this patch adds code to skip this module during this test

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Comment 7 Jared Camins-Esakov 2012-11-12 23:51:38 UTC
This patch has been pushed to master.
Comment 8 Paul Poulain 2012-11-16 17:29:09 UTC
Patch pushed to branch 3.10.x
Comment 9 Chris Cormack 2013-04-22 10:03:35 UTC
Released in 3.10.0