@@ -, +, @@ every cron run 1) set syspref AutoRenewalNotices to be according to patron preferences 2) Enable renewal digest messages on a patron's messaging preferences 3) Checkout a book for patron, during the checkout use the Checkout settings menu to check the box "Automatic renewal" 4) Run $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch 5) Notice you have now two renewal messages for the patron 6) Apply patch 7) repeat step 4) and notice you don't get anymore these unnecessary renewal messages --- misc/cronjobs/automatic_renewals.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/misc/cronjobs/automatic_renewals.pl +++ a/misc/cronjobs/automatic_renewals.pl @@ -179,15 +179,15 @@ while ( my $auto_renew = $auto_renews->next ) { } } - if ( $borrower_preferences && $borrower_preferences->{transports} && $borrower_preferences->{transports}->{email} && $borrower_preferences->{'wants_digest'} ) { + if ( $error ne 'auto_too_soon' && $borrower_preferences && $borrower_preferences->{transports} && $borrower_preferences->{transports}->{email} && $borrower_preferences->{'wants_digest'} ) { # cache this one to process after we've run through all of the items. if ($digest_per_branch) { $renew_digest->{ $auto_renew->branchcode }->{ $auto_renew->borrowernumber }->{success}++ if $error eq 'auto_renew'; - $renew_digest->{ $auto_renew->branchcode }->{ $auto_renew->borrowernumber }->{error}++ unless $error eq 'auto_renew' || $error eq 'auto_too_soon' ; + $renew_digest->{ $auto_renew->branchcode }->{ $auto_renew->borrowernumber }->{error}++ unless $error eq 'auto_renew'; push @{$renew_digest->{ $auto_renew->branchcode }->{ $auto_renew->borrowernumber }->{issues}}, $auto_renew->itemnumber; } else { $renew_digest->{ $auto_renew->borrowernumber }->{success} ++ if $error eq 'auto_renew'; - $renew_digest->{ $auto_renew->borrowernumber }->{error}++ unless $error eq 'auto_renew' || $error eq 'auto_too_soon' ; + $renew_digest->{ $auto_renew->borrowernumber }->{error}++ unless $error eq 'auto_renew'; push @{$renew_digest->{ $auto_renew->borrowernumber }->{issues}}, $auto_renew->itemnumber; } } --