@@ -, +, @@ needs return value --- C4/Circulation.pm | 3 ++- t/db_dependent/Circulation_transfers.t | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) --- a/C4/Circulation.pm +++ a/C4/Circulation.pm @@ -3267,9 +3267,10 @@ Deletes all the branch transfer limits for one branch sub DeleteBranchTransferLimits { my $branch = shift; + return unless $branch; my $dbh = C4::Context->dbh; my $sth = $dbh->prepare("DELETE FROM branch_transfer_limits WHERE fromBranch = ?"); - $sth->execute($branch); + return $sth->execute($branch); } sub ReturnLostItem{ --- a/t/db_dependent/Circulation_transfers.t +++ a/t/db_dependent/Circulation_transfers.t @@ -9,7 +9,7 @@ use C4::Circulation; use Koha::DateUtils; use DateTime::Duration; -use Test::More tests => 12; +use Test::More tests => 14; BEGIN { use_ok('C4::Circulation'); @@ -184,8 +184,8 @@ is( 1, "A Branch TransferLimit has been deleted" ); -#FIXME :The following test should pass but doesn't because currently the routine DeleteBranchTransferLimit returns nothin -#is(C4::Circulation::DeleteBranchTransferLimits(),undef,"Without parameters DeleteBranchTransferLimit returns undef"); +is(C4::Circulation::DeleteBranchTransferLimits(),undef,"Without parameters DeleteBranchTransferLimit returns undef"); +is(C4::Circulation::DeleteBranchTransferLimits('B'),'0E0',"With a wrong id DeleteBranchTransferLimit returns 0E0"); #Test DeleteTransfer is( C4::Circulation::DeleteTransfer($item_id1), --