@@ -, +, @@ --- C4/Items.pm | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) --- a/C4/Items.pm +++ a/C4/Items.pm @@ -149,38 +149,38 @@ names to values. If C<$serial> is true, include serial publication data. sub GetItem { my ($itemnumber,$barcode, $serial) = @_; my $dbh = C4::Context->dbh; - my $data; + my $data; if ($itemnumber) { my $sth = $dbh->prepare(" - SELECT * FROM items + SELECT * FROM items WHERE itemnumber = ?"); $sth->execute($itemnumber); $data = $sth->fetchrow_hashref; } else { my $sth = $dbh->prepare(" - SELECT * FROM items + SELECT * FROM items WHERE barcode = ?" ); - $sth->execute($barcode); + $sth->execute($barcode); $data = $sth->fetchrow_hashref; } return unless ( $data ); - if ( $serial) { - my $ssth = $dbh->prepare("SELECT serialseq,publisheddate from serialitems left join serial on serialitems.serialid=serial.serialid where serialitems.itemnumber=?"); - $ssth->execute($data->{'itemnumber'}) ; - ($data->{'serialseq'} , $data->{'publisheddate'}) = $ssth->fetchrow_array(); - } - #if we don't have an items.itype, use biblioitems.itemtype. - # FIXME this should respect the itypes systempreference - # if (C4::Context->preference('item-level_itypes')) { - if( ! $data->{'itype'} ) { - my $sth = $dbh->prepare("SELECT itemtype FROM biblioitems WHERE biblionumber = ?"); - $sth->execute($data->{'biblionumber'}); - ($data->{'itype'}) = $sth->fetchrow_array; - } + if ($serial) { + my $ssth = $dbh->prepare("SELECT serialseq,publisheddate from serialitems left join serial on serialitems.serialid=serial.serialid where serialitems.itemnumber=?"); + $ssth->execute( $data->{'itemnumber'} ); + ( $data->{'serialseq'}, $data->{'publisheddate'} ) = $ssth->fetchrow_array(); + } + + # Set the itype to biblioitems.itype unless we are using item level itypes + unless ( C4::Context->preference('item-level_itypes') ) { + my $sth = $dbh->prepare("SELECT itemtype FROM biblioitems WHERE biblionumber = ?"); + $sth->execute( $data->{'biblionumber'} ); + ( $data->{'itype'} ) = $sth->fetchrow_array; + } + return $data; } # sub GetItem --