@@ -, +, @@ --- Koha/Exceptions/Patron/Modification.pm | 10 +++++++--- Koha/Patron/Modification.pm | 4 +++- t/db_dependent/Koha_borrower_modifications.t | 5 +++-- 3 files changed, 13 insertions(+), 6 deletions(-) --- a/Koha/Exceptions/Patron/Modification.pm +++ a/Koha/Exceptions/Patron/Modification.pm @@ -3,10 +3,14 @@ package Koha::Exceptions::Patron::Modification; use Modern::Perl; use Exception::Class ( - 'Koha::Exceptions::Koha::Patron::Modification::DuplicateVerificationToken' => { - isa => 'Koha::Exceptions::Object', - description => "The verification token given already exists", + + 'Koha::Exceptions::Patron::Modification' => { + description => 'Something went wrong' }, + 'Koha::Exceptions::Patron::Modification::DuplicateVerificationToken' => { + isa => 'Koha::Exceptions::Patron::Modification', + description => "The verification token given already exists" + } ); 1; --- a/Koha/Patron/Modification.pm +++ a/Koha/Patron/Modification.pm @@ -45,7 +45,9 @@ sub store { if ( $self->verification_token ) { if ( Koha::Patron::Modifications->search( { verification_token => $self->verification_token } )->count() ) { - Koha::Exceptions::Koha::Patron::Modification::DuplicateVerificationToken->throw; + Koha::Exceptions::Patron::Modification::DuplicateVerificationToken->throw( + "Duplicate verification token " . $self->verification_token + ); } } --- a/t/db_dependent/Koha_borrower_modifications.t +++ a/t/db_dependent/Koha_borrower_modifications.t @@ -1,7 +1,7 @@ #!/usr/bin/perl use Modern::Perl; -use Test::More tests => 9; +use Test::More tests => 10; use Try::Tiny; use t::lib::TestBuilder; @@ -39,8 +39,9 @@ try { } )->store(); } catch { - ok( $_->isa('Koha::Exceptions::Koha::Patron::Modification::DuplicateVerificationToken'), + ok( $_->isa('Koha::Exceptions::Patron::Modification::DuplicateVerificationToken'), 'Attempting to add a duplicate verification token to the database should raise a Koha::Exceptions::Koha::Patron::Modification::DuplicateVerificationToken exception' ); + is( $_->message, "Duplicate verification token 1234567890", 'Exception carries the right message' ); }; ## Get the new pending modification --