@@ -, +, @@ --- svc/letters/get | 4 +++- tools/letter.pl | 11 +++++++---- 2 files changed, 10 insertions(+), 5 deletions(-) --- a/svc/letters/get +++ a/svc/letters/get @@ -47,7 +47,9 @@ Used to get letters with a given letter code. our ( $query, $response ) = C4::Service->init( tools => 'edit_notices' ); sub get_letters { - my $letters = GetLetters({ code => $query->param('code'), branchcode => $query->param('branchcode') }); + my $code = scalar $query->param('code'); + my $branchcode = scalar $query->param('branchcode'); + my $letters = GetLetters({ code => $code, branchcode => $branchcode }); $response->param( letters => $letters ); C4::Service->return_success( $response ); } --- a/tools/letter.pl +++ a/tools/letter.pl @@ -255,14 +255,17 @@ sub add_form { push @{$field_selection}, add_fields('issues'); } - if ( $module eq 'circulation' and $code =~ /^AR_/ ) { + if ( $module eq 'circulation' and $code and $code =~ /^AR_/ ) { push @{$field_selection}, add_fields('article_requests'); } } - my $preview_is_available = grep {/^$code$/} qw( - CHECKIN CHECKOUT HOLD_SLIP - ); + my $preview_is_available = 0; + + if ($code) { + $preview_is_available = grep {/^$code$/} qw( CHECKIN CHECKOUT HOLD_SLIP ); + } + $template->param( module => $module, SQLfieldnames => $field_selection, --