Attachment #100221 for bug #23531

View | Details | Raw Unified | Return to bug 23531
Collapse All | Expand All




    IP address where the end user request is being placed
  - pickup_location (Optional)
    a branch code indicating the location to which to deliver the item for pickup
  - start_date (Optional)
    date after which hold request is no longer needed if the document has not been made available
  - expiry_date (Optional)
    date after which item returned to shelf if item is not picked up

=cut

    return { code => 'libraryNotPickupLocation' } unless $destination->pickup_location;
    return { code => 'cannotBeTransferred' } unless $biblio->can_be_transferred({ to => $destination });

    my $resdate;
    if ( $cgi->param('start_date') ) {
        $resdate = $cgi->param('start_date');
    }

    my $expdate;
    if ( $cgi->param('expiry_date') ) {
        $expdate = $cgi->param('expiry_date');
    }

    # Add the reserve
    #    $branch,    $borrowernumber, $biblionumber,
    #    $constraint, $bibitems,  $priority, $resdate, $expdate, $notes,

    my $priority= C4::Reserves::CalculatePriority( $biblionumber );
    AddReserve(
        {
            branch           => $branch,
            borrowernumber   => $borrowernumber,
            biblionumber     => $biblionumber,
            priority         => $priority,
            reservation_date => $resdate,
            expiration_date  => $expdate,
            title            => $title,
        }
    );


    an itemnumber
  - pickup_location (Optional)
    a branch code indicating the location to which to deliver the item for pickup
  - start_date (Optional)
    date after which hold request is no longer needed if the item has not been made available
  - expiry_date (Optional)
    date after which item returned to shelf if item is not picked up

=cut

    my $canitembereserved = C4::Reserves::CanItemBeReserved( $borrowernumber, $itemnumber, $branch )->{status};
    return { code => $canitembereserved } unless $canitembereserved eq 'OK';

    my $resdate;
    if ( $cgi->param('start_date') ) {
        $resdate = $cgi->param('start_date');
    }

    my $expdate;
    if ( $cgi->param('expiry_date') ) {
        $expdate = $cgi->param('expiry_date');
    }

    # Add the reserve
    my $priority = C4::Reserves::CalculatePriority($biblionumber);
    AddReserve(
        {
            branch           => $branch,
            borrowernumber   => $borrowernumber,
            biblionumber     => $biblionumber,
            priority         => $priority,
            reservation_date => $resdate,
            expiration_date  => $expdate,
            title            => $title,
            itemnumber       => $itemnumber,
        }
    );





                                    <dd>IP address where the end user request is being placed</dd>
                                    <dt><strong>pickup_location</strong> (Optional)</dt>
                                    <dd>an identifier indicating the location to which to deliver the item for pickup</dd>
                                    <dt><strong>start_date</strong> (Optional)</dt>
                                    <dd>date after which hold request is no longer needed</dd>
                                    <dt><strong>expiry_date</strong> (Optional)</dt>
                                    <dd>date after which item returned to shelf if item is not picked up</dd>
                                </dl>
                                <h4>Example Call</h4>

                                    <dd>the ILS identifier for the specific item on which the request is placed</dd>
                                    <dt><strong>pickup_location</strong> (Optional)</dt>
                                    <dd>an identifier indicating the location to which to deliver the item for pickup</dd>
                                    <dt><strong>start_date</strong> (Optional)</dt>
                                    <dd>date after which hold request is no longer needed</dd>
                                    <dt><strong>expiry_date</strong> (Optional)</dt>
                                    <dd>date after which item returned to shelf if item is not picked up</dd>
                                </dl>
                                <h4>Example Call</h4>

Lines 108-115 my %optional = ( Link Here

(-)a/opac/ilsdi.pl (-3 / +2 lines)
108	'GetPatronStatus' => [],	108	'GetPatronStatus' => [],
109	'GetServices' => [],	109	'GetServices' => [],
110	'RenewLoan' => ['desired_due_date'],	110	'RenewLoan' => ['desired_due_date'],
111	'HoldTitle' => [ 'pickup_location', 'needed_before_date', 'pickup_expiry_date' ],	111	'HoldTitle' => [ 'pickup_location', 'start_date', 'expiry_date' ],
112	'HoldItem' => [ 'pickup_location', 'needed_before_date', 'pickup_expiry_date' ],	112	'HoldItem' => [ 'pickup_location', 'start_date', 'expiry_date' ],
113	'CancelHold' => [],	113	'CancelHold' => [],
114	);	114	);
115		115
116	-

Return to bug 23531

Lines 673-681 Parameters: Link Here

(-)a/C4/ILSDI/Services.pm (-17 / +41 lines)
673	IP address where the end user request is being placed	673	IP address where the end user request is being placed
674	- pickup_location (Optional)	674	- pickup_location (Optional)
675	a branch code indicating the location to which to deliver the item for pickup	675	a branch code indicating the location to which to deliver the item for pickup
676	- needed_before_date (Optional)	676	- start_date (Optional)
677	date after which hold request is no longer needed	677	date after which hold request is no longer needed if the document has not been made available
678	- pickup_expiry_date (Optional)	678	- expiry_date (Optional)
679	date after which item returned to shelf if item is not picked up	679	date after which item returned to shelf if item is not picked up
680		680
681	=cut	681	=cut
Lines 728-733 sub HoldTitle { Link Here
728	return { code => 'libraryNotPickupLocation' } unless $destination->pickup_location;	728	return { code => 'libraryNotPickupLocation' } unless $destination->pickup_location;
729	return { code => 'cannotBeTransferred' } unless $biblio->can_be_transferred({ to => $destination });	729	return { code => 'cannotBeTransferred' } unless $biblio->can_be_transferred({ to => $destination });
730		730
		731	my $resdate;
		732	if ( $cgi->param('start_date') ) {
		733	$resdate = $cgi->param('start_date');
		734	}
		735
		736	my $expdate;
		737	if ( $cgi->param('expiry_date') ) {
		738	$expdate = $cgi->param('expiry_date');
		739	}
		740
731	# Add the reserve	741	# Add the reserve
732	# $branch, $borrowernumber, $biblionumber,	742	# $branch, $borrowernumber, $biblionumber,
733	# $constraint, $bibitems, $priority, $resdate, $expdate, $notes,	743	# $constraint, $bibitems, $priority, $resdate, $expdate, $notes,
Lines 735-745 sub HoldTitle { Link Here
735	my $priority= C4::Reserves::CalculatePriority( $biblionumber );	745	my $priority= C4::Reserves::CalculatePriority( $biblionumber );
736	AddReserve(	746	AddReserve(
737	{	747	{
738	branch => $branch,	748	branch => $branch,
739	borrowernumber => $borrowernumber,	749	borrowernumber => $borrowernumber,
740	biblionumber => $biblionumber,	750	biblionumber => $biblionumber,
741	priority => $priority,	751	priority => $priority,
742	title => $title,	752	reservation_date => $resdate,
		753	expiration_date => $expdate,
		754	title => $title,
743	}	755	}
744	);	756	);
745		757
Lines 769-777 Parameters: Link Here
769	an itemnumber	781	an itemnumber
770	- pickup_location (Optional)	782	- pickup_location (Optional)
771	a branch code indicating the location to which to deliver the item for pickup	783	a branch code indicating the location to which to deliver the item for pickup
772	- needed_before_date (Optional)	784	- start_date (Optional)
773	date after which hold request is no longer needed	785	date after which hold request is no longer needed if the item has not been made available
774	- pickup_expiry_date (Optional)	786	- expiry_date (Optional)
775	date after which item returned to shelf if item is not picked up	787	date after which item returned to shelf if item is not picked up
776		788
777	=cut	789	=cut
Lines 815-830 sub HoldItem { Link Here
815	my $canitembereserved = C4::Reserves::CanItemBeReserved( $borrowernumber, $itemnumber, $branch )->{status};	827	my $canitembereserved = C4::Reserves::CanItemBeReserved( $borrowernumber, $itemnumber, $branch )->{status};
816	return { code => $canitembereserved } unless $canitembereserved eq 'OK';	828	return { code => $canitembereserved } unless $canitembereserved eq 'OK';
817		829
		830	my $resdate;
		831	if ( $cgi->param('start_date') ) {
		832	$resdate = $cgi->param('start_date');
		833	}
		834
		835	my $expdate;
		836	if ( $cgi->param('expiry_date') ) {
		837	$expdate = $cgi->param('expiry_date');
		838	}
		839
818	# Add the reserve	840	# Add the reserve
819	my $priority = C4::Reserves::CalculatePriority($biblionumber);	841	my $priority = C4::Reserves::CalculatePriority($biblionumber);
820	AddReserve(	842	AddReserve(
821	{	843	{
822	branch => $branch,	844	branch => $branch,
823	borrowernumber => $borrowernumber,	845	borrowernumber => $borrowernumber,
824	biblionumber => $biblionumber,	846	biblionumber => $biblionumber,
825	priority => $priority,	847	priority => $priority,
826	title => $title,	848	reservation_date => $resdate,
827	itemnumber => $itemnumber,	849	expiration_date => $expdate,
		850	title => $title,
		851	itemnumber => $itemnumber,
828	}	852	}
829	);	853	);
830		854

Lines 720-728 Link Here

(-)a/koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt (-4 / +4 lines)
720	<dd>IP address where the end user request is being placed</dd>	720	<dd>IP address where the end user request is being placed</dd>
721	<dt><strong>pickup_location</strong> (Optional)</dt>	721	<dt><strong>pickup_location</strong> (Optional)</dt>
722	<dd>an identifier indicating the location to which to deliver the item for pickup</dd>	722	<dd>an identifier indicating the location to which to deliver the item for pickup</dd>
723	<dt><strong>needed_before_date</strong> (Optional)</dt>	723	<dt><strong>start_date</strong> (Optional)</dt>
724	<dd>date after which hold request is no longer needed</dd>	724	<dd>date after which hold request is no longer needed</dd>
725	<dt><strong>pickup_expiry_date</strong> (Optional)</dt>	725	<dt><strong>expiry_date</strong> (Optional)</dt>
726	<dd>date after which item returned to shelf if item is not picked up</dd>	726	<dd>date after which item returned to shelf if item is not picked up</dd>
727	</dl>	727	</dl>
728	<h4>Example Call</h4>	728	<h4>Example Call</h4>
Lines 751-759 Link Here
751	<dd>the ILS identifier for the specific item on which the request is placed</dd>	751	<dd>the ILS identifier for the specific item on which the request is placed</dd>
752	<dt><strong>pickup_location</strong> (Optional)</dt>	752	<dt><strong>pickup_location</strong> (Optional)</dt>
753	<dd>an identifier indicating the location to which to deliver the item for pickup</dd>	753	<dd>an identifier indicating the location to which to deliver the item for pickup</dd>
754	<dt><strong>needed_before_date</strong> (Optional)</dt>	754	<dt><strong>start_date</strong> (Optional)</dt>
755	<dd>date after which hold request is no longer needed</dd>	755	<dd>date after which hold request is no longer needed</dd>
756	<dt><strong>pickup_expiry_date</strong> (Optional)</dt>	756	<dt><strong>expiry_date</strong> (Optional)</dt>
757	<dd>date after which item returned to shelf if item is not picked up</dd>	757	<dd>date after which item returned to shelf if item is not picked up</dd>
758	</dl>	758	</dl>
759	<h4>Example Call</h4>	759	<h4>Example Call</h4>