|
Lines 17-23
Link Here
|
| 17 |
|
17 |
|
| 18 |
use Modern::Perl; |
18 |
use Modern::Perl; |
| 19 |
|
19 |
|
| 20 |
use Test::More tests => 62; |
20 |
use Test::More tests => 63; |
| 21 |
use Test::MockModule; |
21 |
use Test::MockModule; |
| 22 |
use Test::Warn; |
22 |
use Test::Warn; |
| 23 |
|
23 |
|
|
Lines 1035-1040
subtest 'MoveReserve additional test' => sub {
Link Here
|
| 1035 |
|
1035 |
|
| 1036 |
}; |
1036 |
}; |
| 1037 |
|
1037 |
|
|
|
1038 |
subtest 'Waiting item is marked as lost' => sub { |
| 1039 |
|
| 1040 |
plan tests => 15; |
| 1041 |
|
| 1042 |
# Set up data |
| 1043 |
my $biblio = $builder->build_sample_biblio(); |
| 1044 |
my $item = $builder->build_sample_item({ biblionumber => $biblio->biblionumber }); |
| 1045 |
my $patron = $builder->build_object({ class => 'Koha::Patrons' }); |
| 1046 |
|
| 1047 |
## TEST 1: BIBLIO-LEVEL HOLD |
| 1048 |
|
| 1049 |
# place biblio-level hold |
| 1050 |
my $reserve_id = AddReserve({ |
| 1051 |
branchcode => $item->homebranch, |
| 1052 |
borrowernumber => $patron->borrowernumber, |
| 1053 |
biblionumber => $biblio->biblionumber, |
| 1054 |
}); |
| 1055 |
my $hold = Koha::Holds->find( $reserve_id ); |
| 1056 |
|
| 1057 |
is( $hold->item_level_hold, 0, 'Biblio-level hold placed' ); |
| 1058 |
|
| 1059 |
# set hold as waiting and assign item |
| 1060 |
$hold->set_waiting; |
| 1061 |
$hold->set({ itemnumber => $item->itemnumber, priority => 0 })->store; |
| 1062 |
|
| 1063 |
# mark item in biblio as lost |
| 1064 |
$item->itemlost( 1 )->store; |
| 1065 |
is( $item->itemlost, 1, 'Item assigned to waiting hold has been marked lost'); |
| 1066 |
|
| 1067 |
# do test |
| 1068 |
t::lib::Mocks::mock_preference( 'RevertLostBibLevelHolds', 0 ); |
| 1069 |
C4::Circulation::LostItem( $item->itemnumber, 'test', 0, 0 ); |
| 1070 |
is( $hold->found, 'W', 'Hold is still waiting even though the item is lost because RevertLostBibLevelHolds is disabled' ); |
| 1071 |
|
| 1072 |
# enable preference |
| 1073 |
t::lib::Mocks::mock_preference( 'RevertLostBibLevelHolds', 1 ); |
| 1074 |
|
| 1075 |
# try again |
| 1076 |
is( $item->itemlost, 1, 'Item assigned to waiting hold has been marked lost'); |
| 1077 |
C4::Circulation::LostItem( $item->itemnumber, 'test', 0, 0 ); |
| 1078 |
$hold = Koha::Holds->find( $reserve_id ); |
| 1079 |
is( $hold->found, undef, 'Hold waiting status has been reverted because RevertLostBibLevelHolds is enabled' ); |
| 1080 |
|
| 1081 |
# clean up |
| 1082 |
$hold->cancel; |
| 1083 |
$item->itemlost( 0 ); |
| 1084 |
|
| 1085 |
## TEST 2: ITEM-LEVEL HOLD, REVERT |
| 1086 |
|
| 1087 |
# place item-level hold |
| 1088 |
$reserve_id = AddReserve({ |
| 1089 |
branchcode => $item->homebranch, |
| 1090 |
borrowernumber => $patron->borrowernumber, |
| 1091 |
biblionumber => $biblio->biblionumber, |
| 1092 |
itemnumber => $item->itemnumber |
| 1093 |
}); |
| 1094 |
$hold = Koha::Holds->find( $reserve_id ); |
| 1095 |
|
| 1096 |
is( $hold->item_level_hold, 1, 'Item-level hold placed' ); |
| 1097 |
|
| 1098 |
# set hold as waiting and assign item |
| 1099 |
$hold->set_waiting; |
| 1100 |
$hold->set({ itemnumber => $item->itemnumber, priority => 0 })->store; |
| 1101 |
|
| 1102 |
# mark item in biblio as lost |
| 1103 |
$item->itemlost( 1 ); |
| 1104 |
is( $item->itemlost, 1, 'Item assigned to waiting hold has been marked lost'); |
| 1105 |
|
| 1106 |
# do test |
| 1107 |
t::lib::Mocks::mock_preference( 'RevertLostBibLevelHolds', 0 ); |
| 1108 |
C4::Circulation::LostItem( $item->itemnumber, 'test', 0, 0 ); |
| 1109 |
is( $hold->found, 'W', 'Hold is still waiting even though the item is lost because RevertLostBibLevelHolds is disabled' ); |
| 1110 |
|
| 1111 |
# enable preference |
| 1112 |
t::lib::Mocks::mock_preference( 'RevertLostBibLevelHolds', 1 ); |
| 1113 |
|
| 1114 |
# try again |
| 1115 |
is( $item->itemlost, 1, 'Item assigned to waiting hold has been marked lost'); |
| 1116 |
C4::Circulation::LostItem( $item->itemnumber, 'test', 0, 0 ); |
| 1117 |
$hold = Koha::Holds->find( $reserve_id ); |
| 1118 |
is( $hold->found, undef, 'Hold waiting status has been reverted because RevertLostBibLevelHolds is enabled, and we chose not to cancel' ); |
| 1119 |
|
| 1120 |
# clean up |
| 1121 |
$hold->cancel; |
| 1122 |
$item->itemlost( 0 ); |
| 1123 |
|
| 1124 |
# TEST 3: ITEM-LEVEL HOLD, CANCEL |
| 1125 |
|
| 1126 |
# place item-level hold |
| 1127 |
$reserve_id = AddReserve({ |
| 1128 |
branchcode => $item->homebranch, |
| 1129 |
borrowernumber => $patron->borrowernumber, |
| 1130 |
biblionumber => $biblio->biblionumber, |
| 1131 |
itemnumber => $item->itemnumber |
| 1132 |
}); |
| 1133 |
$hold = Koha::Holds->find( $reserve_id ); |
| 1134 |
|
| 1135 |
is( $hold->item_level_hold, 1, 'Item-level hold placed' ); |
| 1136 |
|
| 1137 |
# set hold as waiting and assign item |
| 1138 |
$hold->set_waiting; |
| 1139 |
$hold->set({ itemnumber => $item->itemnumber, priority => 0 })->store; |
| 1140 |
|
| 1141 |
# mark item in biblio as lost |
| 1142 |
$item->itemlost( 1 ); |
| 1143 |
is( $item->itemlost, 1, 'Item assigned to waiting hold has been marked lost'); |
| 1144 |
|
| 1145 |
# do test |
| 1146 |
t::lib::Mocks::mock_preference( 'RevertLostBibLevelHolds', 0 ); |
| 1147 |
C4::Circulation::LostItem( $item->itemnumber, 'test', 0, 1 ); |
| 1148 |
is( $hold->found, 'W', 'Hold is still waiting even though the item is lost because RevertLostBibLevelHolds is disabled' ); |
| 1149 |
|
| 1150 |
# enable preference |
| 1151 |
t::lib::Mocks::mock_preference( 'RevertLostBibLevelHolds', 1 ); |
| 1152 |
|
| 1153 |
# try again |
| 1154 |
is( $item->itemlost, 1, 'Item assigned to waiting hold has been marked lost'); |
| 1155 |
C4::Circulation::LostItem( $item->itemnumber, 'test', 0, 1 ); |
| 1156 |
$hold = Koha::Holds->find( $reserve_id ); |
| 1157 |
is( Koha::Holds->find( $reserve_id ), undef, 'Hold has been cancelled with RevertLostBibLevelHolds enabled' ); |
| 1158 |
}; |
| 1159 |
|
| 1038 |
sub count_hold_print_messages { |
1160 |
sub count_hold_print_messages { |
| 1039 |
my $message_count = $dbh->selectall_arrayref(q{ |
1161 |
my $message_count = $dbh->selectall_arrayref(q{ |
| 1040 |
SELECT COUNT(*) |
1162 |
SELECT COUNT(*) |
| 1041 |
- |
|
|