Attachment #107879 for bug #25758

View | Details | Raw Unified | Return to bug 25758
Collapse All | Expand All




                and C4::Context->preference('SwitchOnSiteCheckouts') ) {
            $messages{ONSITE_CHECKOUT_WILL_BE_SWITCHED} = 1;
        } else {
            my ($CanBookBeRenewed, $renewerror) = CanBookBeRenewed(
                $patron->borrowernumber,
                $item_object->itemnumber,
            );

            if ( $CanBookBeRenewed == 0 ) {    # no more renewals allowed
                if ( $renewerror->[0] eq 'onsite_checkout' ) {
                    $issuingimpossible{NO_RENEWAL_FOR_ONSITE_CHECKOUTS} = 1;
                }
                else {


    my $item      = Koha::Items->find($itemnumber)      or return ( 0, 'no_item' );
    my $issue = $item->checkout or return ( 0, 'no_checkout' );
    my @errors;
    push @errors, 'onsite_checkout' if $issue->onsite_checkout;
    push @errors, 'item_denied_renewal' if _item_denied_renewal({ item => $item });

    my $patron = $issue->patron or return;


            }
        );

        push @errors, 'too_many'
          if not $issuing_rule->{renewalsallowed} or $issuing_rule->{renewalsallowed} <= $issue->renewals;

        my $overduesblockrenewing = C4::Context->preference('OverduesBlockRenewing');

        my $hasoverdues = $patron->has_overdues;

        if ( $restricted and $restrictionblockrenewing ) {
            push @errors, 'restriction';
        } elsif ( ($hasoverdues and $overduesblockrenewing eq 'block') || ($issue->is_overdue and $overduesblockrenewing eq 'blockitem') ) {
            push @errors, 'overdue';
        }

        if ( $issue->auto_renew && $patron->autorenew_checkouts ) {

            if ( $patron->category->effective_BlockExpiredPatronOpacActions and $patron->is_expired ) {
                push @errors, 'auto_account_expired';
            }

            if ( defined $issuing_rule->{no_auto_renewal_after}

                );
                my $now = dt_from_string;
                if ( $now >= $maximum_renewal_date ) {
                    push @errors, 'auto_too_late';
                }
            }
            if ( defined $issuing_rule->{no_auto_renewal_after_hard_limit}
                          and $issuing_rule->{no_auto_renewal_after_hard_limit} ne "" ) {
                # If no_auto_renewal_after_hard_limit is >= today, it's also too late for renewal
                if ( dt_from_string >= dt_from_string( $issuing_rule->{no_auto_renewal_after_hard_limit} ) ) {
                    push @errors, 'auto_too_late';
                }
            }


                  ? $patron->account->balance
                  : $patron->account->outstanding_debits->total_outstanding;
                if ( $amountoutstanding and $amountoutstanding > $fine_no_renewals ) {
                    push @errors, 'auto_too_much_oweing';
                }
            }
        }


            if ( $soonestrenewal > dt_from_string() )
            {
                push @errors, 'auto_too_soon' if $issue->auto_renew && $patron->autorenew_checkouts;
                push @errors, 'too_soon';
            }
            elsif ( $issue->auto_renew && $patron->autorenew_checkouts ) {
                $auto_renew = 1;

            if ( $now >= dt_from_string( $issue->date_due, 'sql' ) ){
                $auto_renew = 1;
            } else {
                push @errors, 'auto_too_soon';
            }
        }
    }

            }
        }
    }
    push @errors, 'on_reserve' if $resfound;    # '' when no hold was found
    push @errors, 'auto_renew' if $auto_renew && !$override_limit; # 0 if auto-renewal should not succeed

    return ( 0, \@errors ) if @errors;

    return ( 1, undef );
}

Lines 49-54 sub do_renew_for { Link Here

(-)a/C4/SIP/ILS/Transaction/Renew.pm (+1 lines)
49	$self->{due} = $self->duedatefromissue($issue, $self->{item}->{itemnumber});	49	$self->{due} = $self->duedatefromissue($issue, $self->{item}->{itemnumber});
50	$self->renewal_ok(1);	50	$self->renewal_ok(1);
51	} else {	51	} else {
		52	$renewerror = $renewerror->[0];
52	$renewerror=~s/on_reserve/Item unavailable due to outstanding holds/;	53	$renewerror=~s/on_reserve/Item unavailable due to outstanding holds/;
53	$renewerror=~s/too_many/Item has reached maximum renewals/;	54	$renewerror=~s/too_many/Item has reached maximum renewals/;
54	$renewerror=~s/item_denied_renewal/Item renewal is not allowed/;	55	$renewerror=~s/item_denied_renewal/Item renewal is not allowed/;

Lines 852-857 sub renew_item { Link Here

(-)a/Koha/Account/Line.pm (+1 lines)
852	$borrowernumber,	852	$borrowernumber,
853	$itemnumber	853	$itemnumber
854	);	854	);
		855	$error = $error->[0] if @$error;
855	if ( $can_renew ) {	856	if ( $can_renew ) {
856	my $due_date = C4::Circulation::AddRenewal(	857	my $due_date = C4::Circulation::AddRenewal(
857	$borrowernumber,	858	$borrowernumber,

Lines 165-171 sub renew { Link Here

(-)a/Koha/REST/V1/Checkouts.pm (-1 / +3 lines)
165	if (!$can_renew) {	165	if (!$can_renew) {
166	return $c->render(	166	return $c->render(
167	status => 403,	167	status => 403,
168	openapi => { error => "Renewal not authorized ($error)" }	168	openapi => { error => sprintf("Renewal not authorized (%s)", $error->[0]) }
169	);	169	);
170	}	170	}
171		171
Lines 206-211 sub allows_renewal { Link Here
206	my ($can_renew, $error) = C4::Circulation::CanBookBeRenewed(	206	my ($can_renew, $error) = C4::Circulation::CanBookBeRenewed(
207	$checkout->borrowernumber, $checkout->itemnumber);	207	$checkout->borrowernumber, $checkout->itemnumber);
208		208
		209	$error = $error->[0] if @$error;
		210
209	my $renewable = Mojo::JSON->false;	211	my $renewable = Mojo::JSON->false;
210	$renewable = Mojo::JSON->true if $can_renew;	212	$renewable = Mojo::JSON->true if $can_renew;
211		213

Lines 71-76 if ($barcode) { Link Here

(-)a/circ/renew.pl (+1 lines)
71	CanBookBeRenewed( $borrower->borrowernumber(),	71	CanBookBeRenewed( $borrower->borrowernumber(),
72	$item->itemnumber(), $override_limit );	72	$item->itemnumber(), $override_limit );
73		73
		74	$error = $error->[0] if @$error;
74	if ( $error && ($error eq 'on_reserve') ) {	75	if ( $error && ($error eq 'on_reserve') ) {
75	if ($override_holds) {	76	if ($override_holds) {
76	$can_renew = 1;	77	$can_renew = 1;





                        if ( oObj.can_renew ) {
                            // Do nothing
                        } else if ( oObj.can_renew_error == "on_reserve" ) {
                            msg += "<span>"
                                    + "<a href='/cgi-bin/koha/reserve/request.pl?biblionumber=" + oObj.biblionumber + "'>" + ON_HOLD + "</a>"
                                    + "</span>";

                            span_style = "display: none";
                            span_class = "renewals-allowed-on_reserve";
                        } else if ( oObj.can_renew_error == "too_many" ) {
                            msg += "<span class='renewals-disabled'>"
                                    + NOT_RENEWABLE
                                    + "</span>";

                            span_style = "display: none";
                            span_class = "renewals-allowed";
                        } else if ( oObj.can_renew_error == "restriction" ) {
                            msg += "<span class='renewals-disabled'>"
                                    + NOT_RENEWABLE_RESTRICTION
                                    + "</span>";

                            span_style = "display: none";
                            span_class = "renewals-allowed";
                        } else if ( oObj.can_renew_error == "overdue" ) {
                            msg += "<span class='renewals-disabled'>"
                                    + NOT_RENEWABLE_OVERDUE
                                    + "</span>";

                            span_style = "display: none";
                            span_class = "renewals-allowed";
                        } else if ( oObj.can_renew_error == "too_soon" ) {
                            msg += "<span class='renewals-disabled'>"
                                    + NOT_RENEWABLE_TOO_SOON.format( oObj.can_renew_date )
                                    + "</span>";

                            span_style = "display: none";
                            span_class = "renewals-allowed";
                        } else if ( oObj.can_renew_error == "auto_too_soon" ) {
                            msg += "<span class='renewals-disabled'>"
                                    + NOT_RENEWABLE_AUTO_TOO_SOON
                                    + "</span>";

                            span_style = "display: none";
                            span_class = "renewals-allowed";
                        } else if ( oObj.can_renew_error == "auto_too_late" ) {
                            msg += "<span class='renewals-disabled'>"
                                    + NOT_RENEWABLE_AUTO_TOO_LATE
                                    + "</span>";

                            span_style = "display: none";
                            span_class = "renewals-allowed";
                        } else if ( oObj.can_renew_error == "auto_too_much_oweing" ) {
                            msg += "<span class='renewals-disabled'>"
                                    + NOT_RENEWABLE_AUTO_TOO_MUCH_OWEING
                                    + "</span>";

                            span_style = "display: none";
                            span_class = "renewals-allowed";
                        } else if ( oObj.can_renew_error == "auto_account_expired" ) {
                            msg += "<span class='renewals-disabled'>"
                                    + NOT_RENEWABLE_AUTO_ACCOUNT_EXPIRED
                                    + "</span>";

                            span_style = "display: none";
                            span_class = "renewals-allowed";
                        } else if ( oObj.can_renew_error == "auto_renew" ) {
                            msg += "<span class='renewals-disabled'>"
                                    + NOT_RENEWABLE_AUTO_RENEW
                                    + "</span>";

                            span_style = "display: none";
                            span_class = "renewals-allowed";
                        } else if ( oObj.can_renew_error == "onsite_checkout" ) {
                            // Don't display something if it's an onsite checkout
                        } else if ( oObj.can_renew_error == "item_denied_renewal" ) {
                            content += "<span class='renewals-disabled'>"
                                    + NOT_RENEWABLE_DENIED
                                    + "</span>";

                            span_style = "display: none";
                            span_class = "renewals-allowed";
                        } else {
                            $(oObj.can_renew_error).each(function(i, error){
                                if ( error == "on_reserve" ) {
                                    msg += "<span>"
                                            + "<a href='/cgi-bin/koha/reserve/request.pl?biblionumber=" + oObj.biblionumber + "'>" + ON_HOLD + "</a>"
                                            + "</span>";

                                    span_style = "display: none";
                                    span_class = "renewals-allowed-on_reserve";
                                }
                                if ( error == "too_many" ) {
                                    msg += "<span class='renewals-disabled'>"
                                            + NOT_RENEWABLE
                                            + "</span>";

                                    span_style = "display: none";
                                    span_class = "renewals-allowed";
                                }
                                if ( error == "restriction" ) {
                                    msg += "<span class='renewals-disabled'>"
                                            + NOT_RENEWABLE_RESTRICTION
                                            + "</span>";

                                    span_style = "display: none";
                                    span_class = "renewals-allowed";
                                }
                                if ( error == "overdue" ) {
                                    msg += "<span class='renewals-disabled'>"
                                            + NOT_RENEWABLE_OVERDUE
                                            + "</span>";

                                    span_style = "display: none";
                                    span_class = "renewals-allowed";
                                }
                                if ( error == "too_soon" ) {
                                    msg += "<span class='renewals-disabled'>"
                                            + NOT_RENEWABLE_TOO_SOON.format( oObj.can_renew_date )
                                            + "</span>";

                                    span_style = "display: none";
                                    span_class = "renewals-allowed";
                                }
                                if ( error == "auto_too_soon" ) {
                                    msg += "<span class='renewals-disabled'>"
                                            + NOT_RENEWABLE_AUTO_TOO_SOON
                                            + "</span>";

                                    span_style = "display: none";
                                    span_class = "renewals-allowed";
                                }
                                if ( error == "auto_too_late" ) {
                                    msg += "<span class='renewals-disabled'>"
                                            + NOT_RENEWABLE_AUTO_TOO_LATE
                                            + "</span>";

                                    span_style = "display: none";
                                    span_class = "renewals-allowed";
                                }
                                if ( error == "auto_too_much_oweing" ) {
                                    msg += "<span class='renewals-disabled'>"
                                            + NOT_RENEWABLE_AUTO_TOO_MUCH_OWEING
                                            + "</span>";

                                    span_style = "display: none";
                                    span_class = "renewals-allowed";
                                }
                                if ( error == "auto_account_expired" ) {
                                    msg += "<span class='renewals-disabled'>"
                                            + NOT_RENEWABLE_AUTO_ACCOUNT_EXPIRED
                                            + "</span>";

                                    span_style = "display: none";
                                    span_class = "renewals-allowed";
                                }
                                if ( error == "auto_renew" ) {
                                    msg += "<span class='renewals-disabled'>"
                                            + NOT_RENEWABLE_AUTO_RENEW
                                            + "</span>";

                                    span_style = "display: none";
                                    span_class = "renewals-allowed";
                                }
                                if ( error == "onsite_checkout" ) {
                                    // Don't display something if it's an onsite checkout
                                }
                                if ( error == "item_denied_renewal" ) {
                                    content += "<span class='renewals-disabled'>"
                                            + NOT_RENEWABLE_DENIED
                                            + "</span>";

                                    span_style = "display: none";
                                    span_class = "renewals-allowed";
                                }
                                msg += "<br/>";
                            });
                        }

                        var can_force_renew = ( oObj.onsite_checkout == 0 ) &&
                            ( !oObj.can_renew_error || !oObj.can_renew_error.includes("on_reserve") || (oObj.can_renew_error.includes("on_reserve") && AllowRenewalOnHoldOverride))
                            ? true : false;
                        var can_renew = ( oObj.renewals_remaining > 0 && ( !oObj.can_renew_error || !oObj.can_renew_error.length ) );
                        content += "<span>";
                        if ( can_renew || can_force_renew ) {
                            content += "<span style='padding: 0 1em;'>" + oObj.renewals_count + "</span>";

                            if ( oObj.date_due_overdue && can_renew ) {
                                content += "checked='checked' ";
                            }
                            if (oObj.can_renew_error && oObj.can_renew_error.includes("on_reserve")) {
                                content += "data-on-reserve ";
                            }
                            content += "class='renew' id='renew_" + oObj.itemnumber + "' name='renew' value='" + oObj.itemnumber +"'/>"

                    "bSortable": false,
                    "bVisible": AllowCirculate ? true : false,
                    "mDataProp": function ( oObj ) {
                        if ( oObj.can_renew_error && oObj.can_renew_error.includes("on_reserve") ) {
                            return "<a href='/cgi-bin/koha/reserve/request.pl?biblionumber=" + oObj.biblionumber + "'>" + ON_HOLD + "</a>";
                        } else {
                            return "<input type='checkbox' class='checkin' id='checkin_" + oObj.itemnumber + "' name='checkin' value='" + oObj.itemnumber +"'></input>";

Lines 89-94 while ( my $auto_renew = $auto_renews->next ) { Link Here

(-)a/misc/cronjobs/automatic_renewals.pl (+1 lines)
89		89
90	# CanBookBeRenewed returns 'auto_renew' when the renewal should be done by this script	90	# CanBookBeRenewed returns 'auto_renew' when the renewal should be done by this script
91	my ( $ok, $error ) = CanBookBeRenewed( $auto_renew->borrowernumber, $auto_renew->itemnumber );	91	my ( $ok, $error ) = CanBookBeRenewed( $auto_renew->borrowernumber, $auto_renew->itemnumber );
		92	$error = $error->[0] if @$error;
92	if ( $error eq 'auto_renew' ) {	93	if ( $error eq 'auto_renew' ) {
93	if ($verbose) {	94	if ($verbose) {
94	say sprintf "Issue id: %s for borrower: %s and item: %s ". ( $confirm ? 'will' : 'would') . " be renewed.",	95	say sprintf "Issue id: %s for borrower: %s and item: %s ". ( $confirm ? 'will' : 'would') . " be renewed.",

Lines 62-67 else { Link Here

(-)a/opac/opac-renew.pl (+1 lines)
62	for my $itemnumber (@items) {	62	for my $itemnumber (@items) {
63	my ( $status, $error ) =	63	my ( $status, $error ) =
64	CanBookBeRenewed( $borrowernumber, $itemnumber );	64	CanBookBeRenewed( $borrowernumber, $itemnumber );
		65	$error = $error->[0] if @$error;
65	if ( $status == 1 && $opacrenew == 1 ) {	66	if ( $status == 1 && $opacrenew == 1 ) {
66	AddRenewal( $borrowernumber, $itemnumber, undef, undef, undef );	67	AddRenewal( $borrowernumber, $itemnumber, undef, undef, undef );
67	push( @renewed, $itemnumber );	68	push( @renewed, $itemnumber );

Lines 232-238 if ( $pending_checkouts->count ) { # Useless test Link Here

(-)a/opac/opac-user.pl (-1 / +2 lines)
232		232
233	$issue->{'renewed'} = $renewed{ $issue->{'itemnumber'} };	233	$issue->{'renewed'} = $renewed{ $issue->{'itemnumber'} };
234		234
235	if ($renewerror) {	235	if (@$renewerror) {
		236	$renewerror = $renewerror->[0];
236	$issue->{'too_many'} = 1 if $renewerror eq 'too_many';	237	$issue->{'too_many'} = 1 if $renewerror eq 'too_many';
237	$issue->{'on_reserve'} = 1 if $renewerror eq 'on_reserve';	238	$issue->{'on_reserve'} = 1 if $renewerror eq 'on_reserve';
238	$issue->{'norenew_overdue'} = 1 if $renewerror eq 'overdue';	239	$issue->{'norenew_overdue'} = 1 if $renewerror eq 'overdue';

Lines 273-278 if ($borrower) { Link Here

(-)a/opac/sco/sco-main.pl (+1 lines)
273	$borrower->{borrowernumber},	273	$borrower->{borrowernumber},
274	$checkout->{itemnumber},	274	$checkout->{itemnumber},
275	);	275	);
		276	$renew_error = $renew_error->[0] if @$renew_error;
276	$checkout->{can_be_renewed} = $can_be_renewed; # In the future this will be $checkout->can_be_renewed	277	$checkout->{can_be_renewed} = $can_be_renewed; # In the future this will be $checkout->can_be_renewed
277	$checkout->{renew_error} = $renew_error;	278	$checkout->{renew_error} = $renew_error;
278	$checkout->{overdue} = $c->is_overdue;	279	$checkout->{overdue} = $c->is_overdue;





use CGI;
use JSON qw(to_json);
use List::MoreUtils qw( uniq );

use C4::Auth qw(check_cookie_auth haspermission get_session);
use C4::Circulation qw(GetIssuingCharges CanBookBeRenewed GetRenewCount GetSoonestRenewDate);


    my ( $can_renew, $can_renew_error ) =
      CanBookBeRenewed( $c->{borrowernumber}, $c->{itemnumber} );

    my $can_renew_date;
    $can_renew_error &&= [uniq @$can_renew_error];
    if ( $can_renew_error && grep { $_ eq 'too_soon' } @$can_renew_error ) {
        $can_renew_date = output_pref(
            {
                dt => GetSoonestRenewDate( $c->{borrowernumber}, $c->{itemnumber} ),
                as_due_date => 1
            }
        );
    }

    my ( $renewals_count, $renewals_allowed, $renewals_remaining ) =
      GetRenewCount( $c->{borrowernumber}, $c->{itemnumber} );





    ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
    is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
    is( $error->[0], 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');

    ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
    is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
    is( $error->[0], 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');

    my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next->reserve_id;
    my $reserving_borrower = Koha::Patrons->find( $reserving_borrowernumber )->unblessed;


    ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
    is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
    is( $error->[0], 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');

    ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber, 1);
    is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');

    ( $renewokay, $error ) =
      CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
    is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
    is( $error->[0], 'auto_too_soon',
        'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
    AddReserve(
        {

    );
    ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
    is( $renewokay, 0, 'Still should not be able to renew' );
    is( $error->[0], 'auto_too_soon', 'returned code is auto_too_soon, reserve not checked' );
    ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
    is( $renewokay, 0, 'Still should not be able to renew' );
    is( $error->[0], 'on_reserve', 'returned code is on_reserve, auto_too_soon limit is overridden' );
    $dbh->do('UPDATE circulation_rules SET rule_value = 0 where rule_name = "norenewalbefore"');
    ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber, 1 );
    is( $renewokay, 0, 'Still should not be able to renew' );
    is( $error->[0], 'on_reserve', 'returned code is on_reserve, auto_renew only happens if not on reserve' );
    ModReserveCancelAll($item_4->itemnumber, $reserving_borrowernumber);




    ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
    is( $renewokay, 0, 'Bug 7413: Cannot renew, renewal is premature');
    is( $error->[0], 'too_soon', 'Bug 7413: Cannot renew, renewal is premature (returned code is too_soon)');

    # Bug 14395
    # Test 'exact time' setting for syspref NoRenewalBeforePrecision

    ( $renewokay, $error ) =
      CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
    is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
    is( $error->[0], 'auto_too_soon',
        'Bug 14101: Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
    );

    $renewing_borrower_obj->autorenew_checkouts(0)->store;
    ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
    is( $renewokay, 0, 'No renewal before is 7, patron opted out of auto_renewal still cannot renew early' );
    is( $error->[0], 'too_soon', 'Error is too_soon, no auto' );
    $renewing_borrower_obj->autorenew_checkouts(1)->store;

    # Change policy so that loans can only be renewed exactly on due date (0 days prior to due date)

    ( $renewokay, $error ) =
      CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
    is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
    is( $error->[0], 'auto_too_soon',
        'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = 0 (returned code is auto_too_soon)'
    );

    $renewing_borrower_obj->autorenew_checkouts(0)->store;
    ( $renewokay, $error ) = CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
    is( $renewokay, 0, 'No renewal before is 0, patron opted out of auto_renewal still cannot renew early' );
    is( $error->[0], 'too_soon', 'Error is too_soon, no auto' );
    $renewing_borrower_obj->autorenew_checkouts(1)->store;

    # Change policy so that loans can be renewed 99 days prior to the due date

    ( $renewokay, $error ) =
      CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
    is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic' );
    is( $error->[0], 'auto_renew',
        'Bug 14101: Cannot renew, renewal is automatic (returned code is auto_renew)'
    );


        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );

        Koha::CirculationRules->set_rules(
            {

        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_too_late', 'Cannot auto renew, too late - no_auto_renewal_after is inclusive(returned code is auto_too_late)' );

        Koha::CirculationRules->set_rules(
            {

        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_too_soon', 'Cannot auto renew, too soon - no_auto_renewal_after is defined(returned code is auto_too_soon)' );

        Koha::CirculationRules->set_rules(
            {

        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0,            'Do not renew, renewal is automatic' );
        is( $error->[0],     'auto_renew', 'Cannot renew, renew is automatic' );

        Koha::CirculationRules->set_rules(
            {

        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );

        Koha::CirculationRules->set_rules(
            {

        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );

        Koha::CirculationRules->set_rules(
            {

        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_renew', 'Cannot renew, renew is automatic' );
    };

    subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew & OPACFineNoRenewalsIncludeCredit" => sub {

        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 5' );

        $account->add_debit(
            {

        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 10' );

        $account->add_debit(
            {

        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, patron has 15' );

        $account->add_credit(
            {

        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit'  );

        C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','0');
        ( $renewokay, $error ) =
          CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit'  );

        $dbh->do('DELETE FROM accountlines WHERE borrowernumber=?', undef, $renewing_borrowernumber);
        C4::Context->set_preference('OPACFineNoRenewalsIncludeCredit','1');

        ( $renewokay, $error ) =
          CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_renew', 'Can auto renew, patron is expired but BlockExpiredPatronOpacActions=0' );
        Koha::Checkouts->find( $checkout->issue_id )->delete;



        ( $renewokay, $error ) =
          CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_account_expired', 'Can not auto renew, lockExpiredPatronOpacActions=1 and patron is expired' );
        Koha::Checkouts->find( $checkout->issue_id )->delete;



        ( $renewokay, $error ) =
          CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
        is( $renewokay, 0, 'Do not renew, renewal is automatic' );
        is( $error->[0], 'auto_renew', 'Can auto renew, BlockExpiredPatronOpacActions=1 but patron is not expired' );
        Koha::Checkouts->find( $checkout->issue_id )->delete;
    };



    ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
    is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
    is( $error->[0], 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');

    # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
    t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');

    my $issue = AddIssue( $borrower, $item->barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
    my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $item->itemnumber );
    is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
    is( $error->[0], 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );
}

{

    ( $idr_mayrenew, $idr_error ) =
    CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
    is( $idr_mayrenew, 0, 'Renewal blocked when 1 rules (withdrawn)' );
    is( $idr_error->[0], 'item_denied_renewal', 'Renewal blocked when 1 rule (withdrawn)' );
    ( $idr_mayrenew, $idr_error ) =
    CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
    is( $idr_mayrenew, 1, 'Renewal allowed when 1 rules not matched (withdrawn)' );

    ( $idr_mayrenew, $idr_error ) =
    CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
    is( $idr_mayrenew, 0, 'Renewal blocked when 2 rules matched (withdrawn, itype)' );
    is( $idr_error->[0], 'item_denied_renewal', 'Renewal blocked when 2 rules matched (withdrawn,itype)' );
    ( $idr_mayrenew, $idr_error ) =
    CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
    is( $idr_mayrenew, 1, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );

    ( $idr_mayrenew, $idr_error ) =
    CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
    is( $idr_mayrenew, 0, 'Renewal blocked when 3 rules matched (withdrawn, itype, location)' );
    is( $idr_error->[0], 'item_denied_renewal', 'Renewal blocked when 3 rules matched (withdrawn,itype, location)' );
    ( $idr_mayrenew, $idr_error ) =
    CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
    is( $idr_mayrenew, 1, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
- 

Return to bug 25758

Lines 857-868 sub CanBookBeIssued { Link Here

(-)a/C4/Circulation.pm (-16 / +20 lines)
857	and C4::Context->preference('SwitchOnSiteCheckouts') ) {	857	and C4::Context->preference('SwitchOnSiteCheckouts') ) {
858	$messages{ONSITE_CHECKOUT_WILL_BE_SWITCHED} = 1;	858	$messages{ONSITE_CHECKOUT_WILL_BE_SWITCHED} = 1;
859	} else {	859	} else {
860	my ($CanBookBeRenewed,$renewerror) = CanBookBeRenewed(	860	my ($CanBookBeRenewed, $renewerror) = CanBookBeRenewed(
861	$patron->borrowernumber,	861	$patron->borrowernumber,
862	$item_object->itemnumber,	862	$item_object->itemnumber,
863	);	863	);
		864
864	if ( $CanBookBeRenewed == 0 ) { # no more renewals allowed	865	if ( $CanBookBeRenewed == 0 ) { # no more renewals allowed
865	if ( $renewerror eq 'onsite_checkout' ) {	866	if ( $renewerror->[0] eq 'onsite_checkout' ) {
866	$issuingimpossible{NO_RENEWAL_FOR_ONSITE_CHECKOUTS} = 1;	867	$issuingimpossible{NO_RENEWAL_FOR_ONSITE_CHECKOUTS} = 1;
867	}	868	}
868	else {	869	else {
Lines 2780-2787 sub CanBookBeRenewed { Link Here
2780		2781
2781	my $item = Koha::Items->find($itemnumber) or return ( 0, 'no_item' );	2782	my $item = Koha::Items->find($itemnumber) or return ( 0, 'no_item' );
2782	my $issue = $item->checkout or return ( 0, 'no_checkout' );	2783	my $issue = $item->checkout or return ( 0, 'no_checkout' );
2783	return ( 0, 'onsite_checkout' ) if $issue->onsite_checkout;	2784	my @errors;
2784	return ( 0, 'item_denied_renewal') if _item_denied_renewal({ item => $item });	2785	push @errors, 'onsite_checkout' if $issue->onsite_checkout;
		2786	push @errors, 'item_denied_renewal' if _item_denied_renewal({ item => $item });
2785		2787
2786	my $patron = $issue->patron or return;	2788	my $patron = $issue->patron or return;
2787		2789
Lines 2803-2809 sub CanBookBeRenewed { Link Here
2803	}	2805	}
2804	);	2806	);
2805		2807
2806	return ( 0, "too_many" )	2808	push @errors, 'too_many'
2807	if not $issuing_rule->{renewalsallowed} or $issuing_rule->{renewalsallowed} <= $issue->renewals;	2809	if not $issuing_rule->{renewalsallowed} or $issuing_rule->{renewalsallowed} <= $issue->renewals;
2808		2810
2809	my $overduesblockrenewing = C4::Context->preference('OverduesBlockRenewing');	2811	my $overduesblockrenewing = C4::Context->preference('OverduesBlockRenewing');
Lines 2813-2827 sub CanBookBeRenewed { Link Here
2813	my $hasoverdues = $patron->has_overdues;	2815	my $hasoverdues = $patron->has_overdues;
2814		2816
2815	if ( $restricted and $restrictionblockrenewing ) {	2817	if ( $restricted and $restrictionblockrenewing ) {
2816	return ( 0, 'restriction');	2818	push @errors, 'restriction';
2817	} elsif ( ($hasoverdues and $overduesblockrenewing eq 'block') \|\| ($issue->is_overdue and $overduesblockrenewing eq 'blockitem') ) {	2819	} elsif ( ($hasoverdues and $overduesblockrenewing eq 'block') \|\| ($issue->is_overdue and $overduesblockrenewing eq 'blockitem') ) {
2818	return ( 0, 'overdue');	2820	push @errors, 'overdue';
2819	}	2821	}
2820		2822
2821	if ( $issue->auto_renew && $patron->autorenew_checkouts ) {	2823	if ( $issue->auto_renew && $patron->autorenew_checkouts ) {
2822		2824
2823	if ( $patron->category->effective_BlockExpiredPatronOpacActions and $patron->is_expired ) {	2825	if ( $patron->category->effective_BlockExpiredPatronOpacActions and $patron->is_expired ) {
2824	return ( 0, 'auto_account_expired' );	2826	push @errors, 'auto_account_expired';
2825	}	2827	}
2826		2828
2827	if ( defined $issuing_rule->{no_auto_renewal_after}	2829	if ( defined $issuing_rule->{no_auto_renewal_after}
Lines 2834-2847 sub CanBookBeRenewed { Link Here
2834	);	2836	);
2835	my $now = dt_from_string;	2837	my $now = dt_from_string;
2836	if ( $now >= $maximum_renewal_date ) {	2838	if ( $now >= $maximum_renewal_date ) {
2837	return ( 0, "auto_too_late" );	2839	push @errors, 'auto_too_late';
2838	}	2840	}
2839	}	2841	}
2840	if ( defined $issuing_rule->{no_auto_renewal_after_hard_limit}	2842	if ( defined $issuing_rule->{no_auto_renewal_after_hard_limit}
2841	and $issuing_rule->{no_auto_renewal_after_hard_limit} ne "" ) {	2843	and $issuing_rule->{no_auto_renewal_after_hard_limit} ne "" ) {
2842	# If no_auto_renewal_after_hard_limit is >= today, it's also too late for renewal	2844	# If no_auto_renewal_after_hard_limit is >= today, it's also too late for renewal
2843	if ( dt_from_string >= dt_from_string( $issuing_rule->{no_auto_renewal_after_hard_limit} ) ) {	2845	if ( dt_from_string >= dt_from_string( $issuing_rule->{no_auto_renewal_after_hard_limit} ) ) {
2844	return ( 0, "auto_too_late" );	2846	push @errors, 'auto_too_late';
2845	}	2847	}
2846	}	2848	}
2847		2849
Lines 2852-2858 sub CanBookBeRenewed { Link Here
2852	? $patron->account->balance	2854	? $patron->account->balance
2853	: $patron->account->outstanding_debits->total_outstanding;	2855	: $patron->account->outstanding_debits->total_outstanding;
2854	if ( $amountoutstanding and $amountoutstanding > $fine_no_renewals ) {	2856	if ( $amountoutstanding and $amountoutstanding > $fine_no_renewals ) {
2855	return ( 0, "auto_too_much_oweing" );	2857	push @errors, 'auto_too_much_oweing';
2856	}	2858	}
2857	}	2859	}
2858	}	2860	}
Lines 2874-2881 sub CanBookBeRenewed { Link Here
2874		2876
2875	if ( $soonestrenewal > dt_from_string() )	2877	if ( $soonestrenewal > dt_from_string() )
2876	{	2878	{
2877	return ( 0, "auto_too_soon" ) if $issue->auto_renew && $patron->autorenew_checkouts;	2879	push @errors, 'auto_too_soon' if $issue->auto_renew && $patron->autorenew_checkouts;
2878	return ( 0, "too_soon" );	2880	push @errors, 'too_soon';
2879	}	2881	}
2880	elsif ( $issue->auto_renew && $patron->autorenew_checkouts ) {	2882	elsif ( $issue->auto_renew && $patron->autorenew_checkouts ) {
2881	$auto_renew = 1;	2883	$auto_renew = 1;
Lines 2889-2895 sub CanBookBeRenewed { Link Here
2889	if ( $now >= dt_from_string( $issue->date_due, 'sql' ) ){	2891	if ( $now >= dt_from_string( $issue->date_due, 'sql' ) ){
2890	$auto_renew = 1;	2892	$auto_renew = 1;
2891	} else {	2893	} else {
2892	return ( 0, "auto_too_soon" );	2894	push @errors, 'auto_too_soon';
2893	}	2895	}
2894	}	2896	}
2895	}	2897	}
Lines 2959-2966 sub CanBookBeRenewed { Link Here
2959	}	2961	}
2960	}	2962	}
2961	}	2963	}
2962	return ( 0, "on_reserve" ) if $resfound; # '' when no hold was found	2964	push @errors, 'on_reserve' if $resfound; # '' when no hold was found
2963	return ( 0, "auto_renew" ) if $auto_renew && !$override_limit; # 0 if auto-renewal should not succeed	2965	push @errors, 'auto_renew' if $auto_renew && !$override_limit; # 0 if auto-renewal should not succeed
		2966
		2967	return ( 0, \@errors ) if @errors;
2964		2968
2965	return ( 1, undef );	2969	return ( 1, undef );
2966	}	2970	}

Lines 21-26 use Modern::Perl; Link Here

(-)a/svc/checkouts (-9 / +12 lines)
21		21
22	use CGI;	22	use CGI;
23	use JSON qw(to_json);	23	use JSON qw(to_json);
		24	use List::MoreUtils qw( uniq );
24		25
25	use C4::Auth qw(check_cookie_auth haspermission get_session);	26	use C4::Auth qw(check_cookie_auth haspermission get_session);
26	use C4::Circulation qw(GetIssuingCharges CanBookBeRenewed GetRenewCount GetSoonestRenewDate);	27	use C4::Circulation qw(GetIssuingCharges CanBookBeRenewed GetRenewCount GetSoonestRenewDate);
Lines 148-162 while ( my $c = $sth->fetchrow_hashref() ) { Link Here
148		149
149	my ( $can_renew, $can_renew_error ) =	150	my ( $can_renew, $can_renew_error ) =
150	CanBookBeRenewed( $c->{borrowernumber}, $c->{itemnumber} );	151	CanBookBeRenewed( $c->{borrowernumber}, $c->{itemnumber} );
151	my $can_renew_date =	152
152	$can_renew_error && $can_renew_error eq 'too_soon'	153	my $can_renew_date;
153	? output_pref(	154	$can_renew_error &&= [uniq @$can_renew_error];
154	{	155	if ( $can_renew_error && grep { $_ eq 'too_soon' } @$can_renew_error ) {
155	dt => GetSoonestRenewDate( $c->{borrowernumber}, $c->{itemnumber} ),	156	$can_renew_date = output_pref(
156	as_due_date => 1	157	{
157	}	158	dt => GetSoonestRenewDate( $c->{borrowernumber}, $c->{itemnumber} ),
158	)	159	as_due_date => 1
159	: undef;	160	}
		161	);
		162	}
160		163
161	my ( $renewals_count, $renewals_allowed, $renewals_remaining ) =	164	my ( $renewals_count, $renewals_allowed, $renewals_remaining ) =
162	GetRenewCount( $c->{borrowernumber}, $c->{itemnumber} );	165	GetRenewCount( $c->{borrowernumber}, $c->{itemnumber} );

Lines 419-516 $(document).ready(function() { Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js (-88 / +97 lines)
419		419
420	if ( oObj.can_renew ) {	420	if ( oObj.can_renew ) {
421	// Do nothing	421	// Do nothing
422	} else if ( oObj.can_renew_error == "on_reserve" ) {
423	msg += "<span>"
424	+ "<a href='/cgi-bin/koha/reserve/request.pl?biblionumber=" + oObj.biblionumber + "'>" + ON_HOLD + "</a>"
425	+ "</span>";
426
427	span_style = "display: none";
428	span_class = "renewals-allowed-on_reserve";
429	} else if ( oObj.can_renew_error == "too_many" ) {
430	msg += "<span class='renewals-disabled'>"
431	+ NOT_RENEWABLE
432	+ "</span>";
433
434	span_style = "display: none";
435	span_class = "renewals-allowed";
436	} else if ( oObj.can_renew_error == "restriction" ) {
437	msg += "<span class='renewals-disabled'>"
438	+ NOT_RENEWABLE_RESTRICTION
439	+ "</span>";
440
441	span_style = "display: none";
442	span_class = "renewals-allowed";
443	} else if ( oObj.can_renew_error == "overdue" ) {
444	msg += "<span class='renewals-disabled'>"
445	+ NOT_RENEWABLE_OVERDUE
446	+ "</span>";
447
448	span_style = "display: none";
449	span_class = "renewals-allowed";
450	} else if ( oObj.can_renew_error == "too_soon" ) {
451	msg += "<span class='renewals-disabled'>"
452	+ NOT_RENEWABLE_TOO_SOON.format( oObj.can_renew_date )
453	+ "</span>";
454
455	span_style = "display: none";
456	span_class = "renewals-allowed";
457	} else if ( oObj.can_renew_error == "auto_too_soon" ) {
458	msg += "<span class='renewals-disabled'>"
459	+ NOT_RENEWABLE_AUTO_TOO_SOON
460	+ "</span>";
461
462	span_style = "display: none";
463	span_class = "renewals-allowed";
464	} else if ( oObj.can_renew_error == "auto_too_late" ) {
465	msg += "<span class='renewals-disabled'>"
466	+ NOT_RENEWABLE_AUTO_TOO_LATE
467	+ "</span>";
468
469	span_style = "display: none";
470	span_class = "renewals-allowed";
471	} else if ( oObj.can_renew_error == "auto_too_much_oweing" ) {
472	msg += "<span class='renewals-disabled'>"
473	+ NOT_RENEWABLE_AUTO_TOO_MUCH_OWEING
474	+ "</span>";
475
476	span_style = "display: none";
477	span_class = "renewals-allowed";
478	} else if ( oObj.can_renew_error == "auto_account_expired" ) {
479	msg += "<span class='renewals-disabled'>"
480	+ NOT_RENEWABLE_AUTO_ACCOUNT_EXPIRED
481	+ "</span>";
482
483	span_style = "display: none";
484	span_class = "renewals-allowed";
485	} else if ( oObj.can_renew_error == "auto_renew" ) {
486	msg += "<span class='renewals-disabled'>"
487	+ NOT_RENEWABLE_AUTO_RENEW
488	+ "</span>";
489
490	span_style = "display: none";
491	span_class = "renewals-allowed";
492	} else if ( oObj.can_renew_error == "onsite_checkout" ) {
493	// Don't display something if it's an onsite checkout
494	} else if ( oObj.can_renew_error == "item_denied_renewal" ) {
495	content += "<span class='renewals-disabled'>"
496	+ NOT_RENEWABLE_DENIED
497	+ "</span>";
498
499	span_style = "display: none";
500	span_class = "renewals-allowed";
501	} else {	422	} else {
502	msg += "<span class='renewals-disabled'>"	423	$(oObj.can_renew_error).each(function(i, error){
503	+ oObj.can_renew_error	424	if ( error == "on_reserve" ) {
504	+ "</span>";	425	msg += "<span>"
		426	+ "<a href='/cgi-bin/koha/reserve/request.pl?biblionumber=" + oObj.biblionumber + "'>" + ON_HOLD + "</a>"
		427	+ "</span>";
		428
		429	span_style = "display: none";
		430	span_class = "renewals-allowed-on_reserve";
		431	}
		432	if ( error == "too_many" ) {
		433	msg += "<span class='renewals-disabled'>"
		434	+ NOT_RENEWABLE
		435	+ "</span>";
		436
		437	span_style = "display: none";
		438	span_class = "renewals-allowed";
		439	}
		440	if ( error == "restriction" ) {
		441	msg += "<span class='renewals-disabled'>"
		442	+ NOT_RENEWABLE_RESTRICTION
		443	+ "</span>";
		444
		445	span_style = "display: none";
		446	span_class = "renewals-allowed";
		447	}
		448	if ( error == "overdue" ) {
		449	msg += "<span class='renewals-disabled'>"
		450	+ NOT_RENEWABLE_OVERDUE
		451	+ "</span>";
		452
		453	span_style = "display: none";
		454	span_class = "renewals-allowed";
		455	}
		456	if ( error == "too_soon" ) {
		457	msg += "<span class='renewals-disabled'>"
		458	+ NOT_RENEWABLE_TOO_SOON.format( oObj.can_renew_date )
		459	+ "</span>";
		460
		461	span_style = "display: none";
		462	span_class = "renewals-allowed";
		463	}
		464	if ( error == "auto_too_soon" ) {
		465	msg += "<span class='renewals-disabled'>"
		466	+ NOT_RENEWABLE_AUTO_TOO_SOON
		467	+ "</span>";
		468
		469	span_style = "display: none";
		470	span_class = "renewals-allowed";
		471	}
		472	if ( error == "auto_too_late" ) {
		473	msg += "<span class='renewals-disabled'>"
		474	+ NOT_RENEWABLE_AUTO_TOO_LATE
		475	+ "</span>";
505		476
506	span_style = "display: none";	477	span_style = "display: none";
507	span_class = "renewals-allowed";	478	span_class = "renewals-allowed";
		479	}
		480	if ( error == "auto_too_much_oweing" ) {
		481	msg += "<span class='renewals-disabled'>"
		482	+ NOT_RENEWABLE_AUTO_TOO_MUCH_OWEING
		483	+ "</span>";
		484
		485	span_style = "display: none";
		486	span_class = "renewals-allowed";
		487	}
		488	if ( error == "auto_account_expired" ) {
		489	msg += "<span class='renewals-disabled'>"
		490	+ NOT_RENEWABLE_AUTO_ACCOUNT_EXPIRED
		491	+ "</span>";
		492
		493	span_style = "display: none";
		494	span_class = "renewals-allowed";
		495	}
		496	if ( error == "auto_renew" ) {
		497	msg += "<span class='renewals-disabled'>"
		498	+ NOT_RENEWABLE_AUTO_RENEW
		499	+ "</span>";
		500
		501	span_style = "display: none";
		502	span_class = "renewals-allowed";
		503	}
		504	if ( error == "onsite_checkout" ) {
		505	// Don't display something if it's an onsite checkout
		506	}
		507	if ( error == "item_denied_renewal" ) {
		508	content += "<span class='renewals-disabled'>"
		509	+ NOT_RENEWABLE_DENIED
		510	+ "</span>";
		511
		512	span_style = "display: none";
		513	span_class = "renewals-allowed";
		514	}
		515	msg += "<br/>";
		516	});
508	}	517	}
509		518
510	var can_force_renew = ( oObj.onsite_checkout == 0 ) &&	519	var can_force_renew = ( oObj.onsite_checkout == 0 ) &&
511	( oObj.can_renew_error != "on_reserve" \|\| (oObj.can_renew_error == "on_reserve" && AllowRenewalOnHoldOverride))	520	( !oObj.can_renew_error \|\| !oObj.can_renew_error.includes("on_reserve") \|\| (oObj.can_renew_error.includes("on_reserve") && AllowRenewalOnHoldOverride))
512	? true : false;	521	? true : false;
513	var can_renew = ( oObj.renewals_remaining > 0 && !oObj.can_renew_error );	522	var can_renew = ( oObj.renewals_remaining > 0 && ( !oObj.can_renew_error \|\| !oObj.can_renew_error.length ) );
514	content += "<span>";	523	content += "<span>";
515	if ( can_renew \|\| can_force_renew ) {	524	if ( can_renew \|\| can_force_renew ) {
516	content += "<span style='padding: 0 1em;'>" + oObj.renewals_count + "</span>";	525	content += "<span style='padding: 0 1em;'>" + oObj.renewals_count + "</span>";
Lines 519-525 $(document).ready(function() { Link Here
519	if ( oObj.date_due_overdue && can_renew ) {	528	if ( oObj.date_due_overdue && can_renew ) {
520	content += "checked='checked' ";	529	content += "checked='checked' ";
521	}	530	}
522	if (oObj.can_renew_error == "on_reserve") {	531	if (oObj.can_renew_error && oObj.can_renew_error.includes("on_reserve")) {
523	content += "data-on-reserve ";	532	content += "data-on-reserve ";
524	}	533	}
525	content += "class='renew' id='renew_" + oObj.itemnumber + "' name='renew' value='" + oObj.itemnumber +"'/>"	534	content += "class='renew' id='renew_" + oObj.itemnumber + "' name='renew' value='" + oObj.itemnumber +"'/>"
Lines 541-547 $(document).ready(function() { Link Here
541	"bSortable": false,	550	"bSortable": false,
542	"bVisible": AllowCirculate ? true : false,	551	"bVisible": AllowCirculate ? true : false,
543	"mDataProp": function ( oObj ) {	552	"mDataProp": function ( oObj ) {
544	if ( oObj.can_renew_error == "on_reserve" ) {	553	if ( oObj.can_renew_error && oObj.can_renew_error.includes("on_reserve") ) {
545	return "<a href='/cgi-bin/koha/reserve/request.pl?biblionumber=" + oObj.biblionumber + "'>" + ON_HOLD + "</a>";	554	return "<a href='/cgi-bin/koha/reserve/request.pl?biblionumber=" + oObj.biblionumber + "'>" + ON_HOLD + "</a>";
546	} else {	555	} else {
547	return "<input type='checkbox' class='checkin' id='checkin_" + oObj.itemnumber + "' name='checkin' value='" + oObj.itemnumber +"'></input>";	556	return "<input type='checkbox' class='checkin' id='checkin_" + oObj.itemnumber + "' name='checkin' value='" + oObj.itemnumber +"'></input>";