Attachment #108559 for bug #23816

View | Details | Raw Unified | Return to bug 23816
Collapse All | Expand All




    plan tests => 7;

    my $library = $builder->build_object( { class => 'Koha::Libraries' } );
    my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => {min_password_length => undef, require_strong_password => undef} } );
    my $patron  = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $category->categorycode } } );
    my $password = 'password';

    t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );

    plan tests => 5;

    my $library = $builder->build_object( { class => 'Koha::Libraries' } );
    my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => {min_password_length => undef, require_strong_password => undef} } );
    my $patron  = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $category->categorycode } } );
    my $password = 'password';
    t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
    t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 1 );




    my $print_error = $schema->storage->dbh->{PrintError};
    $schema->storage->dbh->{PrintError} = 0; ; # FIXME This does not longer work - because of the transaction in Koha::Patron->store?

    my $category = $builder->build_object({class=> 'Koha::Patron::Categories', value=>{min_password_length => undef, require_strong_password => undef}});
    my $patron_1 = $builder->build_object({class=> 'Koha::Patrons', value=> { categorycode => $category->categorycode}});
    my $patron_2 = $builder->build_object({class=> 'Koha::Patrons'});

    throws_ok


    $schema->storage->txn_begin;

    my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } } );
    my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { login_attempts => 3, categorycode => $category->categorycode } } );

    # Disable logging password changes for this tests
    t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );

Lines 443-450 subtest 'test_import_with_password_overwrite' => sub { Link Here

(-)a/t/db_dependent/Koha/Patrons/Import.t (-2 / +2 lines)
443		443
444	#Setup our info	444	#Setup our info
445	my $branchcode = $builder->build({ source => "Branch"})->{branchcode};	445	my $branchcode = $builder->build({ source => "Branch"})->{branchcode};
446	my $categorycode = $builder->build({ source => "Category", value => { category_type => 'A' } })->{categorycode};	446	my $categorycode = $builder->build({ source => "Category", value => { category_type => 'A', min_password_length => undef, require_strong_password => undef } })->{categorycode};
447	my $staff_categorycode = $builder->build({ source => "Category", value => { category_type => 'S' } })->{categorycode};	447	my $staff_categorycode = $builder->build({ source => "Category", value => { category_type => 'S', min_password_length => undef, require_strong_password => undef } })->{categorycode};
448	my $csv_headers = 'surname,userid,branchcode,categorycode,password';	448	my $csv_headers = 'surname,userid,branchcode,categorycode,password';
449	my $csv_password = "Worrell,ErnestP,$branchcode,$categorycode,Ernest11";	449	my $csv_password = "Worrell,ErnestP,$branchcode,$categorycode,Ernest11";
450	my $csv_password_change = "Worrell,ErnestP,$branchcode,$categorycode,Vern1234";	450	my $csv_password_change = "Worrell,ErnestP,$branchcode,$categorycode,Vern1234";

Lines 55-61 subtest 'check_password hook tests' => sub { Link Here

(-)a/t/db_dependent/Koha/Plugins/Patron.t (-1 / +1 lines)
55	my $plugin = Koha::Plugin::Test->new->enable;	55	my $plugin = Koha::Plugin::Test->new->enable;
56		56
57	my $library = $builder->build( { source => 'Branch' } );	57	my $library = $builder->build( { source => 'Branch' } );
58	my $category = $builder->build( { source => 'Category' } );	58	my $category = $builder->build( { source => 'Category', value => {min_password_length => undef, require_strong_password => undef} } );
59	my $patron = Koha::Patron->new(	59	my $patron = Koha::Patron->new(
60	{	60	{
61	cardnumber => 'test_cn_1',	61	cardnumber => 'test_cn_1',

Lines 368-374 my $schema = Koha::Database->schema; Link Here

(-)a/t/db_dependent/Search/History.t (-1 / +2 lines)
368	my $builder = t::lib::TestBuilder->new;	368	my $builder = t::lib::TestBuilder->new;
369		369
370	# Borrower Creation	370	# Borrower Creation
371	our $patron = $builder->build( { source => 'Borrower' } );	371	my $category = $builder->build( { source => 'Category', value => {min_password_length => undef, require_strong_password => undef} } );
		372	our $patron = $builder->build( { source => 'Borrower', value => { categorycode => $category->{categorycode} } } );
372	t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );	373	t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
373	Koha::Patrons->find( $patron->{borrowernumber} )->set_password({ password => 'password' });	374	Koha::Patrons->find( $patron->{borrowernumber} )->set_password({ password => 'password' });
374		375





    my $password = 'AbcdEFG123';

    my $category = $builder->build_object({ class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef }});
    my $patron = $builder->build_object(
        { class => 'Koha::Patrons', value => { userid => 'tomasito', flags => 2**4, categorycode => $category->categorycode } } );
    $patron->set_password({ password => $password });
    my $userid = $patron->userid;



    t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );

    my $category = $builder->build_object({ class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef }});
    my $patron = $builder->build_object(
        { class => 'Koha::Patrons', value => { userid => 'tomasito', flags => 2**4, categorycode => $category->categorycode } } );
    $patron->set_password({ password => $password });
    my $userid = $patron->userid;






my $dbh = C4::Context->dbh;

my $category = $builder->build_object({class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } });
my $librarian = $builder->build_object({
    class => 'Koha::Patrons',
    value => { flags => 2, categorycode => $category->categorycode }
});
my $password = 'thePassword123';
$librarian->set_password({ password => $password, skip_validation => 1 });
my $userid = $librarian->userid;

$category = $builder->build_object({class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } });
my $patron = $builder->build_object({
    class => 'Koha::Patrons',
    value => { flags => 0, categorycode => $category->categorycode }
});
my $unauth_password = 'thePassword000';
$patron->set_password({ password => $unauth_password, skip_validattion => 1 });

Lines 237-246 sub create_user_and_session { Link Here

(-)a/t/db_dependent/api/v1/patrons_password.t (-1 / +2 lines)
237	my ( $args ) = @_;	237	my ( $args ) = @_;
238	my $flags = ( $args->{authorized} ) ? 16 : 0;	238	my $flags = ( $args->{authorized} ) ? 16 : 0;
239		239
		240	my $category = $builder->build_object({ class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef}});
240	my $user = $builder->build_object(	241	my $user = $builder->build_object(
241	{	242	{
242	class => 'Koha::Patrons',	243	class => 'Koha::Patrons',
243	value => { flags => $flags }	244	value => { flags => $flags, categorycode => $category->categorycode }
244	}	245	}
245	);	246	);
246		247




        like( $driver->get_title, qr(Log in to Koha), 'Hitting the main page should redirect to the login form');

        my $password = Koha::AuthUtils::generate_password();
        my $category = $builder->build_object({class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } });
        my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 0, categorycode => $category->categorycode }});
        t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
        $patron->set_password({ password => $password });


        like( $driver->get_title, qr(Koha online catalog), 'Hitting the main page should not redirect to the login form');

        my $password = Koha::AuthUtils::generate_password();
        my $category = $builder->build_object({class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } });
        my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 0, categorycode => $category->categorycode }});
        t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
        $patron->set_password({ password => $password });





subtest 'OPAC - borrowernumber and branchcode as html attributes' => sub {
    plan tests => 2;

    my $category = $builder->build_object({class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } });
    my $patron = $builder->build_object(
        { class => 'Koha::Patrons', value => { flags => 1, categorycode => $category->categorycode } } );
    my $password = Koha::AuthUtils::generate_password();
    t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
    $patron->set_password({ password => $password });

subtest 'XSS vulnerabilities in pagination' => sub {
    plan tests => 3;

    my $category = $builder->build_object({class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } });
    my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { categorycode => $category->categorycode } });
    for ( 1 .. 30 ) { # We want the pagination to be displayed
        push @cleanup, $builder->build_object(
            {
- 

Return to bug 23816

Lines 127-133 subtest 'no_set_userenv parameter tests' => sub { Link Here

(-)a/t/db_dependent/Auth.t (-2 / +4 lines)
127	plan tests => 7;	127	plan tests => 7;
128		128
129	my $library = $builder->build_object( { class => 'Koha::Libraries' } );	129	my $library = $builder->build_object( { class => 'Koha::Libraries' } );
130	my $patron = $builder->build_object( { class => 'Koha::Patrons' } );	130	my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => {min_password_length => undef, require_strong_password => undef} } );
		131	my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $category->categorycode } } );
131	my $password = 'password';	132	my $password = 'password';
132		133
133	t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );	134	t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
Lines 149-155 subtest 'checkpw lockout tests' => sub { Link Here
149	plan tests => 5;	150	plan tests => 5;
150		151
151	my $library = $builder->build_object( { class => 'Koha::Libraries' } );	152	my $library = $builder->build_object( { class => 'Koha::Libraries' } );
152	my $patron = $builder->build_object( { class => 'Koha::Patrons' } );	153	my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => {min_password_length => undef, require_strong_password => undef} } );
		154	my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $category->categorycode } } );
153	my $password = 'password';	155	my $password = 'password';
154	t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );	156	t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
155	t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 1 );	157	t::lib::Mocks::mock_preference( 'FailedLoginAttempts', 1 );

Lines 1735-1741 subtest '->store' => sub { Link Here

(-)a/t/db_dependent/Koha/Patrons.t (-2 / +4 lines)
1735	my $print_error = $schema->storage->dbh->{PrintError};	1735	my $print_error = $schema->storage->dbh->{PrintError};
1736	$schema->storage->dbh->{PrintError} = 0; ; # FIXME This does not longer work - because of the transaction in Koha::Patron->store?	1736	$schema->storage->dbh->{PrintError} = 0; ; # FIXME This does not longer work - because of the transaction in Koha::Patron->store?
1737		1737
1738	my $patron_1 = $builder->build_object({class=> 'Koha::Patrons'});	1738	my $category = $builder->build_object({class=> 'Koha::Patron::Categories', value=>{min_password_length => undef, require_strong_password => undef}});
		1739	my $patron_1 = $builder->build_object({class=> 'Koha::Patrons', value=> { categorycode => $category->categorycode}});
1739	my $patron_2 = $builder->build_object({class=> 'Koha::Patrons'});	1740	my $patron_2 = $builder->build_object({class=> 'Koha::Patrons'});
1740		1741
1741	throws_ok	1742	throws_ok
Lines 1788-1794 subtest '->set_password' => sub { Link Here
1788		1789
1789	$schema->storage->txn_begin;	1790	$schema->storage->txn_begin;
1790		1791
1791	my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { login_attempts => 3 } } );	1792	my $category = $builder->build_object( { class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } } );
		1793	my $patron = $builder->build_object( { class => 'Koha::Patrons', value => { login_attempts => 3, categorycode => $category->categorycode } } );
1792		1794
1793	# Disable logging password changes for this tests	1795	# Disable logging password changes for this tests
1794	t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );	1796	t::lib::Mocks::mock_preference( 'BorrowersLog', 0 );

Lines 38-45 subtest 'success tests' => sub { Link Here

(-)a/t/db_dependent/api/v1/auth_basic.t (-2 / +4 lines)
38		38
39	my $password = 'AbcdEFG123';	39	my $password = 'AbcdEFG123';
40		40
		41	my $category = $builder->build_object({ class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef }});
41	my $patron = $builder->build_object(	42	my $patron = $builder->build_object(
42	{ class => 'Koha::Patrons', value => { userid => 'tomasito', flags => 2**4 } } );	43	{ class => 'Koha::Patrons', value => { userid => 'tomasito', flags => 2**4, categorycode => $category->categorycode } } );
43	$patron->set_password({ password => $password });	44	$patron->set_password({ password => $password });
44	my $userid = $patron->userid;	45	my $userid = $patron->userid;
45		46
Lines 86-93 subtest 'failure tests' => sub { Link Here
86		87
87	t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );	88	t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );
88		89
		90	my $category = $builder->build_object({ class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef }});
89	my $patron = $builder->build_object(	91	my $patron = $builder->build_object(
90	{ class => 'Koha::Patrons', value => { userid => 'tomasito', flags => 2**4 } } );	92	{ class => 'Koha::Patrons', value => { userid => 'tomasito', flags => 2**4, categorycode => $category->categorycode } } );
91	$patron->set_password({ password => $password });	93	$patron->set_password({ password => $password });
92	my $userid = $patron->userid;	94	my $userid = $patron->userid;
93		95

Lines 41-57 $schema->storage->txn_begin; Link Here

(-)a/t/db_dependent/api/v1/checkouts.t (-2 / +4 lines)
41		41
42	my $dbh = C4::Context->dbh;	42	my $dbh = C4::Context->dbh;
43		43
		44	my $category = $builder->build_object({class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } });
44	my $librarian = $builder->build_object({	45	my $librarian = $builder->build_object({
45	class => 'Koha::Patrons',	46	class => 'Koha::Patrons',
46	value => { flags => 2 }	47	value => { flags => 2, categorycode => $category->categorycode }
47	});	48	});
48	my $password = 'thePassword123';	49	my $password = 'thePassword123';
49	$librarian->set_password({ password => $password, skip_validation => 1 });	50	$librarian->set_password({ password => $password, skip_validation => 1 });
50	my $userid = $librarian->userid;	51	my $userid = $librarian->userid;
51		52
		53	$category = $builder->build_object({class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } });
52	my $patron = $builder->build_object({	54	my $patron = $builder->build_object({
53	class => 'Koha::Patrons',	55	class => 'Koha::Patrons',
54	value => { flags => 0 }	56	value => { flags => 0, categorycode => $category->categorycode }
55	});	57	});
56	my $unauth_password = 'thePassword000';	58	my $unauth_password = 'thePassword000';
57	$patron->set_password({ password => $unauth_password, skip_validattion => 1 });	59	$patron->set_password({ password => $unauth_password, skip_validattion => 1 });

Lines 48-54 SKIP: { Link Here

(-)a/t/db_dependent/selenium/authentication.t (-2 / +4 lines)
48	like( $driver->get_title, qr(Log in to Koha), 'Hitting the main page should redirect to the login form');	48	like( $driver->get_title, qr(Log in to Koha), 'Hitting the main page should redirect to the login form');
49		49
50	my $password = Koha::AuthUtils::generate_password();	50	my $password = Koha::AuthUtils::generate_password();
51	my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 0 }});	51	my $category = $builder->build_object({class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } });
		52	my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 0, categorycode => $category->categorycode }});
52	t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );	53	t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
53	$patron->set_password({ password => $password });	54	$patron->set_password({ password => $password });
54		55
Lines 82-88 SKIP: { Link Here
82	like( $driver->get_title, qr(Koha online catalog), 'Hitting the main page should not redirect to the login form');	83	like( $driver->get_title, qr(Koha online catalog), 'Hitting the main page should not redirect to the login form');
83		84
84	my $password = Koha::AuthUtils::generate_password();	85	my $password = Koha::AuthUtils::generate_password();
85	my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 0 }});	86	my $category = $builder->build_object({class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } });
		87	my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 0, categorycode => $category->categorycode }});
86	t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );	88	t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
87	$patron->set_password({ password => $password });	89	$patron->set_password({ password => $password });
88		90

Lines 52-59 our @cleanup; Link Here

(-)a/t/db_dependent/selenium/regressions.t (-3 / +4 lines)
52	subtest 'OPAC - borrowernumber and branchcode as html attributes' => sub {	52	subtest 'OPAC - borrowernumber and branchcode as html attributes' => sub {
53	plan tests => 2;	53	plan tests => 2;
54		54
		55	my $category = $builder->build_object({class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } });
55	my $patron = $builder->build_object(	56	my $patron = $builder->build_object(
56	{ class => 'Koha::Patrons', value => { flags => 1 } } );	57	{ class => 'Koha::Patrons', value => { flags => 1, categorycode => $category->categorycode } } );
57	my $password = Koha::AuthUtils::generate_password();	58	my $password = Koha::AuthUtils::generate_password();
58	t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );	59	t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 );
59	$patron->set_password({ password => $password });	60	$patron->set_password({ password => $password });
Lines 197-203 subtest 'Display circulation table correctly' => sub { Link Here
197	subtest 'XSS vulnerabilities in pagination' => sub {	198	subtest 'XSS vulnerabilities in pagination' => sub {
198	plan tests => 3;	199	plan tests => 3;
199		200
200	my $patron = $builder->build_object({ class => 'Koha::Patrons' });	201	my $category = $builder->build_object({class => 'Koha::Patron::Categories', value => { min_password_length => undef, require_strong_password => undef } });
		202	my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { categorycode => $category->categorycode } });
201	for ( 1 .. 30 ) { # We want the pagination to be displayed	203	for ( 1 .. 30 ) { # We want the pagination to be displayed
202	push @cleanup, $builder->build_object(	204	push @cleanup, $builder->build_object(
203	{	205	{
204	-