View | Details | Raw Unified | Return to bug 26145
Collapse All | Expand All

(-)a/admin/columns_settings.yml (+4 lines)
Lines 273-278 modules: Link Here
273 
              cannot_be_toggled: 1
 273 
              cannot_be_toggled: 1
274 
              cannot_be_modified: 1
 274 
              cannot_be_modified: 1
275 
            -
 275 
            -
276 
              columnname: holdings_cover_image
277 
            -
276 
              columnname: holdings_itype
 278 
              columnname: holdings_itype
277 
            -
 279 
            -
278 
              columnname: holdings_holdingbranch
 280 
              columnname: holdings_holdingbranch
Lines 328-333 modules: Link Here
328 
              cannot_be_toggled: 1
 330 
              cannot_be_toggled: 1
329 
              cannot_be_modified: 1
 331 
              cannot_be_modified: 1
330 
            -
 332 
            -
333 
              columnname: otherholdings_cover_image
334 
            -
331 
              columnname: otherholdings_itype
 335 
              columnname: otherholdings_itype
332 
            -
 336 
            -
333 
              columnname: otherholdings_holdingbranch
 337 
              columnname: otherholdings_holdingbranch
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt (-2 / +5 lines)
Lines 284-290 Link Here
284 
            <tr>
 284 
            <tr>
285 
                [% IF (StaffDetailItemSelection) %]<th id="[% tab | html %]_checkbox" data-colname="[% tab | html %]_checkbox" class="NoSort"></th>[% END %]
 285 
                [% IF (StaffDetailItemSelection) %]<th id="[% tab | html %]_checkbox" data-colname="[% tab | html %]_checkbox" class="NoSort"></th>[% END %]
286 
                [% IF Koha.Preference('LocalCoverImages') && ( tab == 'holdings' && itemloop_has_images || tab == 'otherholdings' && otheritemloop_has_images ) %]
 286 
                [% IF Koha.Preference('LocalCoverImages') && ( tab == 'holdings' && itemloop_has_images || tab == 'otherholdings' && otheritemloop_has_images ) %]
287 
                    <th id="[% tab | html %]_cover" data-colname="[% tab | html %]_cover">Cover image</th>
 287 
                    <th id="[% tab | html %]_cover_image" data-colname="[% tab | html %]_cover_image">Cover image</th>
288 
                [% END %]
 288 
                [% END %]
289 
                [% IF ( item_level_itypes ) %]<th id="[% tab | html %]_itype" data-colname="[% tab | html %]_itype">Item type</th>[% END %]
 289 
                [% IF ( item_level_itypes ) %]<th id="[% tab | html %]_itype" data-colname="[% tab | html %]_itype">Item type</th>[% END %]
290 
                <th id="[% tab | html %]_holdingbranch" data-colname="[% tab | html %]_holdingbranch">Current library</th>
 290 
                <th id="[% tab | html %]_holdingbranch" data-colname="[% tab | html %]_holdingbranch">Current library</th>
Lines 1270-1277 Note that permanent location is a code, and location may be an authval. Link Here
1270 
        $(document).ready(function() {
 1270 
        $(document).ready(function() {
1271 
            var ids = ['holdings_table', 'otherholdings_table'];
 1271 
            var ids = ['holdings_table', 'otherholdings_table'];
1272 
            var columns_settings = [ [% TablesSettings.GetColumns('catalogue', 'detail','holdings_table','json') | $raw %], [% TablesSettings.GetColumns('catalogue', 'detail','otherholdings_table','json')  | $raw %] ];
 1272 
            var columns_settings = [ [% TablesSettings.GetColumns('catalogue', 'detail','holdings_table','json') | $raw %], [% TablesSettings.GetColumns('catalogue', 'detail','otherholdings_table','json')  | $raw %] ];
1273 
            var has_images = ["[% itemloop_has_images %]", "[% otheritemloop_has_images %]"];
1273 
            for (var i in ids) {
 1274 
            for (var i in ids) {
1274 
                var id = ids[i];
 1275 
                var id = ids[i];
1276 
                if ( !has_images[i] ) { // remove the cover_image column
1277 
                    columns_settings.splice(1,1);
1278 
                }
1275 
                var dt_parameters = {
 1279 
                var dt_parameters = {
1276 
                    'sDom': 't',
 1280 
                    'sDom': 't',
1277 
                    'bPaginate': false,
 1281 
                    'bPaginate': false,
1278 
-

Return to bug 26145