Attachment #110686 for bug #26529

View | Details | Raw Unified | Return to bug 26529
Collapse All | Expand All





sub set_rule {
    my ( $self, $params ) = @_;
warn Data::Dumper::Dumper( $params );
    for my $mandatory_parameter (qw( rule_name rule_value ) ) {
        Koha::Exceptions::MissingParameter->throw(
            "Required parameter '$mandatory_parameter' missing")

    }
    else {
        if ( defined $rule_value ) {
            warn "presumably here";
            $rule = Koha::CirculationRule->new(
                {
                    branchcode   => $branchcode,


    my $rule_objects = [];
    while ( my ( $rule_name, $rule_value ) = each %$rules ) {
        warn "name: $rule_name, value: $rule_value";
        my $rule_object = Koha::CirculationRules->set_rule(
            {
                %set_params,




    my $patron_maxissueqty = strip_non_numeric( scalar $input->param('patron_maxissueqty') );
    my $patron_maxonsiteissueqty = $input->param('patron_maxonsiteissueqty');
    $patron_maxonsiteissueqty = strip_non_numeric($patron_maxonsiteissueqty);
    my $holdallowed   = $input->param('holdallowed') ||  undef;
    my $hold_fulfillment_policy = $input->param('hold_fulfillment_policy') || undef;
    my $returnbranch  = $input->param('returnbranch') || undef;
    my $max_holds = strip_non_numeric( scalar $input->param('max_holds') );
    $holdallowed =~ s/\s//g;
    $holdallowed = undef if $holdallowed !~ /^\d+/;

    if ($branch eq "*") {
        Koha::CirculationRules->set_rules(

Lines 42-48 my $script_name = "/cgi-bin/koha/tools/manage-marc-import.pl"; Link Here

(-)a/tools/manage-marc-import.pl (-2 / +1 lines)
42	my $input = new CGI;	42	my $input = new CGI;
43	my $op = $input->param('op') \|\| '';	43	my $op = $input->param('op') \|\| '';
44	my $completedJobID = $input->param('completedJobID');	44	my $completedJobID = $input->param('completedJobID');
45	our $runinbackground = $input->param('runinbackground');	45	our $runinbackground = 0;#$input->param('runinbackground');
46	my $import_batch_id = $input->param('import_batch_id') \|\| '';	46	my $import_batch_id = $input->param('import_batch_id') \|\| '';
47		47
48	# record list displays	48	# record list displays
49	-

Return to bug 26529

Lines 250-256 sub get_effective_rules { Link Here

(-)a/Koha/CirculationRules.pm (-1 / +3 lines)
250		250
251	sub set_rule {	251	sub set_rule {
252	my ( $self, $params ) = @_;	252	my ( $self, $params ) = @_;
253		253	warn Data::Dumper::Dumper( $params );
254	for my $mandatory_parameter (qw( rule_name rule_value ) ) {	254	for my $mandatory_parameter (qw( rule_name rule_value ) ) {
255	Koha::Exceptions::MissingParameter->throw(	255	Koha::Exceptions::MissingParameter->throw(
256	"Required parameter '$mandatory_parameter' missing")	256	"Required parameter '$mandatory_parameter' missing")
Lines 302-307 sub set_rule { Link Here
302	}	302	}
303	else {	303	else {
304	if ( defined $rule_value ) {	304	if ( defined $rule_value ) {
		305	warn "presumably here";
305	$rule = Koha::CirculationRule->new(	306	$rule = Koha::CirculationRule->new(
306	{	307	{
307	branchcode => $branchcode,	308	branchcode => $branchcode,
Lines 333-338 sub set_rules { Link Here
333		334
334	my $rule_objects = [];	335	my $rule_objects = [];
335	while ( my ( $rule_name, $rule_value ) = each %$rules ) {	336	while ( my ( $rule_name, $rule_value ) = each %$rules ) {
		337	warn "name: $rule_name, value: $rule_value";
336	my $rule_object = Koha::CirculationRules->set_rule(	338	my $rule_object = Koha::CirculationRules->set_rule(
337	{	339	{
338	%set_params,	340	%set_params,

Lines 337-348 elsif ($op eq "set-branch-defaults") { Link Here

(-)a/admin/smart-rules.pl (-5 / +3 lines)
337	my $patron_maxissueqty = strip_non_numeric( scalar $input->param('patron_maxissueqty') );	337	my $patron_maxissueqty = strip_non_numeric( scalar $input->param('patron_maxissueqty') );
338	my $patron_maxonsiteissueqty = $input->param('patron_maxonsiteissueqty');	338	my $patron_maxonsiteissueqty = $input->param('patron_maxonsiteissueqty');
339	$patron_maxonsiteissueqty = strip_non_numeric($patron_maxonsiteissueqty);	339	$patron_maxonsiteissueqty = strip_non_numeric($patron_maxonsiteissueqty);
340	my $holdallowed = $input->param('holdallowed');	340	my $holdallowed = $input->param('holdallowed') \|\| undef;
341	my $hold_fulfillment_policy = $input->param('hold_fulfillment_policy');	341	my $hold_fulfillment_policy = $input->param('hold_fulfillment_policy') \|\| undef;
342	my $returnbranch = $input->param('returnbranch');	342	my $returnbranch = $input->param('returnbranch') \|\| undef;
343	my $max_holds = strip_non_numeric( scalar $input->param('max_holds') );	343	my $max_holds = strip_non_numeric( scalar $input->param('max_holds') );
344	$holdallowed =~ s/\s//g;
345	$holdallowed = undef if $holdallowed !~ /^\d+/;
346		344
347	if ($branch eq "*") {	345	if ($branch eq "*") {
348	Koha::CirculationRules->set_rules(	346	Koha::CirculationRules->set_rules(