Attachment #114010 for bug #26282

View | Details | Raw Unified | Return to bug 26282
Collapse All | Expand All

Lines 914-919 Cancels all reserves with an expiration date from before today. Link Here

(-)a/C4/Reserves.pm (+2 lines)
914		914
915	sub CancelExpiredReserves {	915	sub CancelExpiredReserves {
916	my $cancellation_reason = shift;	916	my $cancellation_reason = shift;
		917	my $notify = shift;
917	my $today = dt_from_string();	918	my $today = dt_from_string();
918	my $cancel_on_holidays = C4::Context->preference('ExpireReservesOnHolidays');	919	my $cancel_on_holidays = C4::Context->preference('ExpireReservesOnHolidays');
919	my $expireWaiting = C4::Context->preference('ExpireReservesMaxPickUpDelay');	920	my $expireWaiting = C4::Context->preference('ExpireReservesMaxPickUpDelay');
Lines 932-937 sub CancelExpiredReserves { Link Here
932		933
933	my $cancel_params = {};	934	my $cancel_params = {};
934	$cancel_params->{cancellation_reason} = $cancellation_reason if defined($cancellation_reason);	935	$cancel_params->{cancellation_reason} = $cancellation_reason if defined($cancellation_reason);
		936	$cancel_params->{notify_patron} = $notify if defined($notify);
935	if ( defined($hold->found) && $hold->found eq 'W' ) {	937	if ( defined($hold->found) && $hold->found eq 'W' ) {
936	$cancel_params->{charge_cancel_fee} = 1;	938	$cancel_params->{charge_cancel_fee} = 1;
937	}	939	}




=head1 SYNOPSIS

  ./cancel_expired_holds.pl
  ./cancel_expired_holds.pl --reason="EXPIRED" --notify

or, in crontab:

  0 1 * * * cancel_expired_holds.pl
  0 1 * * * cancel_expired_holds.pl --reason="EXPIRED" --notify

=head1 DESCRIPTION



=item B<--reason>

Optionally adds a reason for cancellation

=item B<--notify>

Optionally trigger a notice to be sent to the patron

=back

=cut

my $help = 0;
my $notify = 0;
my $reason;

GetOptions(
    'help|?'   => \$help,
    'notify'   => \$notify,
    'reason=s' => \$reason,
) or pod2usage(1);
pod2usage(1) if $help;

cronlogaction();

CancelExpiredReserves($reason, $notify);
- 

Return to bug 26282

Lines 25-36 cancel_expired_holds.pl - cron script to cancel holds as they expire Link Here

(-)a/misc/cronjobs/holds/cancel_expired_holds.pl (-6 / +11 lines)
25	=head1 SYNOPSIS	25	=head1 SYNOPSIS
26		26
27	./cancel_expired_holds.pl	27	./cancel_expired_holds.pl
28	./cancel_expired_holds.pl --reason="EXPIRED"	28	./cancel_expired_holds.pl --reason="EXPIRED" --notify
29		29
30	or, in crontab:	30	or, in crontab:
31		31
32	0 1 * * * cancel_expired_holds.pl	32	0 1 * * * cancel_expired_holds.pl
33	0 1 * * * cancel_expired_holds.pl --reason="EXPIRED"	33	0 1 * * * cancel_expired_holds.pl --reason="EXPIRED" --notify
34		34
35	=head1 DESCRIPTION	35	=head1 DESCRIPTION
36		36
Lines 63-83 Print a brief help message and exits. Link Here
63		63
64	=item B<--reason>	64	=item B<--reason>
65		65
66	Optionally adds a reason for cancellation (which will trigger a notice to be sent to the patron)	66	Optionally adds a reason for cancellation
		67
		68	=item B<--notify>
		69
		70	Optionally trigger a notice to be sent to the patron
67		71
68	=back	72	=back
69		73
70	=cut	74	=cut
71		75
72	my $help = 0;	76	my $help = 0;
		77	my $notify = 0;
73	my $reason;	78	my $reason;
74		79
75	GetOptions(	80	GetOptions(
76	'help\|?' => \$help,	81	'help\|?' => \$help,
77	'reason=s' => \$reason	82	'notify' => \$notify,
		83	'reason=s' => \$reason,
78	) or pod2usage(1);	84	) or pod2usage(1);
79	pod2usage(1) if $help;	85	pod2usage(1) if $help;
80		86
81	cronlogaction();	87	cronlogaction();
82		88
83	CancelExpiredReserves($reason);	89	CancelExpiredReserves($reason, $notify);
84	-