View | Details | Raw Unified | Return to bug 27718
Collapse All | Expand All

(-)a/t/db_dependent/Koha/Holds.t (-9 / +23 lines)
Lines 410-425 subtest 'Desks' => sub { Link Here
410
};
410
};
411
411
412
subtest 'get_items_that_can_fill' => sub {
412
subtest 'get_items_that_can_fill' => sub {
413
    plan tests => 1;
413
    plan tests => 2;
414
414
415
    my $biblio = $builder->build_sample_biblio;
415
    my $biblio = $builder->build_sample_biblio;
416
    my $item_1 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } );
416
    my $itype_1 = $builder->build_object({ class => 'Koha::ItemTypes' }); # For 1, 2, 3, 4
417
    my $item_2 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } );
417
    my $itype_2 = $builder->build_object({ class => 'Koha::ItemTypes' });
418
    my $item_3 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } )
418
    my $item_1 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, itype => $itype_1->itemtype } );
419
    my $item_2 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, itype => $itype_1->itemtype } );
420
    my $item_3 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, itype => $itype_1->itemtype } )
419
      ;    # onloan
421
      ;    # onloan
420
    my $item_4 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } )
422
    my $item_4 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, itype => $itype_1->itemtype } )
421
      ;    # in transfer
423
      ;    # in transfer
422
    my $item_5 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } );
424
    my $item_5 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, itype => $itype_2->itemtype } );
423
    my $lost       = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, itemlost => 1 } );
425
    my $lost       = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, itemlost => 1 } );
424
    my $withdrawn  = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, withdrawn => 1 } );
426
    my $withdrawn  = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, withdrawn => 1 } );
425
    my $notforloan = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, notforloan => 1 } );
427
    my $notforloan = $builder->build_sample_item( { biblionumber => $biblio->biblionumber, notforloan => 1 } );
Lines 479-487 subtest 'get_items_that_can_fill' => sub { Link Here
479
        }
481
        }
480
    );
482
    );
481
483
482
    my @items = $holds->get_items_that_can_fill;
484
    my $items = $holds->get_items_that_can_fill;
483
    is_deeply( [ map { $_->itemnumber } @items ],
485
    is_deeply( [ map { $_->itemnumber } $items->as_list ],
484
        [ $item_2->itemnumber, $item_5->itemnumber ], 'Only item 1 and 5 are available for filling the hold' );
486
        [ $item_2->itemnumber, $item_5->itemnumber ], 'Only item 1 and 5 are available for filling the hold' );
487
488
    # Marking item_5 is no hold allowed
489
    Koha::CirculationRule->new(
490
        {
491
            rule_name  => 'holdallowed',
492
            rule_value => 0,
493
            itemtype   => $item_5->itype
494
        }
495
    )->store;
496
    $items = $holds->get_items_that_can_fill;
497
    is_deeply( [ map { $_->itemnumber } $items->as_list ],
498
        [ $item_2->itemnumber ], 'Only item 1 is available for filling the hold' );
499
485
};
500
};
486
501
487
$schema->storage->txn_rollback;
502
$schema->storage->txn_rollback;
488
- 

Return to bug 27718