GetMarcNotes

=head2 GetMarcNotes

    $marcnotesarray = GetMarcNotes( $record, $marcflavour );

    Get all notes from the MARC record and returns them in an array.

    The notes are stored in different fields depending on MARC flavour.

    MARC21 5XX $u subfields receive special attention as they are URIs.

=cut

sub GetMarcNotes {

    my ( $record, $marcflavour, $opac ) = @_;

    if (!$record) {

        carp 'GetMarcNotes called on undefined record';

        return;

    }

    my $scope = $marcflavour eq "UNIMARC"? '3..': '5..';

    my @marcnotes;

    #MARC21 specs indicate some notes should be private if first indicator 0

    my %maybe_private = (

        541 => 1,

        542 => 1,

        561 => 1,

        583 => 1,

        590 => 1

    );

    my %hiddenlist = map { $_ => 1 }

        split( /,/, C4::Context->preference('NotesToHide'));

    foreach my $field ( $record->field($scope) ) {

        my $tag = $field->tag();

        next if $hiddenlist{ $tag };

        next if $opac && $maybe_private{$tag} && !$field->indicator(1);

        if( $marcflavour ne 'UNIMARC' && $field->subfield('u') ) {

            # Field 5XX$u always contains URI

            # Examples: 505u, 506u, 510u, 514u, 520u, 530u, 538u, 540u, 542u, 552u, 555u, 561u, 563u, 583u

            # We first push the other subfields, then all $u's separately

            # Leave further actions to the template (see e.g. opac-detail)

            my $othersub =

                join '', ( 'a' .. 't', 'v' .. 'z', '0' .. '9' ); # excl 'u'

            push @marcnotes, { marcnote => $field->as_string($othersub) };

            foreach my $sub ( $field->subfield('u') ) {

                $sub =~ s/^\s+|\s+$//g; # trim

                push @marcnotes, { marcnote => $sub };

            }

        } else {

            push @marcnotes, { marcnote => $field->as_string() };

        }

    }

    return \@marcnotes;

}

warning_is { $ret = GetMarcNotes() }

           { carped => 'GetMarcNotes called on undefined record'},

           "GetMarcNotes returns carped warning on undef record";

ok( !defined $ret, 'GetMarcNotes returns undef if not passed rec');

#!/usr/bin/perl

# This file is part of Koha.

#

# Koha is free software; you can redistribute it and/or modify it

# under the terms of the GNU General Public License as published by

# the Free Software Foundation; either version 3 of the License, or

# (at your option) any later version.

#

# Koha is distributed in the hope that it will be useful, but

# WITHOUT ANY WARRANTY; without even the implied warranty of

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

# GNU General Public License for more details.

#

# You should have received a copy of the GNU General Public License

# along with Koha; if not, see <http://www.gnu.org/licenses>.

use Modern::Perl;

use Test::More tests => 2;

use t::lib::Mocks;

use MARC::Field;

use MARC::Record;

use C4::Biblio;

subtest 'GetMarcNotes MARC21' => sub {

    plan tests => 11;

    t::lib::Mocks::mock_preference( 'NotesToHide', '520' );

    my $record = MARC::Record->new;

    $record->append_fields(

        MARC::Field->new( '500', '', '', a => 'Note1' ),

        MARC::Field->new( '505', '', '', a => 'Note2', u => 'http://someserver.com' ),

        MARC::Field->new( '520', '', '', a => 'Note3 skipped' ),

        MARC::Field->new( '541', '0', '', a => 'Note4 skipped on opac' ),

        MARC::Field->new( '541', '', '', a => 'Note5' ),

    );

    my $notes = C4::Biblio::GetMarcNotes( $record, 'MARC21' );

    is( $notes->[0]->{marcnote}, 'Note1', 'First note' );

    is( $notes->[1]->{marcnote}, 'Note2', 'Second note' );

    is( $notes->[2]->{marcnote}, 'http://someserver.com', 'URL separated' );

    is( $notes->[3]->{marcnote}, 'Note4 skipped on opac',"Not shows if not opac" );

    is( $notes->[4]->{marcnote}, 'Note5', 'Fifth note' );

    is( @$notes, 5, 'No more notes' );

    $notes = C4::Biblio::GetMarcNotes( $record, 'MARC21', 1 );

    is( $notes->[0]->{marcnote}, 'Note1', 'First note' );

    is( $notes->[1]->{marcnote}, 'Note2', 'Second note' );

    is( $notes->[2]->{marcnote}, 'http://someserver.com', 'URL separated' );

    is( $notes->[3]->{marcnote}, 'Note5', 'Fifth note shows after fourth skipped' );

    is( @$notes, 4, 'No more notes' );

};

subtest 'GetMarcNotes UNIMARC' => sub {

    plan tests => 3;

    t::lib::Mocks::mock_preference( 'NotesToHide', '310' );

    my $record = MARC::Record->new;

    $record->append_fields(

        MARC::Field->new( '300', '', '', a => 'Note1' ),

        MARC::Field->new( '300', '', '', a => 'Note2' ),

        MARC::Field->new( '310', '', '', a => 'Note3 skipped' ),

    );

    my $notes = C4::Biblio::GetMarcNotes( $record, 'UNIMARC' );

    is( $notes->[0]->{marcnote}, 'Note1', 'First note' );

    is( $notes->[1]->{marcnote}, 'Note2', 'Second note' );

    is( @$notes, 2, 'No more notes' );

};

    # test for GetMarcNotes

    my $a1= GetMarcNotes( $marc_record, $marcflavour );

    my $field2 = MARC::Field->new( $marcflavour eq 'UNIMARC'? 300: 555, 0, '', a=> 'Some text', u=> 'http://url-1.com', u=> 'nohttp://something_else' );

    $marc_record->append_fields( $field2 );

    my $a2= GetMarcNotes( $marc_record, $marcflavour );

    is( ( $marcflavour eq 'UNIMARC' && @$a2 == @$a1 + 1 ) ||

        ( $marcflavour ne 'UNIMARC' && @$a2 == @$a1 + 3 ), 1,

        'Check the number of returned notes of GetMarcNotes' );