|
Lines 22-28
my $dbh = C4::Context->dbh;
Link Here
|
| 22 |
teardown(); |
22 |
teardown(); |
| 23 |
|
23 |
|
| 24 |
subtest 'CRUD' => sub { |
24 |
subtest 'CRUD' => sub { |
| 25 |
plan tests => 13; |
25 |
plan tests => 14; |
| 26 |
my $patron = $builder->build({ |
26 |
my $patron = $builder->build({ |
| 27 |
source => 'Borrower', |
27 |
source => 'Borrower', |
| 28 |
}); |
28 |
}); |
|
Lines 44-49
subtest 'CRUD' => sub {
Link Here
|
| 44 |
is( $number_of_shelves, 1, '1 shelf should have been inserted' ); |
44 |
is( $number_of_shelves, 1, '1 shelf should have been inserted' ); |
| 45 |
is( $shelf->allow_change_from_owner, 1, 'The default value for allow_change_from_owner should be 1' ); |
45 |
is( $shelf->allow_change_from_owner, 1, 'The default value for allow_change_from_owner should be 1' ); |
| 46 |
is( $shelf->allow_change_from_others, 0, 'The default value for allow_change_from_others should be 0' ); |
46 |
is( $shelf->allow_change_from_others, 0, 'The default value for allow_change_from_others should be 0' ); |
|
|
47 |
is ( $shelf->allow_change_from_staff, 0, 'The default value for allow_change_from_staff should be 0'); |
| 47 |
is( t::lib::Dates::compare( $shelf->created_on, dt_from_string), 0, 'The creation time should have been set to today' ); |
48 |
is( t::lib::Dates::compare( $shelf->created_on, dt_from_string), 0, 'The creation time should have been set to today' ); |
| 48 |
|
49 |
|
| 49 |
# Test if creation date will not be overwritten by store |
50 |
# Test if creation date will not be overwritten by store |
|
Lines 171-179
subtest 'Sharing' => sub {
Link Here
|
| 171 |
|
172 |
|
| 172 |
subtest 'Shelf content' => sub { |
173 |
subtest 'Shelf content' => sub { |
| 173 |
|
174 |
|
| 174 |
plan tests => 18; |
175 |
plan tests => 21; |
| 175 |
my $patron1 = $builder->build( { source => 'Borrower', } ); |
176 |
my $patron1 = $builder->build( { source => 'Borrower', } ); |
| 176 |
my $patron2 = $builder->build( { source => 'Borrower', } ); |
177 |
my $patron2 = $builder->build( { source => 'Borrower', } ); |
|
|
178 |
my $patron3 = $builder->build( { source => 'Borrower', value => {flags => 1} }); |
| 177 |
my $biblio1 = $builder->build_sample_biblio; |
179 |
my $biblio1 = $builder->build_sample_biblio; |
| 178 |
my $biblio2 = $builder->build_sample_biblio; |
180 |
my $biblio2 = $builder->build_sample_biblio; |
| 179 |
my $biblio3 = $builder->build_sample_biblio; |
181 |
my $biblio3 = $builder->build_sample_biblio; |
|
Lines 247-264
subtest 'Shelf content' => sub {
Link Here
|
| 247 |
$number_of_contents = Koha::Virtualshelfcontents->search->count; |
249 |
$number_of_contents = Koha::Virtualshelfcontents->search->count; |
| 248 |
is( $number_of_contents, 3, 'Back to three entries' ); |
250 |
is( $number_of_contents, 3, 'Back to three entries' ); |
| 249 |
|
251 |
|
|
|
252 |
# allow_change_from_staff == 1 and allow_change_from_others == 0 |
| 253 |
$shelf->allow_change_from_staff( 1 ); |
| 254 |
$shelf->allow_change_from_others( 0 ); |
| 255 |
$content4 = $shelf->add_biblio( $biblio3->biblionumber, $patron3->{borrowernumber} ); |
| 256 |
$number_of_contents = Koha::Virtualshelfcontents->search->count; |
| 257 |
is( $number_of_contents, 4, 'The biblio should have been added to the shelf by patron 2'); |
| 258 |
$number_of_deleted_biblios = $shelf->remove_biblios( { biblionumbers => [ $biblio3->biblionumber ], borrowernumber => $patron3->{borrowernumber} } ); |
| 259 |
is( $number_of_deleted_biblios, 1, 'Biblio 3 deleted by patron 2' ); |
| 260 |
$number_of_contents = Koha::Virtualshelfcontents->search->count; |
| 261 |
is( $number_of_contents, 3, 'Back to three entries' ); |
| 262 |
|
| 250 |
teardown(); |
263 |
teardown(); |
| 251 |
}; |
264 |
}; |
| 252 |
|
265 |
|
| 253 |
subtest 'Shelf permissions' => sub { |
266 |
subtest 'Shelf permissions' => sub { |
| 254 |
|
267 |
|
| 255 |
plan tests => 40; |
268 |
plan tests => 70; |
| 256 |
my $patron1 = $builder->build( { source => 'Borrower', value => { flags => '2096766' } } ); # 2096766 is everything checked but not superlibrarian |
269 |
my $patron1 = $builder->build( { source => 'Borrower', value => { flags => '2096766' } } ); # 2096766 is everything checked but not superlibrarian |
| 257 |
my $patron2 = $builder->build( { source => 'Borrower', value => { flags => '1048190' } } ); # 1048190 is everything checked but not superlibrarian and delete_public_lists |
270 |
my $patron2 = $builder->build( { source => 'Borrower', value => { flags => '1048190' } } ); # 1048190 is everything checked but not superlibrarian and delete_public_lists |
|
|
271 |
my $patron3 = $builder->build( { source => 'Borrower', value => { flags => '0' } } ); # this is a patron with no special permissions |
| 258 |
my $biblio1 = $builder->build_sample_biblio; |
272 |
my $biblio1 = $builder->build_sample_biblio; |
| 259 |
my $biblio2 = $builder->build_sample_biblio; |
273 |
my $biblio2 = $builder->build_sample_biblio; |
| 260 |
my $biblio3 = $builder->build_sample_biblio; |
274 |
my $biblio3 = $builder->build_sample_biblio; |
| 261 |
my $biblio4 = $builder->build_sample_biblio; |
275 |
my $biblio4 = $builder->build_sample_biblio; |
|
|
276 |
my $biblio5 = $builder->build_sample_biblio; |
| 262 |
|
277 |
|
| 263 |
my $public_shelf = Koha::Virtualshelf->new( |
278 |
my $public_shelf = Koha::Virtualshelf->new( |
| 264 |
{ shelfname => "my first shelf", |
279 |
{ shelfname => "my first shelf", |
|
Lines 266-307
subtest 'Shelf permissions' => sub {
Link Here
|
| 266 |
category => 2, |
281 |
category => 2, |
| 267 |
allow_change_from_owner => 0, |
282 |
allow_change_from_owner => 0, |
| 268 |
allow_change_from_others => 0, |
283 |
allow_change_from_others => 0, |
|
|
284 |
allow_change_from_staff => 0, |
| 269 |
} |
285 |
} |
| 270 |
)->store; |
286 |
)->store; |
| 271 |
|
287 |
|
| 272 |
is( $public_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view his public list' ); |
288 |
is( $public_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view his public list' ); |
| 273 |
is( $public_shelf->can_be_viewed( $patron2->{borrowernumber} ), 1, 'Public list should be viewed by someone else' ); |
289 |
is( $public_shelf->can_be_viewed( $patron2->{borrowernumber} ), 1, 'Public list should be viewed by another staff member'); |
|
|
290 |
is( $public_shelf->can_be_viewed( $patron3->{borrowernumber} ), 1, 'Public list should be viewed by someone with no special permissions' ); |
| 274 |
|
291 |
|
| 275 |
is( $public_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete his list' ); |
292 |
is( $public_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete his list' ); |
| 276 |
is( $public_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Public list should not be deleted by someone else' ); |
293 |
is( $public_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Public list should not be deleted by another staff member' ); |
|
|
294 |
is( $public_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Public list should not be deleted by someone with no special permissions' ); |
| 277 |
|
295 |
|
| 278 |
is( $public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' ); |
296 |
is( $public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' ); |
| 279 |
is( $public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Public list should not be managed by someone else' ); |
297 |
is( $public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Public list should not be managed by another staff member' ); |
|
|
298 |
is( $public_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Public list should not be managed by someone with no special permissions' ); |
| 280 |
|
299 |
|
| 281 |
is( $public_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 0, 'The owner should not be able to add biblios to their list' ); |
300 |
is( $public_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 0, 'The owner should not be able to add biblios to their list' ); |
| 282 |
is( $public_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (add) by someone else' ); |
301 |
is( $public_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (add) by another staff member' ); |
|
|
302 |
is( $public_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0, 'Public list should not be modified (add) by someone with no special permissions' ); |
| 283 |
|
303 |
|
| 284 |
is( $public_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 0, 'The owner should not be able to remove biblios to their list' ); |
304 |
is( $public_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 0, 'The owner should not be able to remove biblios to their list' ); |
| 285 |
is( $public_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (remove) by someone else' ); |
305 |
is( $public_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (remove) by another staff member' ); |
|
|
306 |
is ( $public_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0, 'Public list should not be modified (removed) by someone with no special permissions' ); |
| 286 |
|
307 |
|
| 287 |
|
308 |
|
| 288 |
$public_shelf->allow_change_from_owner(1); |
309 |
$public_shelf->allow_change_from_owner(1); |
| 289 |
$public_shelf->store; |
310 |
$public_shelf->store; |
| 290 |
|
311 |
|
| 291 |
is( $public_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view his public list' ); |
312 |
is( $public_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view his public list' ); |
| 292 |
is( $public_shelf->can_be_viewed( $patron2->{borrowernumber} ), 1, 'Public list should be viewed by someone else' ); |
313 |
is( $public_shelf->can_be_viewed( $patron2->{borrowernumber} ), 1, 'Public list should be viewed by staff member' ); |
|
|
314 |
is( $public_shelf->can_be_viewed( $patron3->{borrowernumber} ), 1, 'Public list should be viewed by someone with no special permissions' ); |
| 293 |
|
315 |
|
| 294 |
is( $public_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete his list' ); |
316 |
is( $public_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete his list' ); |
| 295 |
is( $public_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Public list should not be deleted by someone else' ); |
317 |
is( $public_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Public list should not be deleted by another staff member' ); |
|
|
318 |
is( $public_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Public list should not be deleted by someone with no special permissions' ); |
| 296 |
|
319 |
|
| 297 |
is( $public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' ); |
320 |
is( $public_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' ); |
| 298 |
is( $public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Public list should not be managed by someone else' ); |
321 |
is( $public_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Public list should not be managed by another staff member' ); |
|
|
322 |
is( $public_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Public list should not be managed by someone with no special permissions' ); |
| 299 |
|
323 |
|
| 300 |
is( $public_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1, 'The owner should be able to add biblios to his list' ); |
324 |
is( $public_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1, 'The owner should be able to add biblios to his list' ); |
| 301 |
is( $public_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (add) by someone else' ); |
325 |
is( $public_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (add) by another staff member' ); |
|
|
326 |
is( $public_shelf->can_biblios_be_added( $patron3->{borrowerbumber} ), 0, 'Public list should not be modified (add) by someone with no special permissions' ); |
| 302 |
|
327 |
|
| 303 |
is( $public_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1, 'The owner should be able to remove biblios to his list' ); |
328 |
is( $public_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1, 'The owner should be able to remove biblios to his list' ); |
| 304 |
is( $public_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (remove) by someone else' ); |
329 |
is( $public_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0, 'Public list should not be modified (remove) by another staff member' ); |
|
|
330 |
is( $public_shelf->can_biblios_be_removed( $patron3->{borroernumber} ), 0, 'Public list should not be modified (remove) by someone with no special permissions' ); |
| 305 |
|
331 |
|
| 306 |
|
332 |
|
| 307 |
my $private_shelf = Koha::Virtualshelf->new( |
333 |
my $private_shelf = Koha::Virtualshelf->new( |
|
Lines 310-333
subtest 'Shelf permissions' => sub {
Link Here
|
| 310 |
category => 1, |
336 |
category => 1, |
| 311 |
allow_change_from_owner => 0, |
337 |
allow_change_from_owner => 0, |
| 312 |
allow_change_from_others => 0, |
338 |
allow_change_from_others => 0, |
|
|
339 |
allow_change_from_staff => 0, |
| 313 |
} |
340 |
} |
| 314 |
)->store; |
341 |
)->store; |
| 315 |
|
342 |
|
| 316 |
is( $private_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view his list' ); |
343 |
is( $private_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view his list' ); |
| 317 |
is( $private_shelf->can_be_viewed( $patron2->{borrowernumber} ), 0, 'Private list should not be viewed by someone else' ); |
344 |
is( $private_shelf->can_be_viewed( $patron2->{borrowernumber} ), 0, 'Private list should not be viewed by another staff member' ); |
|
|
345 |
is( $private_shelf->can_be_viewed( $patron3->{borrowernumber} ), 0, 'Private list should not be viewed by someone with no special permissions' ); |
| 318 |
|
346 |
|
| 319 |
is( $private_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete his list' ); |
347 |
is( $private_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete his list' ); |
| 320 |
is( $private_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Private list should not be deleted by someone else' ); |
348 |
is( $private_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Private list should not be deleted by another staff member' ); |
|
|
349 |
is( $private_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Private list should not be deleted by someone with no special permissions' ); |
| 321 |
|
350 |
|
| 322 |
is( $private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' ); |
351 |
is( $private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' ); |
| 323 |
is( $private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Private list should not be managed by someone else' ); |
352 |
is( $private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Private list should not be managed by another staff member' ); |
|
|
353 |
is( $private_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Private list should not be managed by someone with no special permissions' ); |
| 324 |
|
354 |
|
| 325 |
is( $private_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 0, 'The owner should not be able to add biblios to their list' ); |
355 |
is( $private_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 0, 'The owner should not be able to add biblios to their list' ); |
| 326 |
is( $private_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0, 'Private list should not be modified (add) by someone else' ); |
356 |
is( $private_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 0, 'Private list should not be modified (add) by another staff member' ); |
|
|
357 |
is( $private_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0, 'Private list should not be modified (add) by someone with no special permissions' ); |
| 327 |
|
358 |
|
| 328 |
is( $private_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 0, 'The owner should not be able to remove biblios to their list' ); |
359 |
is( $private_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 0, 'The owner should not be able to remove biblios to their list' ); |
| 329 |
is( $private_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0, 'Private list should not be modified (remove) by someone else' ); |
360 |
is( $private_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 0, 'Private list should not be modified (remove) by another staff member' ); |
|
|
361 |
is( $private_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0, 'Private list should not be modified (remove) by someone with no special permissions' ); |
| 362 |
|
| 363 |
$private_shelf->allow_change_from_owner(1); |
| 364 |
$private_shelf->allow_change_from_staff(1); |
| 365 |
$private_shelf->allow_change_from_others(0); |
| 366 |
$private_shelf->store; |
| 367 |
is( $private_shelf->can_be_viewed( $patron1->{borrowernumber} ), 1, 'The owner should be able to view his list' ); |
| 368 |
is( $private_shelf->can_be_viewed( $patron2->{borrowernumber} ), 0, 'Private list should not be viewed by another staff member' ); |
| 369 |
is( $private_shelf->can_be_viewed( $patron3->{borrowernumber} ), 0, 'Private list should not be viewed by someone with no special permissions' ); |
| 370 |
|
| 371 |
is( $private_shelf->can_be_deleted( $patron1->{borrowernumber} ), 1, 'The owner should be able to delete his list' ); |
| 372 |
is( $private_shelf->can_be_deleted( $patron2->{borrowernumber} ), 0, 'Private list should not be deleted by another staff member' ); |
| 373 |
is( $private_shelf->can_be_deleted( $patron3->{borrowernumber} ), 0, 'Private list should not be deleted by someone with no special permissions' ); |
| 330 |
|
374 |
|
|
|
375 |
is( $private_shelf->can_be_managed( $patron1->{borrowernumber} ), 1, 'The owner should be able to manage his list' ); |
| 376 |
is( $private_shelf->can_be_managed( $patron2->{borrowernumber} ), 0, 'Private list should not be managed by another staff member' ); |
| 377 |
is( $private_shelf->can_be_managed( $patron3->{borrowernumber} ), 0, 'Private list should not be managed by someone with no special permissions' ); |
| 378 |
|
| 379 |
is( $private_shelf->can_biblios_be_added( $patron1->{borrowernumber} ), 1, 'The owner should be able to add biblios to his list' ); |
| 380 |
is( $private_shelf->can_biblios_be_added( $patron2->{borrowernumber} ), 1, 'Private list could be modified (add) by another staff member # individual check done later' ); |
| 381 |
is( $private_shelf->can_biblios_be_added( $patron3->{borrowernumber} ), 0, 'Private list could be modified (add) by someone with no special permissions' ); |
| 382 |
|
| 383 |
is( $private_shelf->can_biblios_be_removed( $patron1->{borrowernumber} ), 1, 'The owner should be able to remove biblios to his list' ); |
| 384 |
is( $private_shelf->can_biblios_be_removed( $patron2->{borrowernumber} ), 1, 'Private list could be modified (remove) by another staff member # individual check done later' ); |
| 385 |
is( $private_shelf->can_biblios_be_removed( $patron3->{borrowernumber} ), 0, 'Private list could be modified (remove) by someone with no special permissions' ); |
| 331 |
|
386 |
|
| 332 |
$private_shelf->allow_change_from_owner(1); |
387 |
$private_shelf->allow_change_from_owner(1); |
| 333 |
$private_shelf->allow_change_from_others(1); |
388 |
$private_shelf->allow_change_from_others(1); |