Attachment #121591 for bug #27526

View | Details | Raw Unified | Return to bug 27526
Collapse All | Expand All




    return Koha::Items->_new_from_dbic( $items_rs );
}

sub host_items {
    my ($self) = @_;

    return Koha::Items->new->empty
      unless C4::Context->preference('EasyAnalyticalRecords');

    my $marcflavour = C4::Context->preference("marcflavour");
    my $analyticfield = '773';
    if ( $marcflavour eq 'MARC21' || $marcflavour eq 'NORMARC' ) {
        $analyticfield = '773';
    }
    elsif ( $marcflavour eq 'UNIMARC' ) {
        $analyticfield = '461';
    }
    my $marc_record = $self->metadata->record;
    my @itemnumbers;
    foreach my $field ( $marc_record->field($analyticfield) ) {
        push @itemnumbers, $field->subfield('9');
    }

    return Koha::Items->search( { itemnumber => { -in => \@itemnumbers } } );
}

=head3 itemtype

my $itemtype = $biblio->itemtype();




use Try::Tiny;

use Koha::Database;
use Koha::DateUtils qw( dt_from_string output_pref );

use C4::Context;
use C4::Circulation;

    return Koha::CoverImages->_new_from_dbic($cover_image_rs);
}

sub columns_to_str {
    my ( $self ) = @_;

    my $frameworkcode = $self->biblio->frameworkcode;
    my $tagslib = C4::Biblio::GetMarcStructure(1, $frameworkcode);
    my ( $itemtagfield, $itemtagsubfield) = C4::Biblio::GetMarcFromKohaField( "items.itemnumber" );

    my $columns_info = $self->_result->result_source->columns_info;

    my $mss = C4::Biblio::GetMarcSubfieldStructure( $frameworkcode, { unsafe => 1 } );
    my $values = {};
    for my $column ( keys %$columns_info ) {

        next if $column eq 'more_subfields_xml';

        my $value;
        if ( Koha::Object::_datetime_column_type( $columns_info->{$column}->{data_type} ) ) {
            $value = output_pref({ dateformat => 'rfc3339', dt => dt_from_string($value, 'sql')});
        } else {
            $value = $self->$column;
        }

        if ( not defined $value or $value eq "" ) {
            $values->{$column} = $value;
            next;
        }

        my $subfield =
          exists $mss->{"items.$column"}
          ? @{ $mss->{"items.$column"} }[0] # Should we deal with several subfields??
          : undef;

        $values->{$column} =
            $subfield
          ? $subfield->{authorised_value}
              ? C4::Biblio::GetAuthorisedValueDesc( $itemtagfield,
                  $subfield->{tagsubfield}, $value, '', $tagslib )
              : $value
          : $value;
    }

    my $marc_more=
      $self->more_subfields_xml
      ? MARC::Record->new_from_xml( $self->more_subfields_xml, 'UTF-8' )
      : undef;

    my $more_values;
    if ( $marc_more ) {
        my ( $field ) = $marc_more->fields;
        for my $sf ( $field->subfields ) {
            my $subfield_code = $sf->[0];
            my $value = $sf->[1];
            my $subfield = $tagslib->{$itemtagfield}->{$subfield_code};
            next unless $subfield; # We have the value but it's not mapped, data lose! No regression however.
            $value =
              $subfield->{authorised_value}
              ? C4::Biblio::GetAuthorisedValueDesc( $itemtagfield,
                $subfield->{tagsubfield}, $value, '', $tagslib )
              : $value;

            push @{$more_values->{$subfield_code}}, $value;
        }

        while ( my ( $k, $v ) = each %$more_values ) {
            $values->{$k} = join ' | ', @$v;
        }
    }

    return $values;
}

=head3 _set_found_trigger

    $self->_set_found_trigger




use Koha::Libraries;
use Koha::Patrons;
use Koha::SearchEngine::Indexer;
use List::MoreUtils qw/any/;
use C4::Search;
use Storable qw(thaw freeze);
use URI::Escape;

use MARC::File::XML;
use URI::Escape;
use MIME::Base64 qw(decode_base64url encode_base64url);
use List::Util qw( first );
use List::MoreUtils qw( any uniq );

our $dbh = C4::Context->dbh;

sub find_value {
    my ($tagfield,$insubfield,$record) = @_;
    my $result;
    my $indicator;
    foreach my $field ($record->field($tagfield)) {
        my @subfields = $field->subfields();
        foreach my $subfield (@subfields) {
            if (@$subfield[0] eq $insubfield) {
                $result .= @$subfield[1];
                $indicator = $field->indicator(1).$field->indicator(2);
            }
        }
    }
    return($indicator,$result);
}

sub get_item_from_barcode {
    my ($barcode)=@_;
    my $dbh=C4::Context->dbh;
    my $result;
    my $rq=$dbh->prepare("SELECT itemnumber from items where items.barcode=?");
    $rq->execute($barcode);
    ($result)=$rq->fetchrow;
    return($result);
}

# NOTE: This code is subject to change in the future with the implemenation of ajax based autobarcode code
# NOTE: 'incremental' is the ONLY autoBarcode option available to those not using javascript
sub _increment_barcode {
    my ($record, $frameworkcode) = @_;
    my ($tagfield,$tagsubfield) = &GetMarcFromKohaField( "items.barcode" );
    unless ($record->field($tagfield)->subfield($tagsubfield)) {
        my $sth_barcode = $dbh->prepare("select max(abs(barcode)) from items");
        $sth_barcode->execute;
        my ($newbarcode) = $sth_barcode->fetchrow;
        $newbarcode++;
        # OK, we have the new barcode, now create the entry in MARC record
        my $fieldItem = $record->field($tagfield);
        $record->delete_field($fieldItem);
        $fieldItem->add_subfields($tagsubfield => $newbarcode);
        $record->insert_fields_ordered($fieldItem);
    }
    return $record;
}


sub generate_subfield_form {
        my ($tag, $subfieldtag, $value, $tagslib,$subfieldlib, $branches, $biblionumber, $temp, $subfields, $i, $restrictededition, $item) = @_;
  
        my $frameworkcode = &GetFrameworkCode($biblionumber);

        $item //= {};

        my %subfield_data;
        my $dbh = C4::Context->dbh;
        

            # builds list, depending on authorised value...
            if ( $subfieldlib->{authorised_value} eq "LOST" ) {
                my $ClaimReturnedLostValue = C4::Context->preference('ClaimReturnedLostValue');
                my $item_is_return_claim = $ClaimReturnedLostValue && exists $item->{itemlost} && $ClaimReturnedLostValue eq $item->{itemlost};
                $subfield_data{IS_RETURN_CLAIM} = $item_is_return_claim;

                $subfield_data{IS_LOST_AV} = 1;

                item_style => 1,
            });
            my $pars=  { dbh => $dbh, record => $temp, tagslib =>$tagslib,
                id => $subfield_data{id}, tabloop => $subfields };
            $plugin->build( $pars );
            if( !$plugin->errstr ) {
                my $class= 'buttonDot'. ( $plugin->noclick? ' disabled': '' );

        return \%subfield_data;
}

# Removes some subfields when prefilling items
# This function will remove any subfield that is not in the SubfieldsToUseWhenPrefill syspref
sub removeFieldsForPrefill {

    my $item = shift;

    # Getting item tag
    my ($tag, $subtag) = GetMarcFromKohaField( "items.barcode" );

    # Getting list of subfields to keep
    my $subfieldsToUseWhenPrefill = C4::Context->preference('SubfieldsToUseWhenPrefill');

    # Removing subfields that are not in the syspref
    if ($tag && $subfieldsToUseWhenPrefill) {
        my $field = $item->field($tag);
        my @subfieldsToUse= split(/ /,$subfieldsToUseWhenPrefill);
        foreach my $subfield ($field->subfields()) {
            if (!grep { $subfield->[0] eq $_ } @subfieldsToUse) {
                $field->delete_subfield(code => $subfield->[0]);
            }

        }
    }

    return $item;

}

my $input        = CGI->new;
my $error        = $input->param('error');


    $itemnumber = $input->param('itemnumber');
}

my $biblio = Koha::Biblios->find($biblionumber);

my $op           = $input->param('op') || q{};
my $hostitemnumber = $input->param('hostitemnumber');
my $marcflavour  = C4::Context->preference("marcflavour");

my $fa_stickyduedate      = $input->param('stickyduedate');
my $fa_duedatespec        = $input->param('duedatespec');

our $frameworkcode = &GetFrameworkCode($biblionumber);

# Defining which userflag is needing according to the framework currently used
my $userflags;

# In case user has fast cataloging permission (and we're in fast cataloging), editing is not restricted
$restrictededition = 0 if ($restrictededition != 0 && $frameworkcode eq 'FA' && haspermission($uid, {'editcatalogue' => 'fast_cataloging'}));

our $tagslib = &GetMarcStructure(1,$frameworkcode);
my $record = GetMarcBiblio({ biblionumber => $biblionumber });

output_and_exit_if_error( $input, $cookie, $template,
    { module => 'cataloguing', record => $record } );

my $oldrecord = TransformMarcToKoha($record);
my $current_item;
my $nextop="additem";
my @errors; # store errors found while checking data BEFORE saving item.

# Getting last created item cookie
my $prefillitem = C4::Context->preference('PrefillItem');
my $item_from_cookie;
my $cookieitemrecord;
if ($prefillitem) {
    my $lastitemcookie = $input->cookie('LastCreatedItem');
    if ($lastitemcookie) {
        $lastitemcookie = decode_base64url($lastitemcookie);
        eval {
            if ( thaw($lastitemcookie) ) {
                $item_from_cookie = thaw($lastitemcookie);
                $cookieitemrecord = removeFieldsForPrefill($cookieitemrecord);
            }
        };
        if ($@) {

}

#-------------------------------------------------------------------------------
my $current_item;
if ($op eq "additem") {

    my $add_submit                 = $input->param('add_submit');
    my $add_duplicate_submit       = $input->param('add_duplicate_submit');
    my $add_multiple_copies_submit = $input->param('add_multiple_copies_submit');
    my $number_of_copies           = $input->param('number_of_copies');

    # This is a bit tricky : if there is a cookie for the last created item and
    # we just added an item, the cookie value is not correct yet (it will be updated
    # next page). To prevent the form from being filled with outdated values, we
    # force the use of "add and duplicate" feature, so the form will be filled with
    # correct values.
    $add_duplicate_submit = 1 if ($prefillitem);
    $justaddeditem = 1;

    my @columns = Koha::Items->columns;
    my $biblio = Koha::Biblios->find($biblionumber);
    my $item = Koha::Item->new;
    $item->biblionumber($biblio->biblionumber);
    for my $c ( @columns ) {

            }
            $item->more_subfields_xml(undef);
        } else {
            my @v = $input->multi_param("items.".$c);
            next unless @v;
            $item->$c(join ' | ', uniq @v);
        }
    }


    }

    # If we have to add or add & duplicate, we add the item
    if ( $add_submit || $prefillitem) {

        # check for item barcode # being unique
        if ( Koha::Items->search({ barcode => $item->barcode })->count ) {
            # if barcode exists, don't create, but report The problem.
            push @errors, "barcode_not_unique";

            $current_item = $item->unblessed; # Restore edit form for the same item
        }
        else {
            $item->store->discard_changes;

            # This is a bit tricky : if there is a cookie for the last created item and
            # we just added an item, the cookie value is not correct yet (it will be updated
            # next page). To prevent the form from being filled with outdated values, we
            # force the use of "add and duplicate" feature, so the form will be filled with
            # correct values.

            # FIXME This need to be rewritten, we must store $item->unblessed instead
            # Pushing the last created item cookie back
            if ( $prefillitem ) {
                $item_from_cookie = $input->cookie(
                    -name => 'LastCreatedItem',
                    # We encode_base64url the whole freezed structure so we're sure we won't have any encoding problems
                    -value   => encode_base64url( freeze( { %{$item->unblessed}, itemnumber => undef } ) ),
                    -HttpOnly => 1,
                    -expires => ''
                );

                $cookie = [ $cookie, $item_from_cookie ];
            }

        }
        $nextop = "additem";


        # FIXME reset item to the item we were editing
        #if ($exist_itemnumber) {

        #    $itemrecord = $record;
        #}
        $current_item = $item->unblessed;
    }

    # If we have to add & duplicate
    if ($prefillitem) {
        if (C4::Context->preference('autoBarcode') eq 'incremental') {
            my ( $barcode ) = C4::Barcodes::ValueBuilder::incremental::get_barcode;
            $current_item->{barcode} = $barcode;

            # we have to clear the barcode field in the duplicate item record to make way for the new one generated by the javascript plugin
            $current_item->{barcode} = undef; # FIXME or delete?
        }
        # FIXME This subroutine needs to be adjusted
        # We want to pass $item
        # $itemrecord = removeFieldsForPrefill($itemrecord) if ($prefillitem);
    }

    # If we have to add multiple copies
    if ($add_multiple_copies_submit) {

        $current_item = $item->unblessed;

        my $copynumber = $current_item->{copynumber};
        my $oldbarcode = $current_item->{barcode};


        if ( $oldbarcode && !$testbarcode ) {

            push @errors, "no_next_barcode";
            $itemrecord = $record;

        }
        else {

                if ( !$exist_itemnumber ) {
                    delete $current_item->{itemnumber};
                    $current_item = Koha::Item->new($current_item)->store(
                        { skip_record_index => 1 } );
                    $current_item->discard_changes; # Cannot chain discard_changes
                    $current_item = $current_item->unblessed;
                    set_item_default_location($current_item->{itemnumber});

# We count the item only if it was really added

} elsif ($op eq "edititem") {
#-------------------------------------------------------------------------------
# retrieve item if exist => then, it's a modif
    $current_item = Koha::Items->find($itemnumber)->unblessed;
    # FIXME Handle non existent item
    $nextop = "saveitem";
#-------------------------------------------------------------------------------
} elsif ($op eq "dupeitem") {
#-------------------------------------------------------------------------------
# retrieve item if exist => then, it's a modif
    my $item = Koha::Items->find($itemnumber);
    # FIXME Handle non existent item
    if (C4::Context->preference('autoBarcode') eq 'incremental') {
        my ( $barcode ) = C4::Barcodes::ValueBuilder::incremental::get_barcode;
        $item->barcode($barcode);
    }
    else {
        $item->barcode(undef); # Don't save it!
        my ($tagfield,$tagsubfield) = &GetMarcFromKohaField( "items.barcode" );
        my $fieldItem = $itemrecord->field($tagfield);
        $itemrecord->delete_field($fieldItem);
        $fieldItem->delete_subfields($tagsubfield);
        $itemrecord->insert_fields_ordered($fieldItem);
    }

    #check for hidden subfield and remove them for the duplicated item
    foreach my $field ($itemrecord->fields()){
        my $tag = $field->{_tag};
        foreach my $subfield ($field->subfields()){
            my $subfieldtag = $subfield->[0];
            if ($tagslib->{$tag}->{$subfieldtag}->{'tab'} ne "10"
            ||  abs($tagslib->{$tag}->{$subfieldtag}->{hidden})>4 ){
                my $fieldItem = $itemrecord->field($tag);
                $itemrecord->delete_field($fieldItem);
                $fieldItem->delete_subfields($subfieldtag);
                $itemrecord->insert_fields_ordered($fieldItem);
            }
        }
    }

    $itemrecord = removeFieldsForPrefill($itemrecord) if ($prefillitem);
    $nextop = "additem";
#-------------------------------------------------------------------------------
} elsif ($op eq "delitem") {

            }
            $item->more_subfields_xml(undef);
        } else {
            my @v = $input->multi_param("items.".$c);
            next unless @v;
            $item->$c(join ' | ', uniq @v);
        }
    }


    if ( Koha::Items->search({ barcode => $item->barcode, itemnumber => { '!=' => $item->itemnumber } })->count ) {
        # FIXME We shouldn't need that, ->store would explode as there is a unique constraint on items.barcode
        push @errors,"barcode_not_unique";
        $current_item = $item->unblessed; # Restore edit form for the same item
    } else {
        my $newitemlost = $item->itemlost;
        if ( $newitemlost && $newitemlost ge '1' && !$olditemlost ) {

#-------------------------------------------------------------------------------

# now, build existiing item list
my $temp = GetMarcBiblio({ biblionumber => $biblionumber });
#my @fields = $record->fields();


my @items;
for my $item ( $biblio->items->as_list, $biblio->host_items->as_list ) {
    push @items, $item->columns_to_str;
my (  $itemtagfield,   $itemtagsubfield) = &GetMarcFromKohaField( "items.itemnumber" );
my ($branchtagfield, $branchtagsubfield) = &GetMarcFromKohaField( "items.homebranch" );
C4::Biblio::EmbedItemsInMarcBiblio({
    marc_record  => $temp,
    biblionumber => $biblionumber });
my @fields = $temp->fields();


my @hostitemnumbers;
if ( C4::Context->preference('EasyAnalyticalRecords') ) {
    my $analyticfield = '773';
    if ($marcflavour  eq 'MARC21' || $marcflavour eq 'NORMARC') {
        $analyticfield = '773';
    } elsif ($marcflavour eq 'UNIMARC') {
        $analyticfield = '461';
    }
    foreach my $hostfield ($temp->field($analyticfield)){
        my $hostbiblionumber = $hostfield->subfield('0');
        if ($hostbiblionumber){
            my $hostrecord = GetMarcBiblio({
                biblionumber => $hostbiblionumber,
                embed_items  => 1 });
            if ($hostrecord) {
                my ($itemfield, undef) = GetMarcFromKohaField( 'items.itemnumber' );
                foreach my $hostitem ($hostrecord->field($itemfield)){
                    if ($hostitem->subfield('9') eq $hostfield->subfield('9')){
                        push (@fields, $hostitem);
                        push (@hostitemnumbers, $hostfield->subfield('9'));
                    }
                }
            }
        }
    }
}

my @witness_attributes = uniq map {
    my $item = $_;
    map { defined $item->{$_} && $item->{$_} ne "" ? $_ : () } keys %$item
} @items;
    my %this_row;
    # loop through each subfield
    my $i = 0;
    foreach my $subfield (@subf){
        my $subfieldcode = $subfield->[0];
        my $subfieldvalue= $subfield->[1];

        next if ($tagslib->{$field->tag()}->{$subfieldcode}->{tab} ne 10 
                && ($field->tag() ne $itemtagfield 
                && $subfieldcode   ne $itemtagsubfield));
        $witness{$subfieldcode} = $tagslib->{$field->tag()}->{$subfieldcode}->{lib} if ($tagslib->{$field->tag()}->{$subfieldcode}->{tab}  eq 10);
		if ($tagslib->{$field->tag()}->{$subfieldcode}->{tab}  eq 10) {
		    $this_row{$subfieldcode} .= " | " if($this_row{$subfieldcode});
        	$this_row{$subfieldcode} .= GetAuthorisedValueDesc( $field->tag(),
                        $subfieldcode, $subfieldvalue, '', $tagslib) 
						|| $subfieldvalue;
        }

our ( $itemtagfield, $itemtagsubfield ) = &GetMarcFromKohaField("items.itemnumber");
            #verifying rights
            my $userenv = C4::Context->userenv();
            unless (C4::Context->IsSuperLibrarian() or (($userenv->{'branch'} eq $subfieldvalue))){
                $this_row{'nomod'} = 1;
            }
        }
        $this_row{itemnumber} = $subfieldvalue if ($field->tag() eq $itemtagfield && $subfieldcode eq $itemtagsubfield);

        if ( C4::Context->preference('EasyAnalyticalRecords') ) {
            foreach my $hostitemnumber (@hostitemnumbers) {
                my $item = Koha::Items->find( $hostitemnumber );
                if ($this_row{itemnumber} eq $hostitemnumber) {
                    $this_row{hostitemflag} = 1;
                    $this_row{hostbiblionumber}= $item->biblio->biblionumber;
                    last;
                }
            }
        }
    }
    if (%this_row) {
        push(@big_array, \%this_row);
    }
}

my $subfieldcode_attribute_mappings;
for my $subfield_code ( keys %{ $tagslib->{$itemtagfield} } ) {

# now, construct template !
# First, the existing items for display
my @item_value_loop;
my @header_value_loop;
for my $row ( @big_array ) {
    my %row_data;
    my @item_fields;
    foreach my $key (sort keys %witness){
        my $item_field;
        if ( $row->{$key} ){
            $item_field->{field} = $row->{$key};
        } else {
            $item_field->{field} = '';
        }

    my $subfield = $tagslib->{$itemtagfield}->{$subfield_code};
            qw( items.dateaccessioned items.onloan items.datelastseen items.datelastborrowed items.replacementpricedate )
          )
        {
            my ( undef, $subfield ) = GetMarcFromKohaField($kohafield);
            next unless $key eq $subfield;
            $item_field->{datatype} = 'date';
        }

    next if IsMarcStructureInternal( $subfield );
    next unless $subfield->{tab} eq 10; # Is this really needed?

    my $attribute;
    if ( $subfield->{kohafield} ) {
        ( $attribute = $subfield->{kohafield} ) =~ s|^items\.||;
    } else {
        $attribute = $subfield_code; # It's in more_subfields_xml
    }
    next unless grep { $attribute eq $_ } @witness_attributes;
    $subfieldcode_attribute_mappings->{$subfield_code} = $attribute;
    #reporting this_row values
    $row_data{'nomod'} = $row->{'nomod'};
    $row_data{'hostitemflag'} = $row->{'hostitemflag'};
    $row_data{'hostbiblionumber'} = $row->{'hostbiblionumber'};
#	$row_data{'countanalytics'} = $row->{'countanalytics'};
    push(@item_value_loop,\%row_data);
}
foreach my $subfield_code (sort keys(%witness)) {
    my %header_value;
    $header_value{header_value} = $witness{$subfield_code};

    my $subfieldlib = $tagslib->{$itemtagfield}->{$subfield_code};
    my $kohafield = $subfieldlib->{kohafield};
    if ( $kohafield && $kohafield =~ /items.(.+)/ ) {
        $header_value{column_name} = $1;
    }

my @header_value_loop = map {
    {
        header_value  => $tagslib->{$itemtagfield}->{$_}->{lib},
        attribute     => $subfieldcode_attribute_mappings->{$_},
        subfield_code => $_,
    }
} sort keys %$subfieldcode_attribute_mappings;

# now, build the item form for entering a new item
my @loop_data =();
my $i=0;

my $branch = $input->param('branch') || C4::Context->userenv->{branch};
my $libraries = Koha::Libraries->search({}, { order_by => ['branchname'] })->unblessed;# build once ahead of time, instead of multiple times later.
for my $library ( @$libraries ) {
    $library->{selected} = 1 if $library->{branchcode} eq $branch
}

my $item = Koha::Items->find($itemnumber);

# Using last created item if it exists
$current_item = $item_from_cookie
  if $item_from_cookie
  && $prefillitem
  && $op ne "additem"
  && $op ne "edititem";

my @subfields_to_prefill = split ' ', C4::Context->preference('SubfieldsToUseWhenPrefill');
            my $value       = $subfield->[1];
            my $subfieldlib = $tagslib->{$tag}->{$subfieldtag};

if ( $current_item->{more_subfields_xml} ) {
    $current_item->{marc_more_subfields_xml} = MARC::Record->new_from_xml($current_item->{more_subfields_xml}, 'UTF-8');
}

# We generate form, and fill with values if defined
my $temp = GetMarcBiblio({ biblionumber => $biblionumber });
my $i = 0;
my @subfields;
foreach my $tag ( keys %{$tagslib} ) {
    foreach my $subtag ( keys %{ $tagslib->{$tag} } ) {

        my $subfield = $tagslib->{$tag}{$subtag};

        next if IsMarcStructureInternal( $subfield );
        next if ( $subfield->{tab} ne "10" );

        my @values = ();

        my $subfield_data;

        # If we are not adding a new item
        # OR
        # If the subfield must be prefilled with last catalogued item
        if (
            $nextop ne 'additem'
            || (
                !$prefillitem
                || ( $prefillitem && grep { $_ eq $subtag }
                    @subfields_to_prefill )
            )
          )
        {
            my $kohafield = $subfield->{kohafield};
            if ($kohafield) {

                # This is a mapped field
                ( my $attribute = $kohafield ) =~ s|^items\.||;
                push @values, $subfield->{repeatable}
                    ? split '\s\|\s', $current_item->{$attribute}
                    : $current_item->{$attribute}
                  if defined $current_item->{$attribute};
            } else {
                # Not mapped, picked the values from more_subfields_xml's MARC
                my $marc_more = $current_item->{marc_more_subfields_xml};
                if ( $marc_more ) {
                    for my $f ( $marc_more->fields($tag) ) {
                        push @values, $f->subfield($subtag);
                    }

                }
            }
        }

# Using last created item if it exists

        @values = ('') unless @values;

        for my $value (@values) {
            my $subfield_data = generate_subfield_form(
                $tag,                        $subtag,
                $value,                      $tagslib,
                $subfield,                   $libraries,
                $biblionumber,               $temp,
                \@subfields,                 $i,
                $restrictededition,          $current_item,
            );
            push @subfields, $subfield_data;
            my $subfield_data = generate_subfield_form($tag, $subtag, $value, $tagslib, $tagslib->{$tag}->{$subtag}, $libraries, $biblionumber, $temp, \@loop_data, $i, $restrictededition, $item);
            push (@loop_data, $subfield_data);
            $i++;
        }
    }
}
@subfields = sort { $a->{display_order} <=> $b->{display_order} || $a->{subfield} cmp $b->{subfield} } @subfields;

# what's the next op ? it's what we are not in : an add if we're editing, otherwise, and edit.
$template->param(
    biblionumber => $biblionumber,
    title        => $oldrecord->{title},
    author       => $oldrecord->{author},
    items        => \@items,
    item_header_loop => \@header_value_loop,
    subfields    => \@subfields,
    itemnumber       => $itemnumber,
    barcode          => $current_item->{barcode},
    itemtagfield     => $itemtagfield,
    itemtagsubfield  => $itemtagsubfield,
    op      => $nextop,




[% USE raw %]
[% USE Asset %]
[% USE Koha %]
[% USE Branches %]
[% USE KohaDates %]
[% USE TablesSettings %]
[% INCLUDE 'doc-head-open.inc' %]

[% IF last_item_for_hold %]<div class="dialog alert"><strong>Cannot delete</strong>: Last item for bibliographic record with biblio-level hold on it.</div>[% END %]

<div id="cataloguing_additem_itemlist">
    [% IF items %]
        [% SET date_fields = [ 'dateaccessioned', 'onloan', 'datelastseen', 'datelastborrowed', 'replacementpricedate' ] %]
        <div>
        <table id="itemst">

            </tr>
          </thead>
          <tbody>
                [% FOREACH item IN items %]
                    [% SET can_be_edited = ! ( Koha.Preference('IndependentBranches') && ! logged_in_user && item.homebranch != Branches.GetLoggedInBranchcode() ) %]
                    [% IF item.itemnumber == itemnumber%]
                        [% UNLESS can_be_edited %]
                           <tr id="row[% item.itemnumber | html %]" class="active">
                        [% ELSE %]
                            <tr id="row[% item.itemnumber | html %]" class="active editable">
                        [% END %]
                    [% ELSE %]
                        [% UNLESS can_be_edited %]
                           <tr id="row[% item.itemnumber | html %]">
                        [% ELSE %]
                            <tr id="row[% item.itemnumber | html %]" class="editable">
                        [% END %]
                    [% END %]
                    [% UNLESS can_be_edited %]
                      <td>&nbsp;</td>
                    [% ELSE %]
                      <td>
                          <div class="btn-group dropup">
                          <a class="btn btn-default btn-xs dropdown-toggle" id="itemactions[% item.itemnumber | html %]" role="button" data-toggle="dropdown" href="#">
                              Actions <b class="caret"></b>
                          </a>
                          <ul class="dropdown-menu" role="menu" aria-labelledby="itemactions[% item.itemnumber | html %]">

                        [% IF item.biblionumber != biblionumber %] [%# Host item %]
                              <li><a href="additem.pl?op=edititem&amp;biblionumber=[% item.biblionumber | uri %]&amp;itemnumber=[% item.itemnumber | uri %]#edititem">Edit in host</a> &nbsp; <a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delinkitem&amp;biblionumber=[% biblionumber | html %]&amp;hostitemnumber=[% item.itemnumber | html %]&amp;searchid=[% searchid | html %]">Delink</a></li>
                        [% ELSE %]
                              <li><a href="additem.pl?op=edititem&amp;biblionumber=[% biblionumber | uri %]&amp;itemnumber=[% item.itemnumber | uri %]&amp;searchid=[% searchid | uri %]#edititem">Edit</a></li>
                              <li><a href="additem.pl?op=dupeitem&amp;biblionumber=[% biblionumber | uri %]&amp;itemnumber=[% item.itemnumber | uri %]&amp;searchid=[% searchid | uri %]#additema">Duplicate</a></li>
                              <li class="print_label"><a href="/cgi-bin/koha/labels/label-edit-batch.pl?op=add&amp;number_type=itemnumber&amp;number_list=[% item.itemnumber | uri %]" target="_blank" >Print label</a></li>
                              <li><a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delitem&amp;biblionumber=[% item.biblionumber | html %]&amp;itemnumber=[% item.itemnumber | html %]&amp;searchid=[% searchid | html %]" onclick="return confirm_deletion();">Delete</a></li>
                              <li><a href="/cgi-bin/koha/catalogue/search.pl?idx=hi&amp;q=% item_loo.itemnumber %]">View analytics</a></li>
                          [% ELSE %]
                              <li><a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delitem&amp;biblionumber=[% biblionumber | html %]&amp;itemnumber=[% item_loo.itemnumber | html %]&amp;searchid=[% searchid | html %]" onclick="return confirm_deletion();">Delete</a></li>
                          [% END %]
                        [% END %]
                            [% IF ( OPACBaseURL ) %]
                                <li class="view-in-opac"><a target="_blank" href="[% Koha.Preference('OPACBaseURL') | url %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% item.biblionumber | uri %]">OPAC view</a></li>
                            [% END %]
                          </ul>
                          </div>
                      </td>
                    [% END %]
                [% FOREACH header IN item_header_loop %]
                    [% SET attribute = header.attribute %]
                    [% IF header.attribute AND date_fields.grep(attribute).size %]
                        <td data-order="[% item.$attribute | html %]">[% item.$attribute | $KohaDates %]</td>
                    [% ELSE %]
                        <td>[% item.$attribute | html %]</td>
                    [% END %]
                [% END %]
                </tr>

    [% END %]
	<fieldset class="rows">
	<ol>
        [% FOREACH subfield IN subfields %]

                [% IF subfield.kohafield == 'items.more_subfields_xml' %]
                    [% SET kohafield = 'items.more_subfields_xml_' _ subfield.subfield %]
                [% ELSE %]
                    [% SET kohafield = subfield.kohafield %]
                [% END %]

               <li><div class="subfield_line" style="[% subfield.visibility | html %]" id="subfield[% subfield.tag | html %][% subfield.subfield | html %][% subfield.random | html %]">
                [% IF ( subfield.mandatory ) %]
               <label class="required">[% subfield.subfield | html %] - [% subfield.marc_lib | $raw %]</label>
               [% ELSE %]
               <label>[% subfield.subfield | html %] - [% subfield.marc_lib | $raw %]</label>
               [% END %]

                [% SET mv = subfield.marc_value %]
                [% IF ( mv.type == 'hidden' ) %]
                    <input type="hidden" id="[%- mv.id | html -%]" name="[% kohafield %]" class="input_marceditor" size="50" maxlength="[%- mv.maxlength | html -%]" value="[%- mv.value | html -%]">
                [% ELSIF ( mv.type == 'select' ) %]
                    [% IF ( mv.readonly || subfield.IS_RETURN_CLAIM ) %]
                        <select name="[% kohafield %]" id="[%- mv.id | html -%]" class="input_marceditor" readonly="readonly" disabled="disabled">
                    [% ELSE %]
                        <select name="[% kohafield %]" id="[%- mv.id | html -%]" class="input_marceditor" data-category="[% mv.category | html %]">

                        [% IF aval == mv.default %]
                        <option value="[%- aval | html -%]" selected="selected">[%- mv.labels.$aval | html -%]</option>
                        [% ELSE %]
                            [% IF subfield.IS_LOST_AV && Koha.Preference("ClaimReturnedLostValue") && aval == Koha.Preference("ClaimReturnedLostValue") %]
                                <option disabled="disabled" value="[%- aval | html -%]" title="Return claims must be processed from the patron details page">[%- mv.labels.$aval | html -%]</option>
                            [%  ELSE %]
                                <option value="[%- aval | html -%]">[%- mv.labels.$aval | html -%]</option>

                    [% END %]
                [% END %]

                [% IF subfield.kohafield == 'items.more_subfields_xml' %]
                    <input type="hidden" name="items.more_subfields_xml" value="[% subfield.subfield %]" />
                [% END %]
                <input type="hidden" name="tag"       value="[% subfield.tag | html %]" />
                <input type="hidden" name="subfield"  value="[% subfield.subfield | html %]" />
                <input type="hidden" name="mandatory" value="[% subfield.mandatory | html %]" />
                <input type="hidden" name="important" value="[% subfield.important | html %]" />
                [% IF ( subfield.repeatable ) %]
                    <a href="#" class="buttonPlus" onclick="CloneItemSubfield(this.parentNode.parentNode); return false;">
                        <img src="[% interface | html %]/[% theme | html %]/img/clone-subfield.png" alt="Clone" title="Clone this subfield" />
                    </a>
                [% END %]
                [% IF ( subfield.mandatory ) %] <span class="required">Required</span>
                [% ELSIF ( subfield.important ) %] <span class="important">Important</span>
                [% END %]
            </div></li>
        [% END %]
- 

Return to bug 27526

Lines 421-426 sub items { Link Here

(-)a/Koha/Biblio.pm (+23 lines)
421	return Koha::Items->_new_from_dbic( $items_rs );	421	return Koha::Items->_new_from_dbic( $items_rs );
422	}	422	}
423		423
		424	sub host_items {
		425	my ($self) = @_;
		426
		427	return Koha::Items->new->empty
		428	unless C4::Context->preference('EasyAnalyticalRecords');
		429
		430	my $marcflavour = C4::Context->preference("marcflavour");
		431	my $analyticfield = '773';
		432	if ( $marcflavour eq 'MARC21' \|\| $marcflavour eq 'NORMARC' ) {
		433	$analyticfield = '773';
		434	}
		435	elsif ( $marcflavour eq 'UNIMARC' ) {
		436	$analyticfield = '461';
		437	}
		438	my $marc_record = $self->metadata->record;
		439	my @itemnumbers;
		440	foreach my $field ( $marc_record->field($analyticfield) ) {
		441	push @itemnumbers, $field->subfield('9');
		442	}
		443
		444	return Koha::Items->search( { itemnumber => { -in => \@itemnumbers } } );
		445	}
		446
424	=head3 itemtype	447	=head3 itemtype
425		448
426	my $itemtype = $biblio->itemtype();	449	my $itemtype = $biblio->itemtype();

Lines 25-31 use Data::Dumper; Link Here

(-)a/Koha/Item.pm (-1 / +72 lines)
25	use Try::Tiny;	25	use Try::Tiny;
26		26
27	use Koha::Database;	27	use Koha::Database;
28	use Koha::DateUtils qw( dt_from_string );	28	use Koha::DateUtils qw( dt_from_string output_pref );
29		29
30	use C4::Context;	30	use C4::Context;
31	use C4::Circulation;	31	use C4::Circulation;
Lines 941-946 sub cover_images { Link Here
941	return Koha::CoverImages->_new_from_dbic($cover_image_rs);	941	return Koha::CoverImages->_new_from_dbic($cover_image_rs);
942	}	942	}
943		943
		944	sub columns_to_str {
		945	my ( $self ) = @_;
		946
		947	my $frameworkcode = $self->biblio->frameworkcode;
		948	my $tagslib = C4::Biblio::GetMarcStructure(1, $frameworkcode);
		949	my ( $itemtagfield, $itemtagsubfield) = C4::Biblio::GetMarcFromKohaField( "items.itemnumber" );
		950
		951	my $columns_info = $self->_result->result_source->columns_info;
		952
		953	my $mss = C4::Biblio::GetMarcSubfieldStructure( $frameworkcode, { unsafe => 1 } );
		954	my $values = {};
		955	for my $column ( keys %$columns_info ) {
		956
		957	next if $column eq 'more_subfields_xml';
		958
		959	my $value;
		960	if ( Koha::Object::_datetime_column_type( $columns_info->{$column}->{data_type} ) ) {
		961	$value = output_pref({ dateformat => 'rfc3339', dt => dt_from_string($value, 'sql')});
		962	} else {
		963	$value = $self->$column;
		964	}
		965
		966	if ( not defined $value or $value eq "" ) {
		967	$values->{$column} = $value;
		968	next;
		969	}
		970
		971	my $subfield =
		972	exists $mss->{"items.$column"}
		973	? @{ $mss->{"items.$column"} }[0] # Should we deal with several subfields??
		974	: undef;
		975
		976	$values->{$column} =
		977	$subfield
		978	? $subfield->{authorised_value}
		979	? C4::Biblio::GetAuthorisedValueDesc( $itemtagfield,
		980	$subfield->{tagsubfield}, $value, '', $tagslib )
		981	: $value
		982	: $value;
		983	}
		984
		985	my $marc_more=
		986	$self->more_subfields_xml
		987	? MARC::Record->new_from_xml( $self->more_subfields_xml, 'UTF-8' )
		988	: undef;
		989
		990	my $more_values;
		991	if ( $marc_more ) {
		992	my ( $field ) = $marc_more->fields;
		993	for my $sf ( $field->subfields ) {
		994	my $subfield_code = $sf->[0];
		995	my $value = $sf->[1];
		996	my $subfield = $tagslib->{$itemtagfield}->{$subfield_code};
		997	next unless $subfield; # We have the value but it's not mapped, data lose! No regression however.
		998	$value =
		999	$subfield->{authorised_value}
		1000	? C4::Biblio::GetAuthorisedValueDesc( $itemtagfield,
		1001	$subfield->{tagsubfield}, $value, '', $tagslib )
		1002	: $value;
		1003
		1004	push @{$more_values->{$subfield_code}}, $value;
		1005	}
		1006
		1007	while ( my ( $k, $v ) = each %$more_values ) {
1008	$values->{$k} = join ' \| ', @$v;
1009	}
1010	}
1011
1012	return $values;
1013	}
1014
944	=head3 _set_found_trigger	1015	=head3 _set_found_trigger
945		1016
946	$self->_set_found_trigger	1017	$self->_set_found_trigger

Lines 1-6 Link Here

(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt (-48 / +46 lines)
1	[% USE raw %]	1	[% USE raw %]
2	[% USE Asset %]	2	[% USE Asset %]
3	[% USE Koha %]	3	[% USE Koha %]
		4	[% USE Branches %]
4	[% USE KohaDates %]	5	[% USE KohaDates %]
5	[% USE TablesSettings %]	6	[% USE TablesSettings %]
6	[% INCLUDE 'doc-head-open.inc' %]	7	[% INCLUDE 'doc-head-open.inc' %]
Lines 59-65 Link Here
59	[% IF last_item_for_hold %]<div class="dialog alert"><strong>Cannot delete</strong>: Last item for bibliographic record with biblio-level hold on it.</div>[% END %]	60	[% IF last_item_for_hold %]<div class="dialog alert"><strong>Cannot delete</strong>: Last item for bibliographic record with biblio-level hold on it.</div>[% END %]
60		61
61	<div id="cataloguing_additem_itemlist">	62	<div id="cataloguing_additem_itemlist">
62	[% IF ( item_loop ) %]	63	[% IF items %]
63	[% SET date_fields = [ 'dateaccessioned', 'onloan', 'datelastseen', 'datelastborrowed', 'replacementpricedate' ] %]	64	[% SET date_fields = [ 'dateaccessioned', 'onloan', 'datelastseen', 'datelastborrowed', 'replacementpricedate' ] %]
64	<div>	65	<div>
65	<table id="itemst">	66	<table id="itemst">
Lines 78-131 Link Here
78	</tr>	79	</tr>
79	</thead>	80	</thead>
80	<tbody>	81	<tbody>
81	[% FOREACH item_loo IN item_loop %]	82	[% FOREACH item IN items %]
82	[% IF ( item_loo.itemnumber == itemnumber) %]	83	[% SET can_be_edited = ! ( Koha.Preference('IndependentBranches') && ! logged_in_user && item.homebranch != Branches.GetLoggedInBranchcode() ) %]
83	[% IF item_loo.nomod %]	84	[% IF item.itemnumber == itemnumber%]
84	<tr id="row[% item_loo.itemnumber \| html %]" class="active">	85	[% UNLESS can_be_edited %]
		86	<tr id="row[% item.itemnumber \| html %]" class="active">
85	[% ELSE %]	87	[% ELSE %]
86	<tr id="row[% item_loo.itemnumber \| html %]" class="active editable">	88	<tr id="row[% item.itemnumber \| html %]" class="active editable">
87	[% END %]	89	[% END %]
88	[% ELSE %]	90	[% ELSE %]
89	[% IF item_loo.nomod %]	91	[% UNLESS can_be_edited %]
90	<tr id="row[% item_loo.itemnumber \| html %]">	92	<tr id="row[% item.itemnumber \| html %]">
91	[% ELSE %]	93	[% ELSE %]
92	<tr id="row[% item_loo.itemnumber \| html %]" class="editable">	94	<tr id="row[% item.itemnumber \| html %]" class="editable">
93	[% END %]	95	[% END %]
94	[% END %]	96	[% END %]
95	[% IF ( item_loo.nomod ) %]	97	[% UNLESS can_be_edited %]
96	<td> </td>	98	<td> </td>
97	[% ELSE %]	99	[% ELSE %]
98	<td>	100	<td>
99	<div class="btn-group dropup">	101	<div class="btn-group dropup">
100	<a class="btn btn-default btn-xs dropdown-toggle" id="itemactions[% item_loo.itemnumber \| html %]" role="button" data-toggle="dropdown" href="#">	102	<a class="btn btn-default btn-xs dropdown-toggle" id="itemactions[% item.itemnumber \| html %]" role="button" data-toggle="dropdown" href="#">
101	Actions <b class="caret"></b>	103	Actions <b class="caret"></b>
102	</a>	104	</a>
103	<ul class="dropdown-menu" role="menu" aria-labelledby="itemactions[% item_loo.itemnumber \| html %]">	105	<ul class="dropdown-menu" role="menu" aria-labelledby="itemactions[% item.itemnumber \| html %]">
104		106
105	[% IF ( item_loo.hostitemflag ) %]	107	[% IF item.biblionumber != biblionumber %] [%# Host item %]
106	<li><a href="additem.pl?op=edititem&biblionumber=[% item_loo.hostbiblionumber \| uri %]&itemnumber=[% item_loo.itemnumber \| uri %]#edititem">Edit in host</a>   <a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delinkitem&biblionumber=[% biblionumber \| html %]&hostitemnumber=[% item_loo.itemnumber \| html %]&searchid=[% searchid \| html %]">Delink</a></li>	108	<li><a href="additem.pl?op=edititem&biblionumber=[% item.biblionumber \| uri %]&itemnumber=[% item.itemnumber \| uri %]#edititem">Edit in host</a>   <a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delinkitem&biblionumber=[% biblionumber \| html %]&hostitemnumber=[% item.itemnumber \| html %]&searchid=[% searchid \| html %]">Delink</a></li>
107	[% ELSE %]	109	[% ELSE %]
108	<li><a href="additem.pl?op=edititem&biblionumber=[% biblionumber \| uri %]&itemnumber=[% item_loo.itemnumber \| uri %]&searchid=[% searchid \| uri %]#edititem">Edit</a></li>	110	<li><a href="additem.pl?op=edititem&biblionumber=[% biblionumber \| uri %]&itemnumber=[% item.itemnumber \| uri %]&searchid=[% searchid \| uri %]#edititem">Edit</a></li>
109	<li><a href="additem.pl?op=dupeitem&biblionumber=[% biblionumber \| uri %]&itemnumber=[% item_loo.itemnumber \| uri %]&searchid=[% searchid \| uri %]#additema">Duplicate</a></li>	111	<li><a href="additem.pl?op=dupeitem&biblionumber=[% biblionumber \| uri %]&itemnumber=[% item.itemnumber \| uri %]&searchid=[% searchid \| uri %]#additema">Duplicate</a></li>
110	<li class="print_label"><a href="/cgi-bin/koha/labels/label-edit-batch.pl?op=add&number_type=itemnumber&number_list=[% item_loo.itemnumber \| uri %]" target="_blank" >Print label</a></li>	112	<li class="print_label"><a href="/cgi-bin/koha/labels/label-edit-batch.pl?op=add&number_type=itemnumber&number_list=[% item.itemnumber \| uri %]" target="_blank" >Print label</a></li>
111	[% IF ( item_loo.countanalytics ) %]	113	<li><a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delitem&biblionumber=[% item.biblionumber \| html %]&itemnumber=[% item.itemnumber \| html %]&searchid=[% searchid \| html %]" onclick="return confirm_deletion();">Delete</a></li>
112	<li><a href="/cgi-bin/koha/catalogue/search.pl?idx=hi&q=% item_loo.itemnumber %]">View analytics</a></li>
113	[% ELSE %]
114	<li><a class="delete" href="/cgi-bin/koha/cataloguing/additem.pl?op=delitem&biblionumber=[% biblionumber \| html %]&itemnumber=[% item_loo.itemnumber \| html %]&searchid=[% searchid \| html %]" onclick="return confirm_deletion();">Delete</a></li>
115	[% END %]
116	[% END %]	114	[% END %]
117	[% IF ( OPACBaseURL ) %]	115	[% IF ( OPACBaseURL ) %]
118	<li class="view-in-opac"><a target="_blank" href="[% Koha.Preference('OPACBaseURL') \| url %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber \| uri %]">OPAC view</a></li>	116	<li class="view-in-opac"><a target="_blank" href="[% Koha.Preference('OPACBaseURL') \| url %]/cgi-bin/koha/opac-detail.pl?biblionumber=[% item.biblionumber \| uri %]">OPAC view</a></li>
119	[% END %]	117	[% END %]
120	</ul>	118	</ul>
121	</div>	119	</div>
122	</td>	120	</td>
123	[% END %]	121	[% END %]
124	[% FOREACH item_valu IN item_loo.item_value %]	122	[% FOREACH header IN item_header_loop %]
125	[% IF item_valu.datatype == 'date' %]	123	[% SET attribute = header.attribute %]
126	<td data-order="[% item_valu.field \| html %]">[% item_valu.field \| $KohaDates %]</td>	124	[% IF header.attribute AND date_fields.grep(attribute).size %]
		125	<td data-order="[% item.$attribute \| html %]">[% item.$attribute \| $KohaDates %]</td>
127	[% ELSE %]	126	[% ELSE %]
128	<td>[% item_valu.field \| html %]</td>	127	<td>[% item.$attribute \| html %]</td>
129	[% END %]	128	[% END %]
130	[% END %]	129	[% END %]
131	</tr>	130	</tr>
Lines 155-180 Link Here
155	[% END %]	154	[% END %]
156	<fieldset class="rows">	155	<fieldset class="rows">
157	<ol>	156	<ol>
158	[% FOREACH ite IN item %]	157	[% FOREACH subfield IN subfields %]
159		158
160	[% IF ite.kohafield == 'items.more_subfields_xml' %]	159	[% IF subfield.kohafield == 'items.more_subfields_xml' %]
161	[% SET kohafield = 'items.more_subfields_xml_' _ ite.subfield %]	160	[% SET kohafield = 'items.more_subfields_xml_' _ subfield.subfield %]
162	[% ELSE %]	161	[% ELSE %]
163	[% SET kohafield = ite.kohafield %]	162	[% SET kohafield = subfield.kohafield %]
164	[% END %]	163	[% END %]
165		164
166	<li><div class="subfield_line" style="[% ite.visibility \| html %]" id="subfield[% ite.tag \| html %][% ite.subfield \| html %][% ite.random \| html %]">	165	<li><div class="subfield_line" style="[% subfield.visibility \| html %]" id="subfield[% subfield.tag \| html %][% subfield.subfield \| html %][% subfield.random \| html %]">
167	[% IF ( ite.mandatory ) %]	166	[% IF ( subfield.mandatory ) %]
168	<label class="required">[% ite.subfield \| html %] - [% ite.marc_lib \| $raw %]</label>	167	<label class="required">[% subfield.subfield \| html %] - [% subfield.marc_lib \| $raw %]</label>
169	[% ELSE %]	168	[% ELSE %]
170	<label>[% ite.subfield \| html %] - [% ite.marc_lib \| $raw %]</label>	169	<label>[% subfield.subfield \| html %] - [% subfield.marc_lib \| $raw %]</label>
171	[% END %]	170	[% END %]
172		171
173	[% SET mv = ite.marc_value %]	172	[% SET mv = subfield.marc_value %]
174	[% IF ( mv.type == 'hidden' ) %]	173	[% IF ( mv.type == 'hidden' ) %]
175	<input type="hidden" id="[%- mv.id \| html -%]" name="[% kohafield %]" class="input_marceditor" size="50" maxlength="[%- mv.maxlength \| html -%]" value="[%- mv.value \| html -%]">	174	<input type="hidden" id="[%- mv.id \| html -%]" name="[% kohafield %]" class="input_marceditor" size="50" maxlength="[%- mv.maxlength \| html -%]" value="[%- mv.value \| html -%]">
176	[% ELSIF ( mv.type == 'select' ) %]	175	[% ELSIF ( mv.type == 'select' ) %]
177	[% IF ( mv.readonly \|\| ite.IS_RETURN_CLAIM ) %]	176	[% IF ( mv.readonly \|\| subfield.IS_RETURN_CLAIM ) %]
178	<select name="[% kohafield %]" id="[%- mv.id \| html -%]" class="input_marceditor" readonly="readonly" disabled="disabled">	177	<select name="[% kohafield %]" id="[%- mv.id \| html -%]" class="input_marceditor" readonly="readonly" disabled="disabled">
179	[% ELSE %]	178	[% ELSE %]
180	<select name="[% kohafield %]" id="[%- mv.id \| html -%]" class="input_marceditor" data-category="[% mv.category \| html %]">	179	<select name="[% kohafield %]" id="[%- mv.id \| html -%]" class="input_marceditor" data-category="[% mv.category \| html %]">
Lines 183-189 Link Here
183	[% IF aval == mv.default %]	182	[% IF aval == mv.default %]
184	<option value="[%- aval \| html -%]" selected="selected">[%- mv.labels.$aval \| html -%]</option>	183	<option value="[%- aval \| html -%]" selected="selected">[%- mv.labels.$aval \| html -%]</option>
185	[% ELSE %]	184	[% ELSE %]
186	[% IF ite.IS_LOST_AV && Koha.Preference("ClaimReturnedLostValue") && aval == Koha.Preference("ClaimReturnedLostValue") %]	185	[% IF subfield.IS_LOST_AV && Koha.Preference("ClaimReturnedLostValue") && aval == Koha.Preference("ClaimReturnedLostValue") %]
187	<option disabled="disabled" value="[%- aval \| html -%]" title="Return claims must be processed from the patron details page">[%- mv.labels.$aval \| html -%]</option>	186	<option disabled="disabled" value="[%- aval \| html -%]" title="Return claims must be processed from the patron details page">[%- mv.labels.$aval \| html -%]</option>
188	[% ELSE %]	187	[% ELSE %]
189	<option value="[%- aval \| html -%]">[%- mv.labels.$aval \| html -%]</option>	188	<option value="[%- aval \| html -%]">[%- mv.labels.$aval \| html -%]</option>
Lines 225-244 Link Here
225	[% END %]	224	[% END %]
226	[% END %]	225	[% END %]
227		226
228	[% IF ite.kohafield == 'items.more_subfields_xml' %]	227	[% IF subfield.kohafield == 'items.more_subfields_xml' %]
229	<input type="hidden" name="items.more_subfields_xml" value="[% ite.subfield %]" />	228	<input type="hidden" name="items.more_subfields_xml" value="[% subfield.subfield %]" />
230	[% END %]	229	[% END %]
231	<input type="hidden" name="tag" value="[% ite.tag \| html %]" />	230	<input type="hidden" name="tag" value="[% subfield.tag \| html %]" />
232	<input type="hidden" name="subfield" value="[% ite.subfield \| html %]" />	231	<input type="hidden" name="subfield" value="[% subfield.subfield \| html %]" />
233	<input type="hidden" name="mandatory" value="[% ite.mandatory \| html %]" />	232	<input type="hidden" name="mandatory" value="[% subfield.mandatory \| html %]" />
234	<input type="hidden" name="important" value="[% ite.important \| html %]" />	233	<input type="hidden" name="important" value="[% subfield.important \| html %]" />
235	[% IF ( ite.repeatable ) %]	234	[% IF ( subfield.repeatable ) %]
236	<a href="#" class="buttonPlus" onclick="CloneItemSubfield(this.parentNode.parentNode); return false;">	235	<a href="#" class="buttonPlus" onclick="CloneItemSubfield(this.parentNode.parentNode); return false;">
237	<img src="[% interface \| html %]/[% theme \| html %]/img/clone-subfield.png" alt="Clone" title="Clone this subfield" />	236	<img src="[% interface \| html %]/[% theme \| html %]/img/clone-subfield.png" alt="Clone" title="Clone this subfield" />
238	</a>	237	</a>
239	[% END %]	238	[% END %]
240	[% IF ( ite.mandatory ) %] <span class="required">Required</span>	239	[% IF ( subfield.mandatory ) %] <span class="required">Required</span>
241	[% ELSIF ( ite.important ) %] <span class="important">Important</span>	240	[% ELSIF ( subfield.important ) %] <span class="important">Important</span>
242	[% END %]	241	[% END %]
243	</div></li>	242	</div></li>
244	[% END %]	243	[% END %]
245	-