|
Line 0
Link Here
|
| 0 |
- |
1 |
#!/usr/bin/perl |
|
|
2 |
|
| 3 |
# Copyright The National Library of Finland, University of Helsinki 2020 |
| 4 |
# Copyright Petro Vashchuk <stalkernoid@gmail.com> 2020 |
| 5 |
# |
| 6 |
# This file is part of Koha. |
| 7 |
# |
| 8 |
# Koha is free software; you can redistribute it and/or modify it under the |
| 9 |
# terms of the GNU General Public License as published by the Free Software |
| 10 |
# Foundation; either version 3 of the License, or (at your option) any later |
| 11 |
# version. |
| 12 |
# |
| 13 |
# Koha is distributed in the hope that it will be useful, but WITHOUT ANY |
| 14 |
# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR |
| 15 |
# A PARTICULAR PURPOSE. See the GNU General Public License for more details. |
| 16 |
# |
| 17 |
# You should have received a copy of the GNU General Public License along |
| 18 |
# with Koha; if not, see <http://www.gnu.org/licenses>. |
| 19 |
|
| 20 |
use Modern::Perl; |
| 21 |
|
| 22 |
use C4::Context; |
| 23 |
use Koha::CirculationRules; |
| 24 |
|
| 25 |
use Test::More tests => 13; |
| 26 |
|
| 27 |
use t::lib::TestBuilder; |
| 28 |
use t::lib::Mocks; |
| 29 |
use Koha::Holds; |
| 30 |
|
| 31 |
use Koha::Account; |
| 32 |
use Koha::Account::DebitTypes; |
| 33 |
|
| 34 |
BEGIN { |
| 35 |
use_ok('C4::Reserves'); |
| 36 |
} |
| 37 |
|
| 38 |
my $schema = Koha::Database->schema; |
| 39 |
$schema->storage->txn_begin; |
| 40 |
my $dbh = C4::Context->dbh; |
| 41 |
|
| 42 |
my $builder = t::lib::TestBuilder->new; |
| 43 |
|
| 44 |
my $library1 = $builder->build({ |
| 45 |
source => 'Branch', |
| 46 |
}); |
| 47 |
my $library2 = $builder->build({ |
| 48 |
source => 'Branch', |
| 49 |
}); |
| 50 |
|
| 51 |
my $bib_title = "Test Title"; |
| 52 |
|
| 53 |
my $borrower = $builder->build({ |
| 54 |
source => 'Borrower', |
| 55 |
value => { |
| 56 |
branchcode => $library1->{branchcode}, |
| 57 |
} |
| 58 |
}); |
| 59 |
|
| 60 |
my $itemtype1 = $builder->build({ |
| 61 |
source => 'Itemtype', |
| 62 |
value => {} |
| 63 |
}); |
| 64 |
my $itemtype2 = $builder->build({ |
| 65 |
source => 'Itemtype', |
| 66 |
value => {} |
| 67 |
}); |
| 68 |
my $itemtype3 = $builder->build({ |
| 69 |
source => 'Itemtype', |
| 70 |
value => {} |
| 71 |
}); |
| 72 |
my $itemtype4 = $builder->build({ |
| 73 |
source => 'Itemtype', |
| 74 |
value => {} |
| 75 |
}); |
| 76 |
|
| 77 |
my $borrowernumber = $borrower->{borrowernumber}; |
| 78 |
|
| 79 |
my $library_A_code = $library1->{branchcode}; |
| 80 |
|
| 81 |
my $biblio = $builder->build_sample_biblio({itemtype => $itemtype1->{itemtype}}); |
| 82 |
my $biblionumber = $biblio->biblionumber; |
| 83 |
my $item1 = $builder->build_sample_item({ |
| 84 |
biblionumber => $biblionumber, |
| 85 |
itype => $itemtype1->{itemtype}, |
| 86 |
homebranch => $library_A_code, |
| 87 |
holdingbranch => $library_A_code |
| 88 |
}); |
| 89 |
my $item2 = $builder->build_sample_item({ |
| 90 |
biblionumber => $biblionumber, |
| 91 |
itype => $itemtype2->{itemtype}, |
| 92 |
homebranch => $library_A_code, |
| 93 |
holdingbranch => $library_A_code |
| 94 |
}); |
| 95 |
my $item3 = $builder->build_sample_item({ |
| 96 |
biblionumber => $biblionumber, |
| 97 |
itype => $itemtype3->{itemtype}, |
| 98 |
homebranch => $library_A_code, |
| 99 |
holdingbranch => $library_A_code |
| 100 |
}); |
| 101 |
|
| 102 |
my $library_B_code = $library2->{branchcode}; |
| 103 |
|
| 104 |
my $biblio2 = $builder->build_sample_biblio({itemtype => $itemtype4->{itemtype}}); |
| 105 |
my $biblionumber2 = $biblio2->biblionumber; |
| 106 |
my $item4 = $builder->build_sample_item({ |
| 107 |
biblionumber => $biblionumber2, |
| 108 |
itype => $itemtype4->{itemtype}, |
| 109 |
homebranch => $library_B_code, |
| 110 |
holdingbranch => $library_B_code |
| 111 |
}); |
| 112 |
|
| 113 |
$dbh->do("DELETE FROM circulation_rules"); |
| 114 |
Koha::CirculationRules->set_rules( |
| 115 |
{ |
| 116 |
itemtype => $itemtype1->{itemtype}, |
| 117 |
categorycode => undef, |
| 118 |
branchcode => undef, |
| 119 |
rules => { |
| 120 |
expire_reserves_charge => '111' |
| 121 |
} |
| 122 |
} |
| 123 |
); |
| 124 |
Koha::CirculationRules->set_rules( |
| 125 |
{ |
| 126 |
itemtype => $itemtype2->{itemtype}, |
| 127 |
categorycode => undef, |
| 128 |
branchcode => undef, |
| 129 |
rules => { |
| 130 |
expire_reserves_charge => undef |
| 131 |
} |
| 132 |
} |
| 133 |
); |
| 134 |
Koha::CirculationRules->set_rules( |
| 135 |
{ |
| 136 |
itemtype => undef, |
| 137 |
categorycode => undef, |
| 138 |
branchcode => $library_B_code, |
| 139 |
rules => { |
| 140 |
expire_reserves_charge => '444' |
| 141 |
} |
| 142 |
} |
| 143 |
); |
| 144 |
|
| 145 |
t::lib::Mocks::mock_preference('ReservesControlBranch', 'ItemHomeLibrary'); |
| 146 |
|
| 147 |
my $reserve_id; |
| 148 |
my $account; |
| 149 |
my $status; |
| 150 |
my $start_balance; |
| 151 |
|
| 152 |
# TEST: Hold itemtype1 item |
| 153 |
$reserve_id = AddReserve( |
| 154 |
{ |
| 155 |
branchcode => $library_A_code, |
| 156 |
borrowernumber => $borrowernumber, |
| 157 |
biblionumber => $biblionumber, |
| 158 |
priority => 1, |
| 159 |
itemnumber => $item1->itemnumber, |
| 160 |
} |
| 161 |
); |
| 162 |
|
| 163 |
$account = Koha::Account->new({ patron_id => $borrowernumber }); |
| 164 |
|
| 165 |
( $status ) = CheckReserves($item1->id); |
| 166 |
is( $status, 'Reserved', "Hold for the itemtype1 created" ); |
| 167 |
|
| 168 |
$start_balance = $account->balance(); |
| 169 |
|
| 170 |
Koha::Holds->find( $reserve_id )->cancel({ charge_cancel_fee => 1 }); |
| 171 |
|
| 172 |
( $status ) = CheckReserves($item1->id); |
| 173 |
is( $status, '', "Hold for the itemtype1 cancelled" ); |
| 174 |
|
| 175 |
is( $account->balance() - $start_balance, 111, "Used circulation rule for itemtype1" ); |
| 176 |
|
| 177 |
# TEST: circulation rule for itemtype2 has 'expire_reserves_charge' set undef, so it should use ExpireReservesMaxPickUpDelayCharge preference |
| 178 |
t::lib::Mocks::mock_preference('ExpireReservesMaxPickUpDelayCharge', 222); |
| 179 |
|
| 180 |
$reserve_id = AddReserve( |
| 181 |
{ |
| 182 |
branchcode => $library_A_code, |
| 183 |
borrowernumber => $borrowernumber, |
| 184 |
biblionumber => $biblionumber, |
| 185 |
priority => 1, |
| 186 |
itemnumber => $item2->itemnumber, |
| 187 |
} |
| 188 |
); |
| 189 |
|
| 190 |
$account = Koha::Account->new({ patron_id => $borrowernumber }); |
| 191 |
|
| 192 |
( $status ) = CheckReserves($item2->id); |
| 193 |
is( $status, 'Reserved', "Hold for the itemtype2 created" ); |
| 194 |
|
| 195 |
$start_balance = $account->balance(); |
| 196 |
|
| 197 |
Koha::Holds->find( $reserve_id )->cancel({ charge_cancel_fee => 1 }); |
| 198 |
|
| 199 |
( $status ) = CheckReserves($item2->id); |
| 200 |
is( $status, '', "Hold for the itemtype2 cancelled" ); |
| 201 |
|
| 202 |
is( $account->balance() - $start_balance, 222, "Used ExpireReservesMaxPickUpDelayCharge preference as expire_reserves_charge set to undef" ); |
| 203 |
|
| 204 |
# TEST: no circulation rules for itemtype3, it should use ExpireReservesMaxPickUpDelayCharge preference |
| 205 |
t::lib::Mocks::mock_preference('ExpireReservesMaxPickUpDelayCharge', 333); |
| 206 |
|
| 207 |
$reserve_id = AddReserve( |
| 208 |
{ |
| 209 |
branchcode => $library_A_code, |
| 210 |
borrowernumber => $borrowernumber, |
| 211 |
biblionumber => $biblionumber, |
| 212 |
priority => 1, |
| 213 |
itemnumber => $item3->itemnumber, |
| 214 |
} |
| 215 |
); |
| 216 |
|
| 217 |
$account = Koha::Account->new({ patron_id => $borrowernumber }); |
| 218 |
|
| 219 |
( $status ) = CheckReserves($item3->id); |
| 220 |
is( $status, 'Reserved', "Hold for the itemtype3 created" ); |
| 221 |
|
| 222 |
$start_balance = $account->balance(); |
| 223 |
|
| 224 |
Koha::Holds->find( $reserve_id )->cancel({ charge_cancel_fee => 1 }); |
| 225 |
|
| 226 |
( $status ) = CheckReserves($item3->id); |
| 227 |
is( $status, '', "Hold for the itemtype3 cancelled" ); |
| 228 |
|
| 229 |
is( $account->balance() - $start_balance, 333, "Used ExpireReservesMaxPickUpDelayCharge preference as there's no circulation rules for itemtype3" ); |
| 230 |
|
| 231 |
# TEST: circulation rule for itemtype4 with library_B_code |
| 232 |
t::lib::Mocks::mock_preference('ExpireReservesMaxPickUpDelayCharge', 555); |
| 233 |
|
| 234 |
$reserve_id = AddReserve( |
| 235 |
{ |
| 236 |
branchcode => $library_B_code, |
| 237 |
borrowernumber => $borrowernumber, |
| 238 |
biblionumber => $biblionumber2, |
| 239 |
priority => 1, |
| 240 |
itemnumber => $item4->itemnumber, |
| 241 |
} |
| 242 |
); |
| 243 |
|
| 244 |
$account = Koha::Account->new({ patron_id => $borrowernumber }); |
| 245 |
|
| 246 |
( $status ) = CheckReserves($item4->id); |
| 247 |
is( $status, 'Reserved', "Hold for the itemtype4 created" ); |
| 248 |
|
| 249 |
$start_balance = $account->balance(); |
| 250 |
|
| 251 |
Koha::Holds->find( $reserve_id )->cancel({ charge_cancel_fee => 1 }); |
| 252 |
|
| 253 |
( $status ) = CheckReserves($item4->id); |
| 254 |
is( $status, '', "Hold for the itemtype4 cancelled" ); |
| 255 |
|
| 256 |
is( $account->balance() - $start_balance, 444, "Used circulation rule for itemtype4 with library_B_code" ); |
| 257 |
|
| 258 |
$schema->storage->txn_rollback; |