|
Lines 17-23
Link Here
|
| 17 |
|
17 |
|
| 18 |
use Modern::Perl; |
18 |
use Modern::Perl; |
| 19 |
|
19 |
|
| 20 |
use Test::More tests => 2; |
20 |
use Test::More tests => 4; |
| 21 |
use Test::MockModule; |
21 |
use Test::MockModule; |
| 22 |
use Test::Exception; |
22 |
use Test::Exception; |
| 23 |
|
23 |
|
|
Lines 30-41
BEGIN {
Link Here
|
| 30 |
my $schema = Koha::Database->new->schema; |
30 |
my $schema = Koha::Database->new->schema; |
| 31 |
my $builder = t::lib::TestBuilder->new; |
31 |
my $builder = t::lib::TestBuilder->new; |
| 32 |
|
32 |
|
| 33 |
my $uuid_gen_client_id_counter = 0; |
|
|
| 34 |
my $uuid_gen_secret_counter = 0; |
| 35 |
|
| 36 |
subtest 'store() tests' => sub { |
33 |
subtest 'store() tests' => sub { |
| 37 |
|
34 |
|
| 38 |
plan tests => 13; |
35 |
plan tests => 16; |
| 39 |
|
36 |
|
| 40 |
$schema->storage->txn_begin; |
37 |
$schema->storage->txn_begin; |
| 41 |
|
38 |
|
|
Lines 46-52
subtest 'store() tests' => sub {
Link Here
|
| 46 |
|
43 |
|
| 47 |
my $patron_1 = $builder->build_object( { class => 'Koha::Patrons' } ); |
44 |
my $patron_1 = $builder->build_object( { class => 'Koha::Patrons' } ); |
| 48 |
my $description = 'Coral API key'; |
45 |
my $description = 'Coral API key'; |
| 49 |
my $api_key = Koha::ApiKey->new({ patron_id => $patron_1->id, description => $description })->store; |
46 |
|
|
|
47 |
my $api_key = Koha::ApiKey->new( |
| 48 |
{ |
| 49 |
patron_id => $patron_1->id, |
| 50 |
description => $description |
| 51 |
} |
| 52 |
)->store; |
| 50 |
|
53 |
|
| 51 |
# re-read from DB |
54 |
# re-read from DB |
| 52 |
$api_key->discard_changes; |
55 |
$api_key->discard_changes; |
|
Lines 75-80
subtest 'store() tests' => sub {
Link Here
|
| 75 |
is( $api_key->patron_id, $original_api_key->{patron_id}, '->store() preserves the patron_id' ); |
78 |
is( $api_key->patron_id, $original_api_key->{patron_id}, '->store() preserves the patron_id' ); |
| 76 |
is( $api_key->active, 0, '->store() preserves the active value' ); |
79 |
is( $api_key->active, 0, '->store() preserves the active value' ); |
| 77 |
|
80 |
|
|
|
81 |
$api_key->set({ client_id => 'NewID!' }); |
| 82 |
|
| 83 |
throws_ok { |
| 84 |
$api_key->store |
| 85 |
} |
| 86 |
'Koha::Exceptions::Object::ReadOnlyProperty', |
| 87 |
'Read-only attribute overwrite attempt raises exception'; |
| 88 |
|
| 89 |
is( $@->property, 'client_id', 'Correct attribute reported back' ); |
| 90 |
|
| 91 |
$api_key->discard_changes; |
| 92 |
# set a writeable attribute |
| 93 |
$api_key->set({ description => 'Hey' }); |
| 94 |
lives_ok { $api_key->store } 'Updating a writeable attribute works'; |
| 95 |
|
| 78 |
my $patron_to_delete = $builder->build_object( { class => 'Koha::Patrons' } ); |
96 |
my $patron_to_delete = $builder->build_object( { class => 'Koha::Patrons' } ); |
| 79 |
my $deleted_id = $patron_to_delete->id; |
97 |
my $deleted_id = $patron_to_delete->id; |
| 80 |
$patron_to_delete->delete; |
98 |
$patron_to_delete->delete; |
|
Lines 96-98
subtest 'store() tests' => sub {
Link Here
|
| 96 |
|
114 |
|
| 97 |
$schema->storage->txn_rollback; |
115 |
$schema->storage->txn_rollback; |
| 98 |
}; |
116 |
}; |
| 99 |
- |
117 |
|
|
|
118 |
subtest 'validate_secret() tests' => sub { |
| 119 |
|
| 120 |
plan tests => 2; |
| 121 |
|
| 122 |
$schema->storage->txn_begin; |
| 123 |
|
| 124 |
my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); |
| 125 |
my $api_key = Koha::ApiKey->new( |
| 126 |
{ patron_id => $patron->id, |
| 127 |
description => 'The description' |
| 128 |
} |
| 129 |
)->store; |
| 130 |
|
| 131 |
my $secret = $api_key->plain_text_secret; |
| 132 |
|
| 133 |
ok( $api_key->validate_secret( $secret ), 'Valid secret returns true' ); |
| 134 |
ok( !$api_key->validate_secret( 'Wrong secret' ), 'Invalid secret returns true' ); |
| 135 |
|
| 136 |
$schema->storage->txn_rollback; |
| 137 |
}; |
| 138 |
|
| 139 |
subtest 'plain_text_secret() tests' => sub { |
| 140 |
|
| 141 |
plan tests => 2; |
| 142 |
|
| 143 |
$schema->storage->txn_begin; |
| 144 |
|
| 145 |
my $patron = $builder->build_object({ class => 'Koha::Patrons' }); |
| 146 |
# generate a fresh API key |
| 147 |
my $api_key = Koha::ApiKey->new({ description => 'blah', patron_id => $patron->id })->store; |
| 148 |
my $plain_text_secret = $api_key->plain_text_secret; |
| 149 |
|
| 150 |
ok( defined $plain_text_secret, 'A fresh API key carries its plain text secret' ); |
| 151 |
ok( $plain_text_secret ne q{}, 'Plain text secret is not an empty string' ); |
| 152 |
|
| 153 |
$schema->storage->txn_rollback; |
| 154 |
}; |